[Bug 39916] New: The 'Place booking' modal should have cypress tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Bug ID: 39916 Summary: The 'Place booking' modal should have cypress tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org The bookings modal is one of the more complex modal forms we have, with a lot of logic involved. We should add cypress tests to ensure we don't see regressions here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182515&action=edit Bug 39916: Add select2 helpers to cypress This patch adds some helper methods for testing with select2 selects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182516&action=edit Bug 39916: WIP Cypress tests for the bookings modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182515|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182545&action=edit Bug 39916: Add select2 helpers to cypress This patch adds some helper methods for testing with select2 selects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182516|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182546&action=edit Bug 39916: WIP Cypress tests for the bookings modal Lots of passing tests :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182545|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182635&action=edit Bug 39916: Add select2 helpers to cypress This patch adds some helper methods for testing with select2 selects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182636&action=edit Bug 39916: Add cypress helpers for flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182546|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182637&action=edit Bug 39916: WIP Cypress tests for the bookings modal Lots of passing tests :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39584 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 [Bug 35248] Bookings needs unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39584 [Bug 39584] Booking post-processing time cuts into circulation period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182635|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182771&action=edit Bug 39916: Add select2 helpers to cypress This patch adds some helper methods for testing with select2 selects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182772&action=edit Bug 39916: Add flatpickr helpers to cypress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182637|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182773&action=edit Bug 39916: WIP Cypress tests for the bookings modal Lots of passing tests :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just curious why we have patches here and an ASSIGNED status still. Note that this is a dependency for a bug in SO queue too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 [Bug 40134] Fix and optimise 'Any item' functionality of bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com, | |kyle.m.hall@gmail.com Circulation| |Bookings function| | Component|Test Suite |Circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182771|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183206&action=edit Bug 39916: Add select2 helpers to cypress This adds helper methods for cypress to work with select2 dropdowns: - selectFromSelect2ByIndex() - select by option index - selectFromSelect2() - select by text value - clearSelect2() - clear selection These helpers handle the complexities of interacting with Select2 components which cannot be selected using standard Cypress commands. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182772|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183207&action=edit Bug 39916: Add flatpickr helpers to cypress This adds helper methods for cypress to work with flatpickr date pickers: - openFlatpickr() - open the calendar - selectFlatpickrDate() - select a single date - selectFlatpickrDateRange() - select date range - clearFlatpickr() - clear the selected dates - getFlatpickrDate() - get specific date element - navigateToFlatpickrMonth() - navigate calendar These helpers simplify date picker testing when using flatpickr. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183208&action=edit Bug 39916: Cypress tests for the bookings modal This adds comprehensive end-to-end tests for the booking modal functionality: - Modal loading and field validation - Form field enabling sequence - Item type and item selection dependencies - Date picker validation and restrictions - Booking conflict detection - Lead/trail period handling - Form submission (create and edit) - Error handling and form reset Tests use optimized shared mock data generation with cy.task() for realistic test data while minimizing memory usage. Tests cover both positive and negative scenarios. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183209&action=edit Bug 39916: Fix booking modal redraw issue Fixes an issue where the booking modal's date picker and form fields were not properly updating when switching between different booking scenarios or after form submissions. The fix ensures proper redraw and state management of the flatpickr component and associated form elements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183210&action=edit Bug 39916: Fix race condition in booking modal edit mode When editing an existing booking, the item type field was not being populated because setFormValues() was triggering the wrong Select2 event. The fix ensures both 'change' and 'select2:select' events are triggered with proper data structure, allowing the item type to be automatically populated based on the selected item's effective_item_type_id. A small timeout prevents race conditions during DOM initialization. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182636|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182773|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- (In reply to Marcel de Rooy from comment #11)
Just curious why we have patches here and an ASSIGNED status still. Note that this is a dependency for a bug in SO queue too.
Because I was still working on tests and I didn't want those subsequent bugs to go in without any. As for why the other one got signed off.. just a matter of people testing things in real life.. there's not a hard code dependency here, so the patches applied without this bug and they tested them in the UI and they're were good there. Anyway.. I think we're in a good place now.. I'm about to revisit the other bug and add tests for it that add to the one's here at which point we'll be covered well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from David Nind <david@davidnind.com> --- One test is failing for me - 1) should edit an existing booking successfully. Testing notes (using KTD): 1, Apply the patches. 2. Restart everything. 3. Run the tests, they should all pass: yarn cypress run --spec t/cypress/integration/Biblio/bookingsModal_spec.ts Test results: Booking Modal Tests ✓ should load the booking modal correctly (3924ms) ✓ should enable fields in proper sequence (3490ms) ✓ should handle item type and item dependencies correctly (4836ms) ✓ should disable dates before today and between today and selected start date (4575ms) ✓ should disable dates with existing bookings for same item (4978ms) ✓ should handle lead and trail period hover highlighting (3642ms) ✓ should disable click when lead/trail periods overlap with disabled dates (3439ms) ✓ should show event dots for dates with existing bookings (3456ms) ✓ should show only the correct bold dates for issue and renewal periods (3797ms) ✓ should set correct max date based on circulation rules (3952ms) ✓ should handle visible and hidden fields on date selection (3763ms) ✓ should submit a new booking successfully (3378ms) 1) should edit an existing booking successfully ✓ should handle booking failure gracefully (3357ms) ✓ should reset form when modal is closed (3421ms) 14 passing (1m) 1 failing 1) Booking Modal Tests should edit an existing booking successfully: Timed out retrying after 10000ms + expected - actual -'19' +'456' at Context.eval (webpack://koha/./t/cypress/integration/Biblio/bookingsModal_spec.ts:1212:37) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183206|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183210|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190789&action=edit Bug 39916: Add select2 helpers to cypress This adds helper methods for cypress to work with select2 dropdowns: - selectFromSelect2ByIndex() - select by option index - selectFromSelect2() - select by text value - clearSelect2() - clear selection These helpers handle the complexities of interacting with Select2 components which cannot be selected using standard Cypress commands. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190790&action=edit Bug 39916: Add flatpickr helpers to cypress This adds helper methods for cypress to work with flatpickr date pickers: - openFlatpickr() - open the calendar - selectFlatpickrDate() - select a single date - selectFlatpickrDateRange() - select date range - clearFlatpickr() - clear the selected dates - getFlatpickrDate() - get specific date element - getFlapickrSelectedDates() - get flatpickr selected dates array - navigateToFlatpickrMonth() - navigate calendar These helpers simplify date picker testing when using flatpickr. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190791&action=edit Bug 39916: Cypress tests for the bookings modal This patch adds comprehensive Cypress end-to-end tests for the booking modal, covering all critical functionality to prevent regressions. Test coverage includes: - Basic modal functionality (bookingsModalBasic_spec.ts): * Modal loading and initial state * Progressive field enabling based on user selections * Item type and item dependencies * Form validation * Booking submission (create and update) * Form interactions and field visibility * Edit mode functionality * Error handling - Date picker functionality (bookingsModalDatePicker_spec.ts): * Flatpickr initialization with future-date constraints * Date disabling for existing bookings * Date range validation * Circulation rules date calculations and visual feedback * Lead and trail period functionality * Event dots for dates with existing bookings These tests ensure the booking modal works correctly across all scenarios and helps maintain code quality during future development. Test plan: 1. Run the tests inside KTD container: docker exec --user kohadev-koha --workdir /kohadevbox/koha -i kohadev-koha-1 \ bash -c 'npx cypress run --spec "t/cypress/integration/Circulation/bookings*.ts"' 2. Verify all 15 tests pass (9 basic + 6 datepicker) 3. Confirm test coverage is comprehensive for the booking modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190792&action=edit Bug 39916: Fix booking modal race conditions and redraw issues This patch addresses two critical issues in the booking modal: 1. Race condition in edit mode: When editing a booking, the item selection would sometimes fail to properly initialize because the item options weren't fully loaded with their data attributes. This caused the itemtype field to not auto-populate correctly. Fixed by moving the item pre-selection to occur after a brief delay and ensuring the select2:select event is triggered with proper data parameters including the element reference. 2. Flatpickr redraw issue: The datepicker would lose its disabled dates after certain operations because the disable configuration wasn't being reapplied during redraws. Fixed by explicitly setting the disable configuration before calling redraw() to ensure disabled dates are properly maintained. Additionally fixes a scope issue with the booking loop variable. Test plan: 1. Create a booking with specific dates 2. Edit the booking - verify the item and itemtype are correctly selected 3. Change selections in the modal - verify disabled dates remain correct 4. Create new bookings - verify date restrictions work properly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|39584 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39584 [Bug 39584] Booking post-processing time cuts into circulation period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190789|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190790|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190791|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190792|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190816&action=edit Bug 39916: Add select2 helpers to cypress This adds helper methods for cypress to work with select2 dropdowns: - selectFromSelect2ByIndex() - select by option index - selectFromSelect2() - select by text value - clearSelect2() - clear selection These helpers handle the complexities of interacting with Select2 components which cannot be selected using standard Cypress commands. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190817&action=edit Bug 39916: Add flatpickr helpers to cypress This adds helper methods for cypress to work with flatpickr date pickers: - openFlatpickr() - open the calendar - selectFlatpickrDate() - select a single date - selectFlatpickrDateRange() - select date range - clearFlatpickr() - clear the selected dates - getFlatpickrDate() - get specific date element - getFlapickrSelectedDates() - get flatpickr selected dates array - navigateToFlatpickrMonth() - navigate calendar These helpers simplify date picker testing when using flatpickr. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190818&action=edit Bug 39916: Cypress tests for the bookings modal This patch adds comprehensive Cypress end-to-end tests for the booking modal, covering all critical functionality to prevent regressions. Test coverage includes: - Basic modal functionality (bookingsModalBasic_spec.ts): * Modal loading and initial state * Progressive field enabling based on user selections * Item type and item dependencies * Form validation * Booking submission (create and update) * Form interactions and field visibility * Edit mode functionality * Error handling - Date picker functionality (bookingsModalDatePicker_spec.ts): * Flatpickr initialization with future-date constraints * Date disabling for existing bookings * Date range validation * Circulation rules date calculations and visual feedback * Lead and trail period functionality * Event dots for dates with existing bookings These tests ensure the booking modal works correctly across all scenarios and helps maintain code quality during future development. Test plan: 1. Run the tests inside KTD container: docker exec --user kohadev-koha --workdir /kohadevbox/koha -i kohadev-koha-1 \ bash -c 'npx cypress run --spec "t/cypress/integration/Circulation/bookings*.ts"' 2. Verify all 15 tests pass (9 basic + 6 datepicker) 3. Confirm test coverage is comprehensive for the booking modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190819&action=edit Bug 39916: Fix booking modal race conditions and redraw issues This patch addresses two critical issues in the booking modal: 1. Race condition in edit mode: When editing a booking, the item selection would sometimes fail to properly initialize because the item options weren't fully loaded with their data attributes. This caused the itemtype field to not auto-populate correctly. Fixed by moving the item pre-selection to occur after a brief delay and ensuring the select2:select event is triggered with proper data parameters including the element reference. 2. Flatpickr redraw issue: The datepicker would lose its disabled dates after certain operations because the disable configuration wasn't being reapplied during redraws. Fixed by explicitly setting the disable configuration before calling redraw() to ensure disabled dates are properly maintained. Additionally fixes a scope issue with the booking loop variable. Test plan: 1. Create a booking with specific dates 2. Edit the booking - verify the item and itemtype are correctly selected 3. Change selections in the modal - verify disabled dates remain correct 4. Create new bookings - verify date restrictions work properly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39584 [Bug 39584] Booking post-processing time cuts into circulation period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|40134 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 [Bug 40134] Fix and optimise 'Any item' functionality of bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Just a minor rebase to keep it applying for QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190816|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190818|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190819|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191710&action=edit Bug 39916: Add select2 helpers to cypress This adds helper methods for cypress to work with select2 dropdowns: - selectFromSelect2ByIndex() - select by option index - selectFromSelect2() - select by text value - clearSelect2() - clear selection These helpers handle the complexities of interacting with Select2 components which cannot be selected using standard Cypress commands. Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191711&action=edit Bug 39916: Add flatpickr helpers to cypress This adds helper methods for cypress to work with flatpickr date pickers: - openFlatpickr() - open the calendar - selectFlatpickrDate() - select a single date - selectFlatpickrDateRange() - select date range - clearFlatpickr() - clear the selected dates - getFlatpickrDate() - get specific date element - getFlapickrSelectedDates() - get flatpickr selected dates array - navigateToFlatpickrMonth() - navigate calendar These helpers simplify date picker testing when using flatpickr. Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191712&action=edit Bug 39916: Cypress tests for the bookings modal This patch adds comprehensive Cypress end-to-end tests for the booking modal, covering all critical functionality to prevent regressions. Test coverage includes: - Basic modal functionality (bookingsModalBasic_spec.ts): * Modal loading and initial state * Progressive field enabling based on user selections * Item type and item dependencies * Form validation * Booking submission (create and update) * Form interactions and field visibility * Edit mode functionality * Error handling - Date picker functionality (bookingsModalDatePicker_spec.ts): * Flatpickr initialization with future-date constraints * Date disabling for existing bookings * Date range validation * Circulation rules date calculations and visual feedback * Lead and trail period functionality * Event dots for dates with existing bookings These tests ensure the booking modal works correctly across all scenarios and helps maintain code quality during future development. Test plan: 1. Run the tests inside KTD container: docker exec --user kohadev-koha --workdir /kohadevbox/koha -i kohadev-koha-1 \ bash -c 'npx cypress run --spec "t/cypress/integration/Circulation/bookings*.ts"' 2. Verify all 15 tests pass (9 basic + 6 datepicker) 3. Confirm test coverage is comprehensive for the booking modal Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191713&action=edit Bug 39916: Fix booking modal race conditions and redraw issues This patch addresses two critical issues in the booking modal: 1. Race condition in edit mode: When editing a booking, the item selection would sometimes fail to properly initialize because the item options weren't fully loaded with their data attributes. This caused the itemtype field to not auto-populate correctly. Fixed by moving the item pre-selection to occur after a brief delay and ensuring the select2:select event is triggered with proper data parameters including the element reference. 2. Flatpickr redraw issue: The datepicker would lose its disabled dates after certain operations because the disable configuration wasn't being reapplied during redraws. Fixed by explicitly setting the disable configuration before calling redraw() to ensure disabled dates are properly maintained. Additionally fixes a scope issue with the booking loop variable. Test plan: 1. Create a booking with specific dates 2. Edit the booking - verify the item and itemtype are correctly selected 3. Change selections in the modal - verify disabled dates remain correct 4. Create new bookings - verify date restrictions work properly Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191710|0 |1 is obsolete| | --- Comment #32 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 191770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191770&action=edit Bug 39916: Add select2 helpers to cypress This adds helper methods for cypress to work with select2 dropdowns: - selectFromSelect2ByIndex() - select by option index - selectFromSelect2() - select by text value - clearSelect2() - clear selection These helpers handle the complexities of interacting with Select2 components which cannot be selected using standard Cypress commands. Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191711|0 |1 is obsolete| | --- Comment #33 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 191771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191771&action=edit Bug 39916: Add flatpickr helpers to cypress This adds helper methods for cypress to work with flatpickr date pickers: - openFlatpickr() - open the calendar - selectFlatpickrDate() - select a single date - selectFlatpickrDateRange() - select date range - clearFlatpickr() - clear the selected dates - getFlatpickrDate() - get specific date element - getFlapickrSelectedDates() - get flatpickr selected dates array - navigateToFlatpickrMonth() - navigate calendar These helpers simplify date picker testing when using flatpickr. Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191712|0 |1 is obsolete| | --- Comment #34 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 191772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191772&action=edit Bug 39916: Cypress tests for the bookings modal This patch adds comprehensive Cypress end-to-end tests for the booking modal, covering all critical functionality to prevent regressions. Test coverage includes: - Basic modal functionality (bookingsModalBasic_spec.ts): * Modal loading and initial state * Progressive field enabling based on user selections * Item type and item dependencies * Form validation * Booking submission (create and update) * Form interactions and field visibility * Edit mode functionality * Error handling - Date picker functionality (bookingsModalDatePicker_spec.ts): * Flatpickr initialization with future-date constraints * Date disabling for existing bookings * Date range validation * Circulation rules date calculations and visual feedback * Lead and trail period functionality * Event dots for dates with existing bookings These tests ensure the booking modal works correctly across all scenarios and helps maintain code quality during future development. Test plan: 1. Run the tests inside KTD container: docker exec --user kohadev-koha --workdir /kohadevbox/koha -i kohadev-koha-1 \ bash -c 'npx cypress run --spec "t/cypress/integration/Circulation/bookings*.ts"' 2. Verify all 15 tests pass (9 basic + 6 datepicker) 3. Confirm test coverage is comprehensive for the booking modal Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191713|0 |1 is obsolete| | --- Comment #35 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 191773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191773&action=edit Bug 39916: Fix booking modal race conditions and redraw issues This patch addresses two critical issues in the booking modal: 1. Race condition in edit mode: When editing a booking, the item selection would sometimes fail to properly initialize because the item options weren't fully loaded with their data attributes. This caused the itemtype field to not auto-populate correctly. Fixed by moving the item pre-selection to occur after a brief delay and ensuring the select2:select event is triggered with proper data parameters including the element reference. 2. Flatpickr redraw issue: The datepicker would lose its disabled dates after certain operations because the disable configuration wasn't being reapplied during redraws. Fixed by explicitly setting the disable configuration before calling redraw() to ensure disabled dates are properly maintained. Additionally fixes a scope issue with the booking loop variable. Test plan: 1. Create a booking with specific dates 2. Edit the booking - verify the item and itemtype are correctly selected 3. Change selections in the modal - verify disabled dates remain correct 4. Create new bookings - verify date restrictions work properly Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #36 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 191774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191774&action=edit Bug 39916: (QA follow-up) Fix typo in test comment Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #37 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- There are some failing tests now: ✓ should disable dates with existing bookings for same item (17332ms) 1) should handle date range validation correctly ✓ should handle circulation rules date calculations and visual feedback (17208ms) ✓ should show event dots for dates with existing bookings (14381ms) 4 passing (1m) 1 failing 1) Booking Modal Date Picker Tests should handle date range validation correctly: AssertionError: Timed out retrying after 10000ms: expected '<span.flatpickr-day.selected.title>' to have class 'startRange' at cy.get.should.timeout (webpack://koha/./t/cypress/support/flatpickr.js:338:58) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|nick@bywatersolutions.com |me@paulderscheid.xyz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I think this has do to with how Flatpickr navigates to a new month: it("should handle date range validation correctly", () => { setupModalForDateTesting(); // Test valid date range const startDate = dayjs().add(2, "day"); const endDate = dayjs().add(5, "day"); Its failing today, January 30, when we add 2 days because that crosses into February. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #40 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Looking.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #41 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192265&action=edit Bug 39916: (QA follow-up) Fix startRange class lost on month navigation When selecting a booking start date that triggers month navigation (e.g., selecting Feb 1 while viewing January), the flatpickr calendar would lose the 'startRange' CSS class on the selected date. This occurred because setting maxDate in the onChange handler triggered a calendar redraw, and flatpickr only applies startRange during the initial click event, not during redraws. This caused the Cypress test "should handle date range validation correctly" to fail on dates near month boundaries (e.g., January 30). The fix re-applies the startRange class after the maxDate is set, using setTimeout to ensure it runs after the redraw completes. A guard ensures this only happens when exactly one date is selected, preventing interference with end date selection. To test: - Apply patch - Open a biblio detail page with bookable items - Click "Place booking" - Select a patron, pickup location, and item - In the date picker, click a date that's in the next month (visible in the "next month" area of the calendar) - Verify the selected date shows the startRange styling (highlighted as the range start) - Select an end date - Verify the range is properly selected and the form can be submitted - Run Cypress tests: yarn cypress run --spec t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts - Verify all tests pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #42 from Paul Derscheid <paul.derscheid@lmscloud.de> --- That was much more involved than I thought, but tests pass locally again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192265|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192315&action=edit Bug 39916: (QA follow-up) Fix startRange class lost on month navigation When selecting a booking start date that triggers month navigation (e.g., selecting Feb 1 while viewing January), the flatpickr calendar would lose the 'startRange' CSS class on the selected date. This occurred because setting maxDate in the onChange handler triggered a calendar redraw, and flatpickr only applies startRange during the initial click event, not during redraws. This caused the Cypress test "should handle date range validation correctly" to fail on dates near month boundaries (e.g., January 30). The fix re-applies the startRange class after the maxDate is set, using setTimeout to ensure it runs after the redraw completes. A guard ensures this only happens when exactly one date is selected, preventing interference with end date selection. To test: - Apply patch - Open a biblio detail page with bookable items - Click "Place booking" - Select a patron, pickup location, and item - In the date picker, click a date that's in the next month (visible in the "next month" area of the calendar) - Verify the selected date shows the startRange styling (highlighted as the range start) - Select an end date - Verify the range is properly selected and the form can be submitted - Run Cypress tests: yarn cypress run --spec t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts - Verify all tests pass Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for the fix Paul, you beat me to it :) Interestingly, I'm pretty sure this is already corrected in the downstream bugs, but it's good to have it in here too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #46 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- More is needed here: Error Details Unexpected bold date: March 29, 2026: expected false to be true Stack Trace AssertionError: Unexpected bold date: March 29, 2026: expected false to be true at Context.eval (webpack://koha/./t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts:618:75) + expected - actual: failed to generate Mocha diff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #47 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I think I just fixed that in a QA follow-up on Bug 37707:
From ed454828ff3e9fe94c93c79ad0857add80a078f6 Mon Sep 17 00:00:00 2001 From: Paul Derscheid <paul.derscheid@lmscloud.de> Date: Mon, 9 Feb 2026 15:25:34 +0100 Subject: [PATCH] Bug 37707: (QA follow-up) Fix incorrect bold date expectations in Cypress test
- The test for circulation rules date calculations did not account for the start date being bold, only the period endpoint dates - place_booking.js explicitly adds the selected start date to boldDates (boldDates = [new Date(startDate)]), giving it the "title" class - The verification loop checking for unexpected bold dates then failed when it encountered the start date, which was bold but not expected - Add clearZoneStart to expectedBoldDates to match actual behavior To test: - yarn cypress run --spec t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts - Verify that the "should handle circulation rules date calculations and visual feedback" test now passes Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 --- Comment #48 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #49 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- I am not backporting this as it does not apply cleanly to 25.05.x and would require additional adjustments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org