[Bug 32333] New: IdRef system preference revamping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Bug ID: 32333 Summary: IdRef system preference revamping Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: frederic@tamil.fr QA Contact: testopia@bugs.koha-community.org IdRef system preference enables a Unimarc-only functionality. Authors fields contain in $3 subfield a PPN, an unique identifier in IdRef a French national authority file, similar to VIAF. KohaLa, the Koha French users association, has designed a revamped implementation of IdRef in Koha. The goal is to improve the visual and to add a functionality. - Visually — The author publications list is currently displayed in an old fashion dialog box. It uses greybox library, which is deprecated. See bug 8290. The list is displayed in a distinct tab of holdings block. - Functionality — The title in the list are searched in Koha local catalog. So it's possible to mark titles locally available and link to them. PPN are searched directly in Elasticsearch for efficiency. Koha IdRef users are academic libraries or higher education school. So Zebra support is not required for them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 144199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144199&action=edit Bug 32333: IdRef system preference revamping IdRef system preference enables a Unimarc-only functionality. Authors fields contain in $3 subfield a PPN, an unique identifier in IdRef a French national authority file, similar to VIAF. KohaLa, the Koha French users association, has designed a revamped implementation of IdRef in Koha. The goal is to improve the visual and to add a functionality. - Visually — The author publications list is currently displayed in an old fashion dialog box. It uses greybox library, which is deprecated. See bug 8290. With this patch, the list is displayed in a distinct tab of holdings block. - Functionality — The title in the list are searched in Koha local catalog. So it's possible to mark titles locally available and link to them. PPN are searched directly in Elasticsearch for efficiency. Koha IdRef users are academic libraries or higher education school. So Zebra support is not required for them. NOTE: After pushing this patch, greybox library could be removed completely for OPAC : /koha-tmpl/opac-tmpl/bootstrap/lib/greybox/ TO TEST : - On a Unimarc Koha, with a Sudoc compliant Catalog, enable IdRef. - Use default OPAC XSL. - On opac-detail.pl page, you can see a logo IdRef next to authors having a $3 (ppn) subfield. Click on the logo. - Confirm that a tab is added to holdings. It contains the author publications found in the Sudoc. - A Sudoc logo is displayed in front of each title. Clicking the icon open the title in Sudoc web site. - A Koha logo is displayed in from of each title available locally. Clicking the logo open the title in Koha OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|oleonard@myacpl.org |frederic@tamil.fr --- Comment #2 from David Nind <david@davidnind.com> --- Changed assignee. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144199|0 |1 is obsolete| | --- Comment #3 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 145663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145663&action=edit Bug 32333: IdRef system preference revamping IdRef system preference enables a Unimarc-only functionality. Authors fields contain in $3 subfield a PPN, an unique identifier in IdRef a French national authority file, similar to VIAF. KohaLa, the Koha French users association, has designed a revamped implementation of IdRef in Koha. The goal is to improve the visual and to add a functionality. - Visually - The author publications list is currently displayed in an old fashion dialog box. It uses greybox library, which is deprecated. See bug 8290. With this patch, the list is displayed in a distinct tab of holdings block. - Functionality - The title in the list are searched in Koha local catalog. So it's possible to mark titles locally available and link to them. PPN are searched directly in Elasticsearch for efficiency. Koha IdRef users are academic libraries or higher education school. So Zebra support is not required for them. NOTE: After pushing this patch, greybox library could be removed completely for OPAC : /koha-tmpl/opac-tmpl/bootstrap/lib/greybox/ TO TEST : - On a Unimarc Koha, with a Sudoc compliant Catalog, enable IdRef. - Use default OPAC XSL. - On opac-detail.pl page, you can see a logo IdRef next to authors having a $3 (ppn) subfield. Click on the logo. - Confirm that a tab is added to holdings. It contains the author publications found in the Sudoc. - A Sudoc logo is displayed in front of each title. Clicking the icon open the title in Sudoc web site. - A Koha logo is displayed in from of each title available locally. Clicking the logo open the title in Koha OPAC. Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com --- Comment #4 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- The patch works as expected, however, some additional information could be added to the test plan: - it only works with Elastic Search. - an extra "ppn" index must be created. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Why does this depend on 8290 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL koha-tmpl/opac-tmpl/bootstrap/js/idref.js FAIL ES template literals ES template literals found ( const url = `/cgi-bin/koha/svc/idref?ppn=${ppn}`;) - See bug 24725 ES template literals found ( const navig = publications.roles.map(role => `<a href="#idref-role-${role.code}" style="font-size: 90%;">${role.label} (${role.docs.length})</a>`);) - See bug 24725 ES template literals found ( html += `</td><td>${doc.citation}</td></tr>`;) - See bug 24725 ES template literals found ( html = `<div id="idref-publications">${html}</div>`;) - See bug 24725 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Marcel de Rooy from comment #5)
Why does this depend on 8290 ?
Because if this patch is applied, Greybox dependence can be removed completely from Koha code base? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> ---
FAIL ES template literals
Sorry for this. Why is Javascript template literal usage prohibited? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Frédéric Demians from comment #8)
FAIL ES template literals
Sorry for this. Why is Javascript template literal usage prohibited?
The clue is in the message :) Bug 24725 - xgettext does not support (yet) ES template literals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8290 Depends on|8290 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Frédéric Demians from comment #7)
(In reply to Marcel de Rooy from comment #5)
Why does this depend on 8290 ?
Because if this patch is applied, Greybox dependence can be removed completely from Koha code base?
I moved it to Blocks - this patch blocks the removal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145663|0 |1 is obsolete| | --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 147762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147762&action=edit Bug 32333: IdRef system preference revamping IdRef system preference enables a Unimarc-only functionality. Authors fields contain in $3 subfield a PPN, an unique identifier in IdRef a French national authority file, similar to VIAF. KohaLa, the Koha French users association, has designed a revamped implementation of IdRef in Koha. The goal is to improve the visual and to add a functionality. - Visually — The author publications list is currently displayed in an old fashion dialog box. It uses greybox library, which is deprecated. See bug 8290. With this patch, the list is displayed in a distinct tab of holdings block. - Functionality — The title in the list are searched in Koha local catalog. So it's possible to mark titles locally available and link to them. PPN are searched directly in Elasticsearch for efficiency. Koha IdRef users are academic libraries or higher education school. So Zebra support is not required for them. NOTE: After pushing this patch, greybox library could be removed completely for OPAC : /koha-tmpl/opac-tmpl/bootstrap/lib/greybox/ TO TEST : - On a Unimarc Koha, with a Sudoc compliant Catalog, enable IdRef. - Use default OPAC XSL. - On opac-detail.pl page, you can see a logo IdRef next to authors having a $3 (ppn) subfield. Click on the logo. - Confirm that a tab is added to holdings. It contains the author publications found in the Sudoc. - A Sudoc logo is displayed in front of each title. Clicking the icon open the title in Sudoc web site. - A Koha logo is displayed in from of each title available locally. Clicking the logo open the title in Koha OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- Exactly the same patch without using JS template literals ``. Nothing else to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147762|0 |1 is obsolete| | --- Comment #13 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 150675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150675&action=edit Bug 32333: IdRef system preference revamping IdRef system preference enables a Unimarc-only functionality. Authors fields contain in $3 subfield a PPN, an unique identifier in IdRef a French national authority file, similar to VIAF. KohaLa, the Koha French users association, has designed a revamped implementation of IdRef in Koha. The goal is to improve the visual and to add a functionality. - Visually — The author publications list is currently displayed in an old fashion dialog box. It uses greybox library, which is deprecated. See bug 8290. With this patch, the list is displayed in a distinct tab of holdings block. - Functionality — The title in the list are searched in Koha local catalog. So it's possible to mark titles locally available and link to them. PPN are searched directly in Elasticsearch for efficiency. Koha IdRef users are academic libraries or higher education school. So Zebra support is not required for them. NOTE: After pushing this patch, greybox library could be removed completely for OPAC : /koha-tmpl/opac-tmpl/bootstrap/lib/greybox/ TO TEST : - On a Unimarc Koha, with a Sudoc compliant Catalog, enable IdRef. - Use default OPAC XSL. - On opac-detail.pl page, you can see a logo IdRef next to authors having a $3 (ppn) subfield. Click on the logo. - Confirm that a tab is added to holdings. It contains the author publications found in the Sudoc. - A Sudoc logo is displayed in front of each title. Clicking the icon open the title in Sudoc web site. - A Koha logo is displayed in from of each title available locally. Clicking the logo open the title in Koha OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- I can't finish testing this right now because I don't have Elasticsearch working, but I have a question: Why not display the IdRef tab right away? Why wait for the user to click the link by the author? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 --- Comment #15 from Frédéric Demians <frederic@tamil.fr> ---
Why not display the IdRef tab right away? Why wait for the user to click the link by the author?
From my perspective, two main reasons : (1) Need — A user viewing a biblio record, generally don't need/want to see all other publications from document's author. And how to deal with multiples authors... (2) Fair use — This plugin queries IdRef webservice. It's "polite" not to abuse this service usage.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34710 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34710 [Bug 34710] Remove GreyBox from OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |laurence.rault@biblibre.com --- Comment #16 from Laurence Rault <laurence.rault@biblibre.com> --- Tested on koha-testing-docker, works almost as expected 1) Should be added in the test plan : require to define a ppn index for the ppn of the record (to be able to do the back search of other existing records in Koha) (in BibLibre standard configuration it is for 009 field) Maybe the index should be added by the patch, to add it if not already present in ES configuration ? 2) In the Idref results list, the link to Idref or to Koha contain target, so for Idref produce Not found : https://www.sudoc.fr/260997757%20target http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=21650%20targe... 3) Maybe an alert : Idref results sometimes take a long time to display (depending on the searched author, on the moment when the search is done, ...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 --- Comment #17 from Frédéric Demians <frederic@tamil.fr> --- Also available as part of a plugin: https://github.com/fredericd/Koha-Plugin-KohaLa-AbesWS#publications-idref-%C... It may be preferable to exfiltrate idref code from Koha core. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #18 from David Cook <dcook@prosentient.com.au> --- (In reply to Frédéric Demians from comment #17)
Also available as part of a plugin:
https://github.com/fredericd/Koha-Plugin-KohaLa-AbesWS#publications-idref- %C3%A0-lopac
It may be preferable to exfiltrate idref code from Koha core.
Cool! Just noting that this current code is in a very old style for Koha, and at a glance I think it might have at least one XSS vulnerability. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150675|0 |1 is obsolete| | --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184190&action=edit Bug 32333: IdRef system preference revamping IdRef system preference enables a Unimarc-only functionality. Authors fields contain in $3 subfield a PPN, an unique identifier in IdRef a French national authority file, similar to VIAF. KohaLa, the Koha French users association, has designed a revamped implementation of IdRef in Koha. The goal is to improve the visual and to add a functionality. - Visually — The author publications list is currently displayed in an old fashion dialog box. It uses greybox library, which is deprecated. See bug 8290. With this patch, the list is displayed in a distinct tab of holdings block. - Functionality — The title in the list are searched in Koha local catalog. So it's possible to mark titles locally available and link to them. PPN are searched directly in Elasticsearch for efficiency. Koha IdRef users are academic libraries or higher education school. So Zebra support is not required for them. NOTE: After pushing this patch, greybox library could be removed completely for OPAC : /koha-tmpl/opac-tmpl/bootstrap/lib/greybox/ TO TEST : - On a Unimarc Koha, with a Sudoc compliant Catalog, enable IdRef. - Use default OPAC XSL. - On opac-detail.pl page, you can see a logo IdRef next to authors having a $3 (ppn) subfield. Click on the logo. - Confirm that a tab is added to holdings. It contains the author publications found in the Sudoc. - A Sudoc logo is displayed in front of each title. Clicking the icon open the title in Sudoc web site. - A Koha logo is displayed in from of each title available locally. Clicking the logo open the title in Koha OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184191&action=edit Bug 32333: (follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Rebased and tidied in the hopes that someone will pick this up again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41665 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 --- Comment #22 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #21)
Rebased and tidied in the hopes that someone will pick this up again.
It would be great if someone picked it up, or at the very least handled the visual component. I've raised bug 41665 to stop including Greybox in the OPAC for any case except where the IdRef syspref is enabled, so that most people no longer have to load these assets. I'm curious how many people are using IdRef. Unfortunately, Hea has no numbers on it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org