[Bug 41796] New: "Forgot your password" link is not visible if OpacResetPassword is enabled but OpacPasswordChange is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 Bug ID: 41796 Summary: "Forgot your password" link is not visible if OpacResetPassword is enabled but OpacPasswordChange is disabled Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org "Forgot your password" is not visible if OpacResetPassword is enabled but OpacPasswordChange is disabled "OpacResetPassword" / "Forgot your password" is the functionality that patrons can use to reset a forgotten password using a recovery link that is sent to their email. This is a feature controlled by system preference "OpacResetPassword". "OpacPasswordChange" is the functionality that logged in patrons can use to change their password, provided that they remember their current password. OpacPasswordChange should not be linked to OpacResetPassword. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lari.taskula@hypernova.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 192727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192727&action=edit Bug 41796: "Forgot your password" link is not visible if OpacResetPassword is enabled but OpacPasswordChange is disabled Before applying this patch, to reproduce the issue: 1. Set system preference OpacResetPassword to 'not allowed' 2. Set system preference OpacPasswordChange to 'Don't allow' 3. Set preference opacuserlogin to 'Allow' 4. Navigate to OPAC 5. Observe no "Forgot your password?" link on the OPAC main page 6. Set system preference OpacResetPassword to 'allowed' 7. Observe no "Forgot your password?" link on the OPAC main page 8. Set system preference OpacPasswordChange 'Allow' 9. Observe "Forgot your password?" link is present on the OPAC main page. Instead, it should be already present when OpacResetPassword is allowed. To test this patch: 1. Apply this patch 2. Set system preference OpacResetPassword to 'not allowed' 3. Set system preference OpacPasswordChange to 'Don't allow' 4. Set preference opacuserlogin to 'Allow' 5. Navigate to OPAC 6. Observe no "Forgot your password?" link on the OPAC main page 7. Set system preference OpacResetPassword to 'allowed' 8. Observe "Forgot your password?" link is present -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 Bosse <bosse@gustavsson.one> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192727|0 |1 is obsolete| | --- Comment #2 from Bosse <bosse@gustavsson.one> --- Created attachment 193166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193166&action=edit Bug 41796: "Forgot your password" link is not visible if OpacResetPassword is enabled but OpacPasswordChange is disabled Before applying this patch, to reproduce the issue: 1. Set system preference OpacResetPassword to 'not allowed' 2. Set system preference OpacPasswordChange to 'Don't allow' 3. Set preference opacuserlogin to 'Allow' 4. Navigate to OPAC 5. Observe no "Forgot your password?" link on the OPAC main page 6. Set system preference OpacResetPassword to 'allowed' 7. Observe no "Forgot your password?" link on the OPAC main page 8. Set system preference OpacPasswordChange 'Allow' 9. Observe "Forgot your password?" link is present on the OPAC main page. Instead, it should be already present when OpacResetPassword is allowed. To test this patch: 1. Apply this patch 2. Set system preference OpacResetPassword to 'not allowed' 3. Set system preference OpacPasswordChange to 'Don't allow' 4. Set preference opacuserlogin to 'Allow' 5. Navigate to OPAC 6. Observe no "Forgot your password?" link on the OPAC main page 7. Set system preference OpacResetPassword to 'allowed' 8. Observe "Forgot your password?" link is present Signed-off-by: Bo Gustavsson <bosse@gustavsson.one> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193166|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 198862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198862&action=edit Bug 41796: "Forgot your password" link is not visible if OpacResetPassword is enabled but OpacPasswordChange is disabled Before applying this patch, to reproduce the issue: 1. Set system preference OpacResetPassword to 'not allowed' 2. Set system preference OpacPasswordChange to 'Don't allow' 3. Set preference opacuserlogin to 'Allow' 4. Navigate to OPAC 5. Observe no "Forgot your password?" link on the OPAC main page 6. Set system preference OpacResetPassword to 'allowed' 7. Observe no "Forgot your password?" link on the OPAC main page 8. Set system preference OpacPasswordChange 'Allow' 9. Observe "Forgot your password?" link is present on the OPAC main page. Instead, it should be already present when OpacResetPassword is allowed. To test this patch: 1. Apply this patch 2. Set system preference OpacResetPassword to 'not allowed' 3. Set system preference OpacPasswordChange to 'Don't allow' 4. Set preference opacuserlogin to 'Allow' 5. Navigate to OPAC 6. Observe no "Forgot your password?" link on the OPAC main page 7. Set system preference OpacResetPassword to 'allowed' 8. Observe "Forgot your password?" link is present Signed-off-by: Bo Gustavsson <bosse@gustavsson.one> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198862|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201448&action=edit Bug 41796: "Forgot your password" link is not visible if OpacResetPassword is enabled but OpacPasswordChange is disabled Before applying this patch, to reproduce the issue: 1. Set system preference OpacResetPassword to 'not allowed' 2. Set system preference OpacPasswordChange to 'Don't allow' 3. Set preference opacuserlogin to 'Allow' 4. Navigate to OPAC 5. Observe no "Forgot your password?" link on the OPAC main page 6. Set system preference OpacResetPassword to 'allowed' 7. Observe no "Forgot your password?" link on the OPAC main page 8. Set system preference OpacPasswordChange 'Allow' 9. Observe "Forgot your password?" link is present on the OPAC main page. Instead, it should be already present when OpacResetPassword is allowed. To test this patch: 1. Apply this patch 2. Set system preference OpacResetPassword to 'not allowed' 3. Set system preference OpacPasswordChange to 'Don't allow' 4. Set preference opacuserlogin to 'Allow' 5. Navigate to OPAC 6. Observe no "Forgot your password?" link on the OPAC main page 7. Set system preference OpacResetPassword to 'allowed' 8. Observe "Forgot your password?" link is present Signed-off-by: Bo Gustavsson <bosse@gustavsson.one> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41796 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org