http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7852 Elliott Davis <tdavis@uttyler.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7852 Elliott Davis <tdavis@uttyler.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tdavis@uttyler.edu |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7852 Elliott Davis <tdavis@uttyler.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8702|0 |1 is obsolete| | --- Comment #2 from Elliott Davis <tdavis@uttyler.edu> --- Created attachment 8779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8779&action=edit Fix fines for large durations - from Colin -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7852 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8780|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8782&action=edit [Signed-Off] Use hour or day deltas to calculate overdue durations If durations are calculated by subtraction they will use units larger than those we care about and these are not convertable to the smaller units we are attempting to enumerate Use the appropriate delta methods to calculate theee fines Adds a separate hours_between method to calendar This should strictly be checking opening hours (of which closed days are a special case) of the relevant branch These need adding to branches http://bugs.koha-community.org/show_bug.cgi?id=7852 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7852 --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Created attachment 8816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8816&action=edit [PASSED QA] Use hour or day deltas to calculate overdue durations If durations are calculated by subtraction they will use units larger than those we care about and these are not convertable to the smaller units we are attempting to enumerate Use the appropriate delta methods to calculate theee fines Adds a separate hours_between method to calendar This should strictly be checking opening hours (of which closed days are a special case) of the relevant branch These need adding to branches http://bugs.koha-community.org/show_bug.cgi?id=7852 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Ian Walls <koha.sekjal@gmail.com> QA comment: renamed "days_minus_grace" variable to "units_minus_grace" Also added POD to _get_chargeable_units -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7852 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.