[Bug 12511] New: Novelist Select not using https in bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Bug ID: 12511 Summary: Novelist Select not using https in bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In prog we have: [% IF ( NovelistSelectProfile ) %] <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> [% END %] but in bootstrap we have [% IF ( NovelistSelectProfile ) %] <script type="text/javascript" src="http://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> [% END %] Because bootstrap isn't using https, we get an error like this: [blocked] The page at 'https://koha.mylibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=105315&query_desc=kw%2Cwrdl%3A%20home' was loaded over HTTPS, but ran insecure content from 'http://imageserver.ebscohost.com/novelistselect/ns2init.js': this content should also be loaded over HTTPS. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29410&action=edit Bug 12511 - Novelist Select not using https in bootstrap In prog we have: [% IF ( NovelistSelectProfile ) %] <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> [% END %] but in bootstrap we have [% IF ( NovelistSelectProfile ) %] <script type="text/javascript" src="http://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> [% END %] Because bootstrap isn't using https, we get an error like this: [blocked] The page at 'https://koha.mylibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=105315&query_desc=kw%2Cwrdl%3A%20home' was loaded over HTTPS, but ran insecure content from 'http://imageserver.ebscohost.com/novelistselect/ns2init.js': this content should also be loaded over HTTPS. Test plan would require having a subscription to Novelist Select. I think this is trivial enough to go without. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Chris Rohde <crohde@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |crohde@roseville.ca.us --- Comment #2 from Chris Rohde <crohde@roseville.ca.us> --- We have NoveList Select, are running Bootstrap, on an https server. The patch works on our server. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29410|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29528&action=edit [PASSED QA] Bug 12511 - Novelist Select not using https in bootstrap In prog we have: [% IF ( NovelistSelectProfile ) %] <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> [% END %] but in bootstrap we have [% IF ( NovelistSelectProfile ) %] <script type="text/javascript" src="http://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> [% END %] Because bootstrap isn't using https, we get an error like this: [blocked] The page at 'https://koha.mylibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=105315&query_desc=kw%2Cwrdl%3A%20home' was loaded over HTTPS, but ran insecure content from 'http://imageserver.ebscohost.com/novelistselect/ns2init.js': this content should also be loaded over HTTPS. Test plan would require having a subscription to Novelist Select. I think this is trivial enough to go without. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Very small change, trusting Kyle and the sign-off here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org