[Bug 22734] New: Fund not marked as mandatory when ordering from a staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Bug ID: 22734 Summary: Fund not marked as mandatory when ordering from a staged file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Created attachment 88267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88267&action=edit 'Fund' should be in red When adding a new order from a staged file, "Fund" label should be in red as it's a mandatory field. As you can see on attachment, not selecting a fund is correctly blocked. Should the word 'Required' be added at the right of the 2 fields 'Quantity' and 'Fund' to have the same display as we have adding an order directly in a basket ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 88299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88299&action=edit Bug 22734: Fund not marked as mandatory when ordering from a staged file This patch does some refactoring of JavaScript to make handling of required fields more robust. It also moves some template JavaScript to the footer and some to a separate file. A fallback "pattern" attribute is added to the quantity field, requiring 0-9+ values. The "required" property of the funds dropdown is now dependent on the value set under the "Default accounting details" tab. If a default is selected, the individual item funds are preselected and not marked required. To test, apply the patch and begin the process of ordering from a staged file. - Select all items to import. - Under each item, the fund should be marked mandatory. - The quantity field should accept only numbers. - Select the "Default accounting details" tab and select a default fund. - Return to the "Select to import" tab. Your selected default fund should now be preselected under each item. The fund should no longer be marked required. Un-selecting a default fund should result in each item fund select becoming required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88299|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 88322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88322&action=edit Bug 22734: Fund not marked as mandatory when ordering from a staged file This patch does some refactoring of JavaScript to make handling of required fields more robust. It also moves some template JavaScript to the footer and some to a separate file. A fallback "pattern" attribute is added to the quantity field, requiring 0-9+ values. The "required" property of the funds dropdown is now dependent on the value set under the "Default accounting details" tab. If a default is selected, the individual item funds are preselected and not marked required. To test, apply the patch and begin the process of ordering from a staged file. - Select all items to import. - Under each item, the fund should be marked mandatory. - The quantity field should accept only numbers. - Select the "Default accounting details" tab and select a default fund. - Return to the "Select to import" tab. Your selected default fund should now be preselected under each item. The fund should no longer be marked required. Un-selecting a default fund should result in each item fund select becoming required. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Looked good to me ! Thank you Owen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88322|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88697&action=edit Bug 22734: Fund not marked as mandatory when ordering from a staged file This patch does some refactoring of JavaScript to make handling of required fields more robust. It also moves some template JavaScript to the footer and some to a separate file. A fallback "pattern" attribute is added to the quantity field, requiring 0-9+ values. The "required" property of the funds dropdown is now dependent on the value set under the "Default accounting details" tab. If a default is selected, the individual item funds are preselected and not marked required. To test, apply the patch and begin the process of ordering from a staged file. - Select all items to import. - Under each item, the fund should be marked mandatory. - The quantity field should accept only numbers. - Select the "Default accounting details" tab and select a default fund. - Return to the "Select to import" tab. Your selected default fund should now be preselected under each item. The fund should no longer be marked required. Un-selecting a default fund should result in each item fund select becoming required. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- When I came to this bug I wasn't expecting to find such a large patch.. refactoring seems to be solid though and I can't find any regressions, well done Owen. I'd love to see some selenium regression tests here but I'm not going to fail QA for that. Passed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Erk, I missed an issue here: If the funds are defined per item we shouldn't have to supply a fund for the order as a whole. This will need a followup to take that into account or cannot be in the release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88791&action=edit Fund defined for all item(s) shoudln't need for order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |enhancement Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Do we need a new bug opening for comment #8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Martin Renvoize from comment #11)
Do we need a new bug opening for comment #8
It sounds like we do, but I'm unable to reproduce the problem. I think I just don't understand what the right circumstances are to trigger it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 [Bug 22802] When ordering form a staged file, if funds are populated per item order level fund should not be required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Owen Leonard from comment #12)
(In reply to Martin Renvoize from comment #11)
Do we need a new bug opening for comment #8
It sounds like we do, but I'm unable to reproduce the problem. I think I just don't understand what the right circumstances are to trigger it.
bug 22802 opened -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25473 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 [Bug 25473] Can't add order from MARC file, save button does nothing -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org