[Bug 40490] New: Warnings from GD::Barcode::QRcode on U24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Bug ID: 40490 Summary: Warnings from GD::Barcode::QRcode on U24 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org 01:18:38 koha_1 | # Failed test 'no warnings' 01:18:38 koha_1 | # at /usr/share/perl/5.38/Test/Builder.pm line 193. 01:18:38 koha_1 | # There were 6 warning(s) 01:18:38 koha_1 | # Previous test 4 '401 Unauthorized' 01:18:38 koha_1 | # Use of uninitialized value $aMask[1079] in bitwise xor (^) at /usr/share/perl5/GD/Barcode/QRcode.pm line 217. 01:18:38 koha_1 | # at /usr/share/perl5/GD/Barcode/QRcode.pm line 217. t/db_dependent/api/v1/two_factor_auth.t jammy (22.04LTS) (perl): 1.15-7 noble (24.04LTS) (perl): 2.00-1 I guess it's fixed by https://github.com/mbeijen/GD-Barcode/commit/85e7911e65bf1c4746d9ce2e743580b... But it is not released yet: version 2 is from September 2023 and commit from March 2024. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |40348 Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40348 [Bug 40348] api/v1/two_factor_auth.t generates warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184575&action=edit Bug 40490: Remove warnings from GD::Barcode::QRcode - U24 01:18:38 koha_1 | # Failed test 'no warnings' 01:18:38 koha_1 | # at /usr/share/perl/5.38/Test/Builder.pm line 193. 01:18:38 koha_1 | # There were 6 warning(s) 01:18:38 koha_1 | # Previous test 4 '401 Unauthorized' 01:18:38 koha_1 | # Use of uninitialized value $aMask[1079] in bitwise xor (^) at /usr/share/perl5/GD/Barcode/QRcode.pm line 217. 01:18:38 koha_1 | # at /usr/share/perl5/GD/Barcode/QRcode.pm line 217. jammy (22.04LTS) (perl): 1.15-7 noble (24.04LTS) (perl): 2.00-1 I guess it's fixed by https://github.com/mbeijen/GD-Barcode/commit/85e7911e65bf1c4746d9ce2e743580b... But it is not released yet: version 2 is from September 2023 and commit from March 2024. Test plan: Install version 2 of GD::Barcode: `cpanm GD::Barcode@2.0.0` Run the tests Without this patch the "no warnings" test fails With this patch applied the tests pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- That's an interesting one. I'll ask on their Github if they'd be willing to upload a new version to CPAN. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #2)
That's an interesting one.
I'll ask on their Github if they'd be willing to upload a new version to CPAN.
https://github.com/mbeijen/GD-Barcode/issues/10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184575|0 |1 is obsolete| | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 184576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184576&action=edit Bug 40490: Remove warnings from GD::Barcode::QRcode - U24 01:18:38 koha_1 | # Failed test 'no warnings' 01:18:38 koha_1 | # at /usr/share/perl/5.38/Test/Builder.pm line 193. 01:18:38 koha_1 | # There were 6 warning(s) 01:18:38 koha_1 | # Previous test 4 '401 Unauthorized' 01:18:38 koha_1 | # Use of uninitialized value $aMask[1079] in bitwise xor (^) at /usr/share/perl5/GD/Barcode/QRcode.pm line 217. 01:18:38 koha_1 | # at /usr/share/perl5/GD/Barcode/QRcode.pm line 217. jammy (22.04LTS) (perl): 1.15-7 noble (24.04LTS) (perl): 2.00-1 I guess it's fixed by https://github.com/mbeijen/GD-Barcode/commit/85e7911e65bf1c4746d9ce2e743580b... But it is not released yet: version 2 is from September 2023 and commit from March 2024. Test plan: Install version 2 of GD::Barcode: `cpanm GD::Barcode@2.0.0` Run the tests Without this patch the "no warnings" test fails With this patch applied the tests pass Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- I don't have a U24 system on hand, but the tests pass with the patch on D12, so there's no harm in them. -- Looking at the code, I wonder if we could have used one of Test::Output's stderr_* methods here to check if STDERR was empty or had the error we expect in U24? But this should work fine. I wonder how we'll know to undo this change when there's a newer version of GD::Barcode available? Would it be worth wrapping this in a GD::Barcode::VERSION check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #5)
Looking at the code, I wonder if we could have used one of Test::Output's stderr_* methods here to check if STDERR was empty or had the error we expect in U24? But this should work fine.
I had a look at it last week (because there is already an occurrence of a similar problem, see bug 18772), but it's yet another dependency and so I decided to keep the STDERR redirect. But I wouldn't mind adjusting them if we have more occurrences coming.
I wonder how we'll know to undo this change when there's a newer version of GD::Barcode available? Would it be worth wrapping this in a GD::Barcode::VERSION check?
Yes, I thought about that (again for bug 18772) but didn't find an elegant solution. What do you mean by "wrapping in a version check"? Only the expected output or to let us know the STDERR redirect can be removed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #6)
I wonder how we'll know to undo this change when there's a newer version of GD::Barcode available? Would it be worth wrapping this in a GD::Barcode::VERSION check?
Yes, I thought about that (again for bug 18772) but didn't find an elegant solution. What do you mean by "wrapping in a version check"? Only the expected output or to let us know the STDERR redirect can be removed?
Yeah, letting us know when the STDERR redirect can be removed. I was thinking maybe we could do the STDERR redirect just for $GD::Barcode::VERSION == 2.00 or something like that, so that systems using older or newer versions of GD::Barcode would still get checked by Test::NoWarnings. Otherwise, I'm not sure when we'll know to come back to undo it. But it's just a thought. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #3)
(In reply to David Cook from comment #2)
That's an interesting one.
I'll ask on their Github if they'd be willing to upload a new version to CPAN.
Michiel was super responsive, and he's uploaded a version 2.01 to CPAN with the fix. Probably not worth packaging it ourselves just to solve this problem, but I'll ask the Debian maintainer if they can try out the new version, so that it flows through at some point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #8)
(In reply to David Cook from comment #3)
(In reply to David Cook from comment #2)
That's an interesting one.
I'll ask on their Github if they'd be willing to upload a new version to CPAN.
Michiel was super responsive, and he's uploaded a version 2.01 to CPAN with the fix.
Probably not worth packaging it ourselves just to solve this problem, but I'll ask the Debian maintainer if they can try out the new version, so that it flows through at some point.
I've emailed a Debian bug report asking for a version bump and potentially a backport. We'll see how that goes. It's not showing up on bugs.debian.org yet, but hopefully it will. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Looks like bug 18772 is another case where the bug is already fixed upstream but hasn't flowed through to CPAN and Debian. Weird. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Having issues with get_session called in two_factor_auth.t. Seems unrelated to this patch. Getting no session while passing empty string? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #11)
Having issues with get_session called in two_factor_auth.t. Seems unrelated to this patch. Getting no session while passing empty string?
Resolved. Interference with development on koha scripts, changing paths ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184576|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184613&action=edit Bug 40490: Remove warnings from GD::Barcode::QRcode - U24 01:18:38 koha_1 | # Failed test 'no warnings' 01:18:38 koha_1 | # at /usr/share/perl/5.38/Test/Builder.pm line 193. 01:18:38 koha_1 | # There were 6 warning(s) 01:18:38 koha_1 | # Previous test 4 '401 Unauthorized' 01:18:38 koha_1 | # Use of uninitialized value $aMask[1079] in bitwise xor (^) at /usr/share/perl5/GD/Barcode/QRcode.pm line 217. 01:18:38 koha_1 | # at /usr/share/perl5/GD/Barcode/QRcode.pm line 217. jammy (22.04LTS) (perl): 1.15-7 noble (24.04LTS) (perl): 2.00-1 I guess it's fixed by https://github.com/mbeijen/GD-Barcode/commit/85e7911e65bf1c4746d9ce2e743580b... But it is not released yet: version 2 is from September 2023 and commit from March 2024. Test plan: Install version 2 of GD::Barcode: `cpanm GD::Barcode@2.0.0` Run the tests Without this patch the "no warnings" test fails With this patch applied the tests pass Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Thanks for all the upstream work, David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #14)
Thanks for all the upstream work, David!
No worries! Thanks for doing all that groundwork too! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- The upstream bug has been closed https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1109844 as they say a 2.0.1 package is due to be uploaded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 --- Comment #18 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40663 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #20 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #21 from David Nind <david@davidnind.com> --- Test suite related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40490 Bug 40490 depends on bug 40348, which changed state. Bug 40348 Summary: api/v1/two_factor_auth.t generates warnings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40348 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org