[Bug 19793] New: Add a field for email in batch patron modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Bug ID: 19793 Summary: Add a field for email in batch patron modification Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: patrick.robitaille@collecto.ca QA Contact: testopia@bugs.koha-community.org Hi, It could be nice in batch patron modification tool's to add a new field for the email adrress. Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Patrick, can you explain the use case? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #2 from Patrick Robitaille <patrick.robitaille@collecto.ca> --- Hi, This would be to avoid having to export data and import them again to change the user's email address. Because it possible to change the email adrress when you import a patron' field in default values. Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Patrick, sorry, I was not clear. I was wondering, because with batch patron modification you can only set to 1 value (same email for all) or empty a field out. Wondering what the use case is where you want to do that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #4 from Sally Healey <sally.healey@cheshiresharedservices.gov.uk> --- Hi Katrin, We have this as a local customisation on our install and it's saved hours. We use it when we receive bouncebacks; we simultaneously empty the e-mail address field and add both circulation and OPAC messages to advise the patron/branch staff of the failure. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- Adding the ability to batch modify a bunch of borrowers email fields to null might be useful, can see how that might be nice for librarians. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #6 from Liz Rea <liz@catalyst.net.nz> --- But I don't see much utility in allowing librarians to batch set a whole bunch of borrowers emails to the same thing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Setting to the same might be interesting for testing, even if a rare case. I agree emptying out would make sense in some cases. Thx for being patient with me :) It's often interesting to learn why people want/need a thing and sometimes it helps to come up with an even better solution. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #8 from Patrick Robitaille <patrick.robitaille@collecto.ca> --- Hi, This is for a particular demand form a library how have not acces to personal email adress of users. This new field will be used to add the same email address to be able to receive overdue notifications and then send them via another email platform that uses the host institution of the library which is actually the educational institution. Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20847 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |david.roberts@ptfs-europe.c |y.org |om CC| |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|david.roberts@ptfs-europe.c |testopia@bugs.koha-communit |om |y.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #9 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 97335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97335&action=edit Bug 19793 - Add a field for email in batch patron modification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #10 from David Roberts <david.roberts@ptfs-europe.com> --- To test: 1) Install patch 2) Open Batch Patron Modification tool, and input a borrowernumber to edit 3) Add some data (e.g. test@foobar.com) into the Email address field, and click Save 4) The Primary Email address in the user record should now contain your email address 5) Test that running the tool again with the option to delete the data clears the field correctly 6) Repeat steps 1-5 with a file of user borrowernumbers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97335|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97347&action=edit Bug 19793 - Add a field for email in batch patron modification Signed-off-by: Sal <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sponsored by PTFS-Europe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Patrick, there are some small things that I've fixed in the patch for you: 1) Please make sure your editor uses 4 spaces instead of tabs, tabs are forbidden :) FAIL tools/modborrowers.pl OK critic FAIL forbidden patterns forbidden pattern: tab char (line 267) forbidden pattern: tab char (line 268) forbidden pattern: tab char (line 269) forbidden pattern: tab char (line 270) forbidden pattern: tab char (line 271) forbidden pattern: tab char (line 272) 2) Make sure you include the test plan in your commit message. 3) Make sure you start the first line of your commit message with Bug XXXX: (not - as in bugzilla). I'll continue testing and upload the patch later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97647&action=edit Bug 19793: Add a field for email in batch patron modification This adds the email field to the patron batch modification tool. To test: 1) Install patch 2) Open Batch Patron Modification tool, and input a borrowernumber to edit 3) Add some data (e.g. test@foobar.com) into the Email address field, and click Save 4) The Primary Email address in the user record should now contain your email address 5) Test that running the tool again with the option to delete the data clears the field correctly 6) Repeat steps 1-5 with a file of user borrowernumbers Signed-off-by: Sal <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97648&action=edit Bug 19793: Change label to match patron record: Primary email As we have multiple email fields in the patron record, we should be clear which one can be changed from the batch mod now. Easiest is to use the same label. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97347|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #16 from David Roberts <david.roberts@ptfs-europe.com> --- Thanks Katrin, I didn't know that. I'll try to do that in future! Thanks for QA'ing the patch and for your changes. David (apparently AKA Patrick! :-D ) (In reply to Katrin Fischer from comment #13)
Hi Patrick, there are some small things that I've fixed in the patch for you:
1) Please make sure your editor uses 4 spaces instead of tabs, tabs are forbidden :)
FAIL tools/modborrowers.pl OK critic FAIL forbidden patterns forbidden pattern: tab char (line 267) forbidden pattern: tab char (line 268) forbidden pattern: tab char (line 269) forbidden pattern: tab char (line 270) forbidden pattern: tab char (line 271) forbidden pattern: tab char (line 272)
2) Make sure you include the test plan in your commit message.
3) Make sure you start the first line of your commit message with Bug XXXX: (not - as in bugzilla).
I'll continue testing and upload the patch later.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Roberts from comment #16)
Thanks Katrin, I didn't know that. I'll try to do that in future! Thanks for QA'ing the patch and for your changes.
David (apparently AKA Patrick! :-D )
Sorry for that, apparently I was looking at the wrong comments :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |joy@bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #19 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With this enhancement the release notes| |primary email of patrons | |can be changed using the | |batch patron modification | |tool. Summary|Add a field for email in |Add email to batch patron |batch patron modification |modification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27413 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27413 [Bug 27413] Cannot add debarment with batch patron modification tool -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org