http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #2)

If some libraries are currently using non-unimarc fields (414-420 ; 603, 630-636) for some reason, I could edit the patch to keep these fields in record.abs, and just add a comment before each field to let people know it is not plain UNIMARC...

I would prefer this option, especially so close to a release. I look forward to seeing your revised patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 13269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13269&action=edit [PATCH] Bug 8984: index new fields in UNIMARC record.abs (revision 1) I reverted the suppression of non-unimarc fields. In this new patch they are just commented. (and I add 560 field that I did not see last week) M. Saby Rennes 2 University -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 13270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13270&action=edit [PATCH] Bug 8984: index new fields in UNIMARC DOM-indexing configuration files With the new record.abs, I created a new biblio-koha-indexdefs.xml with make_zebra_dom_cfg_from_record_abs, then a new biblio-zebra-indexdefs.xsl with xsltproc, and I made a patch. It must be applied with patch 13269 and tested in with Koha using DOM-indexing. M. Saby Rennes 2 University -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it Patch complexity|--- |Medium patch --- Comment #7 from Zeno Tajoli <z.tajoli@cineca.it> --- I see the path. For Italian users of Unimarc, it is OK. The patch doesn't change anything used by italian unimarc users. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Zeno Tajoli <z.tajoli@cineca.it> --- Hi Mathieu, the patch has problem on master.

From sandboxes:

Something went wrong ! Applying: Bug 8984: make Zebra more UNIMARC compliant Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml CONFLICT (content): Merge conflict in etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml Auto-merging etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl Failed to merge in the changes. Patch failed at 0001 Bug 8984: make Zebra more UNIMARC compliant When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. Bug 8984 - Zebra does not index some fields in UNIMARC biblio records I think you need to rebase it -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13303|0 |1 is obsolete| | --- Comment #11 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 13899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13899&action=edit [PATCH] Bug 8984: make Zebra more UNIMARC compliant Patch rebased This patch makes the following changes to record.abs, biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl : - adding new (sub)fields to Identifier-standard index : 011f/g ; 012a ; 013a/z ; 014a/z ; 015a/z ; 016a/z ; 017a/z, 040a/z, 071z, 072z, 073z - adding 1 new subfield to Publisher index : 071b (may contain the name of a music publisher) - adding new (sub)fields to Author and Identifier-standard index (for the $9) : 716, 72X, 730 - adding new (sub)fields to Note : 334$a (award note) - correcting 207 and 208 - suppressing 308a and 328a in Note (useless as complete fields are indexed in same index) - adding (sub)fields to Title index : 411t, 421-425t, 433-437t, 442-444t, 446-456t, 462-463t, 470-488t, 560 - adding (sub)fields to Subject and Identifier-standard index (for the $9) : 608, 615, 616, 617, 620, 621 - adding some classifications index : 670, 675, 686 - adding some comments (to make easier further modifications and to identify non unimarc fields : 414-420, 603, 630-636, 646) To test : - take a record and fill some of the missing fields (e.g 488t, 608, 720, 012a) with some data as "field488", "field608" etc - try to find the record => not possible - apply the patch, copy the new record.abs in etc/zebradb/biblios/etc and rebuild zebra - try to find the record => should be ok - check nothing else is broken... - same test with DOM indexing activated -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 --- Comment #12 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In fact I am probably wrong saying you need to copy the file in etc/zebradb/biblios/etc In my install, the file was in this directory in addition to etc/zebradb/marc_defs/unimarc/biblios) M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13965|0 |1 is obsolete| | --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14395&action=edit Bug 8984: make Zebra more UNIMARC compliant This patch makes the following changes to record.abs, biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl : - adding new (sub)fields to Identifier-standard index : 011f/g ; 012a ; 013a/z ; 014a/z ; 015a/z ; 016a/z ; 017a/z, 040a/z, 071z, 072z, 073z - adding 1 new subfield to Publisher index : 071b (may contain the name of a music publisher) - adding new (sub)fields to Author and Identifier-standard index (for the $9) : 716, 72X, 730 - adding new (sub)fields to Note : 334$a (award note) - correcting 207 and 208 - suppressing 308a and 328a in Note (useless as complete fields are indexed in same index) - adding (sub)fields to Title index : 411t, 421-425t, 433-437t, 442-444t, 446-456t, 462-463t, 470-488t, 560 - adding (sub)fields to Subject and Identifier-standard index (for the $9) : 608, 615, 616, 617, 620, 621 - adding some classifications index : 670, 675, 686 - adding some comments (to make easier further modifications and to identify non unimarc fields : 414-420, 603, 630-636, 646) To test : - take a record and fill some of the missing fields (e.g 488t, 608, 720, 012a) with some data as "field488", "field608" etc - try to find the record => not possible - apply the patch, copy the new record.abs in etc/zebradb/biblios/etc and rebuild zebra - try to find the record => should be ok - check nothing else is broken... - same test with DOM indexing activated http://bugs.koha-community.org/show_bug.cgi?id=8984 Signed-off-by: Zeno Tajoli <tajoli@cilea.it> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8984 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.