https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Summary|inconsistencies with the |"Limit to records with |search results when |available items" should |selecting the "Limit to |consider withdrawn and |records with available |negative not for loan |items" option |status as unavailable --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Hammat, I have updated the bug description to reflect this. Hope I understood correctly! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 --- Comment #7 from Catrina Berka <catrina@bywatersolutions.com> --- Hi Hammat, I was able to sign off on some other bugs and was able to apply those patches successfully yesterday. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170611&action=edit Test records for the cases described I created the records for the cases, you can import these in KTD, you will need to checkout to a patron the barcodes ONLOAN1 and ONLOAN2 Search for "Bug 37680" to see the records -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 --- Comment #11 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Hammat wele from comment #10)

(In reply to Nick Clemens (kidclamp) from comment #9)

...

I think this works as intended, but not as described in the test plan - after 'limiting to available' I still see the two "ordered" items as their notforloan is negative and the code looks for positive not for loan

If the two items of a notice are "ordered", Shouldn't the notice be unavailable? after 'limiting to available' we shouldn't see them, isn't it the way it should be? in our installations we consider a notice with two ordered item as unavailable

They are available for holds, I am not sure if they should be filtered out, I would be okay either way. If you do want to fitler them the code will need an adjustment -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think that brings us back to a discussion often had about how we define "available" Option A: Availalable means it's available for checkout. As the library circulation rules factor into this one, we cannot fully tell from what is available to Zebra if something can be checked out or not. But it would mean that it would make sense to exclude "not for loan" in general. Option B: Available means it's available for use. That would mean, the not for loan items and item types are still counted as available. I that case I would only exclude not for loan -1 by default, as they are not supposed to be in the library yet. For our academic/special libraries I think Option B would be preferable. Overall it maybe shows that finding a good default is hard and that it should be made configurable at some point? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 Mirjam Vantieghem <mirjam.vantieghem@etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27973 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 Mirjam Vantieghem <mirjam.vantieghem@etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31304 CC| |mirjam.vantieghem@etf.edu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170481|0 |1 is obsolete| | --- Comment #15 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 179867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179867&action=edit Bug 37680: inconsistencies with the search results when selecting the "Limit to records with available items" option There seem to be inconsistencies with the search results when selecting the "Limit to records with available items" option, when we have a notice with two items if the first item is «notforloan» and the second is «notforloan» too or «withdrawn» the notice is still available. And these conditions also are showing : Case : 1- Record with first item as «notforloan» - The second is «notforloan» 2- Record with first item as «notforloan» - The second is «withdrawn» 3- Record with first item as «itemlost» - The second is «notforloan» 4- Record with first item as «itemlost» - The second is «withdrawn» 5- Record with first item «onloan» - The second is «notforloan» 6- Record with first item «onloan» - The second is «withdrawn» To reproduce: 1. Catalog a new record (record test 1) 1.1. Go to Cataloging 1.2. Click New record 1.3. Fill out the mandatory fields (000, 003, 005, 008, 040$c, 245$a, 942$c) 1.4. Click Save (No need to add an item) 1.5. Add two items, set a negative notforloan (ordered) for the two items 2. Repeat step 1, by creating a record (record test 2) with two items one negative notforloan item and the second as «withdrawn» item 3. Repeat step 1, and creating all the record in «Case» section 4. Go to the Opac and search for the created record 5. Click on «Limit to records with available items» ----> All the created items is still showing 6. Apply the patch 7. Rebuild bibliographic index ./misc/search_tools/rebuild_elasticsearch.pl -d -v -r -b 8. Repeat step 4 and 5 ----> the created items is no more showing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Blou from comment #14)

Hi Katrin, Would you be OK to have that system preference "verbatim" as you stated? Basically two meaning for available, and we filter accordingly.

This would only be for the filter. The other usage of "available" in the displays would not be affected by this patch. I'm stating it right now.

I am sorry Blou, I had this one saved to reply to later... and promptly lost sight of it. A system preference should work. I think what I suggested would cover at least 2 use cases, but it would not allow to keep current behavior if that was important to some. But I think it could be a good starting point. As the use cases for not for loan values are quite different an ideal solution might be to let the library check the ones they want to be counted as "not available". But I am not sure how feasible that idea is. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 karie.straube@yavapaiaz.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karie.straube@yavapaiaz.gov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 --- Comment #18 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 185667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185667&action=edit Test records for the cases described -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 --- Comment #19 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 185668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185668&action=edit Bug 37680: inconsistencies with the search results when selecting the "Limit to records with available items" option There were inconsistencies in search results when selecting "Limit to records with available items". Records with items marked as «notforloan» or «withdrawn» were still being shown as available. This patch add two systems preferences UnavailableNotForLoan and UnavailableWithDrawn, these allow users to choose which notforloan or withdrawn values should be considered as unavailable items. Case : 1- Record with first item as «notforloan» (Ordered) - The second is «notforloan» (Ordered) 2- Record with first item as «notforloan» (Ordered) - The second is «withdrawn» 3- Record with first item as «itemlost» - The second is «notforloan» (Not for loan) 4- Record with first item as «itemlost» - The second is «withdrawn» 5- Record with first item «onloan» - The second is «notforloan» 6- Record with first item «onloan» - The second is «withdrawn» To reproduce: 1. Import "Test records for the cases described" records 2. Checkout the first item of «Bug 37680 Case 5 » and «Bug 37680 Case 6» 3. Make sure OpacHiddenItems is empty 4. In the OPAC, search for «Bug 37680» 5. Click on «Limit to records with available items» ----> Records for Case 2, 3 ,4, 5, 6 is still showing 6. Apply the patch 7. Run ./installer/data/mysql/updatedatabase.pl 8. Go to Administration -> search for UnavailableNotForLoan then select Not for loan that should be consider as not available (e.g. «Ordered» and «Not For Loan») 9. Go to Administration -> search for UnavailableWithDrawn then select Withdrawn that should be consider as not available (e.g. «Withdrawn») 10. Rebuild bibliographic index ./misc/search_tools/rebuild_elasticsearch.pl -d -v -r -b 11. Repeat step 4 and 5 ----> Records for Case 2, 3, 4, 5, and 6 no longer appear. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 Olivia Hattan-Edwards <ohattan@ju.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ohattan@ju.edu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #20 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this and I think it works after the full rebuilding of index but if I change the notforloan status to one of the statuses selected in UnavailableNotForLoan after the full reindex for single item of the record (there is only one item) and they get reindexed by background jobs the availability status does not change. They are still marked "available": true," in the Elasticsearch record which you can check from the Normal view. Could someone else test this too to ensure that it's not just me? :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I'll mark this bug as Failed QA because no one else have tested this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37680 --- Comment #22 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 200986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200986&action=edit Bug 37680: inconsistencies with the search results when selecting the "Limit to records with available items" option There were inconsistencies in search results when selecting "Limit to records with available items". Records with items marked as «notforloan» or «withdrawn» were still being shown as available. This patch add two systems preferences UnavailableNotForLoan and UnavailableWithDrawn, these allow users to choose which notforloan or withdrawn values should be considered as unavailable items. Case : 1- Record with first item as «notforloan» (Ordered) - The second is «notforloan» (Ordered) 2- Record with first item as «notforloan» (Ordered) - The second is «withdrawn» 3- Record with first item as «itemlost» - The second is «notforloan» (Not for loan) 4- Record with first item as «itemlost» - The second is «withdrawn» 5- Record with first item «onloan» - The second is «notforloan» 6- Record with first item «onloan» - The second is «withdrawn» To reproduce: 1. Import "Test records for the cases described" records 2. Checkout the first item of «Bug 37680 Case 5 » and «Bug 37680 Case 6» 3. Make sure OpacHiddenItems is empty 4. In the OPAC, search for «Bug 37680» 5. Click on «Limit to records with available items» ----> Records for Case 2, 3 ,4, 5, 6 is still showing 6. Apply the patch 7. Run ./installer/data/mysql/updatedatabase.pl 8. Go to Administration -> search for UnavailableNotForLoan then select Not for loan that should be consider as not available (e.g. «Ordered» and «Not For Loan») 9. Go to Administration -> search for UnavailableWithDrawn then select Withdrawn that should be consider as not available (e.g. «Withdrawn») 10. Rebuild bibliographic index ./misc/search_tools/rebuild_elasticsearch.pl -d -v -r -b 11. Repeat step 4 and 5 ----> Records for Case 2, 3, 4, 5, and 6 no longer appear. -- You are receiving this mail because: You are watching all bug changes.