[Bug 5791] New: Robust handling of deleted biblios/authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Bug #: 5791 Summary: Robust handling of deleted biblios/authorities Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: tomascohen@gmail.com QAContact: koha-bugs@lists.koha-community.org When a biblio/authority is deleted, and for some reason one tries to access it via a (saved) URL (as when you reach the link via log viewer) koha presents the user a very ugly system error: Software error: Can't call method "field" on an undefined value at /home/tomas/Work/koha/devel/koha-community-3.2.x/authorities/detail.pl line 82. This is correctly handled for patrons, presenting a convenient "This patron does not exist." A similar approach should be implemented for biblios AND authorities. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-02-22 19:50:07 UTC --- I was pointed in the IRC that 404 error vs. error message is an open issue, as of bug #2318. I attach my proposed patch, and wait for a discussion on this topic in koha devel. I've already sent an email on this. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-02-22 19:50:45 UTC --- Created attachment 3194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3194 Initial patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |tomascohen@gmail.com --- Comment #3 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-04 10:26:55 UTC --- This bug is mentioned in: [Bug 5791] Robust handling of deleted biblios/authorities http://lists.koha-community.org/pipermail/koha-patches/2011-February/013913.... --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-03-04 14:55:55 UTC --- I suggest the term "biblio" be replaced with "record" in catalogue/detail.tmpl, and "authority" be "authority record" in authorities/detail.tmpl. Other pages also need work in order for this bug to be completely fixed: catalogue/ISBDdetail.tmpl, catalogue/MARCdetail, and catalogue/labeledMARCdetail.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-03-09 12:43:36 UTC --- Created attachment 3272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3272 follow-up - owen suggestions -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3272|follow-up - owen |(1/2) follow-up - owen description|suggestions |suggestions for text -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-03-09 13:22:28 UTC --- Created attachment 3273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3273 (2/2) Error handling for ISBDdetail, MARCdetail and labeledMARCdetail -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Failed QA --- Comment #7 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-03 23:22:32 UTC --- This bug is mentioned in: [Bug 5791] Robust handling of deleted biblios/authorities http://lists.koha-community.org/pipermail/koha-patches/2011-March/014012.htm... [Bug 5791] Robust handling of deleted biblios/authorities http://lists.koha-community.org/pipermail/koha-patches/2011-March/014014.htm... [Bug 5791] (2/2) Error handling for ISBDdetail, MARCdetail and labeledMARCdetail http://lists.koha-community.org/pipermail/koha-patches/2011-March/014013.htm... --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-04-08 08:16:49 UTC --- I have some merge conflicts while applying the first 'Initial patch': Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Robust handling of deleted biblios/authorities Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging authorities/detail.pl CONFLICT (content): Merge conflict in authorities/detail.pl Auto-merging catalogue/detail.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tmpl Failed to merge in the changes. Patch failed at 0001 Robust handling of deleted biblios/authorities When you have resolved this problem run "git am -i -3 --resolved". If you would prefer to skip this patch, instead run "git am -i -3 --skip". To restore the original branch and stop patching run "git am -i -3 --abort". [katrin@wombat kohaclone (oth_5791_nice_error|AM)]$git status -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-04-08 10:54:57 UTC --- Katrin, I'll be on office in about an hour and will rearrange things for the patch to apply. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3194|0 |1 is obsolete| | Attachment #3272|0 |1 is obsolete| | Attachment #3273|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-04-08 16:40:08 UTC --- Created attachment 3844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3844 Consolidated, refactored patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-04-12 21:41:10 UTC --- I checked out the html_template_pro tag for testing this with the old templates. I tested in intranet: Different biblionumbers and different views of biblio records: http://localhost:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=1000000 http://localhost:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=500000 http://localhost:8080/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=5000... http://localhost:8080/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=5000... Authorities: http://localhost:8080/cgi-bin/koha/authorities/detail.pl?authid=10414999 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3844|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-04-12 21:42:31 UTC --- Created attachment 3905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3905 Signed off: Consolidated, refactored patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-12 23:07:57 UTC --- Patches are only valid for 3.2, until they are reworked for Template::Toolkit -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3905|Signed off: Consolidated, |Signed off: Consolidated, description|refactored patch |refactored patch [3.2.x] -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-04-18 12:42:00 UTC --- Created attachment 3938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3938 [tt] Consolidated, refactored patch Patch reworked for template::toolkit templates. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3938|[tt] Consolidated, |Consolidated, refactored description|refactored patch |patch [origin|tt] -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-04-18 12:44:03 UTC --- Chris N.: Note that patches for 3.2.x are already signed-off, but they where built against pre-tt origin, so they could need to be rebased to apply. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-20 00:05:41 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2318 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-04-25 16:35:22 UTC --- Works great in 3.4 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-27 04:42:29 UTC --- This was included in the 3.4.0 release, marking closed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2283 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org