https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132976&action=edit Bug 30458:- Librarian ( manager_id ) not included in accountline when using "Payout amount" button When using the "Payout amount" button, accountlines.manager_id is not populated. This is not the case with the "Issue payout" buttons. Test Plan: 1) Create a manual credit 2) Issue a payout using the "Payout amount" button 3) Inspect the payout accountline, note it has no manager_id 4) Apply this patch, restart all the things! 5) Repeat steps 1 and 2 6) Note the new payout accountline has a manager_id! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- When I do steps 1-3 I do see a manager_id without this patch. Here is what I am doing when I look: select manager_id from accountlines where debit_type_code = 'PAYOUT'; Am I doing something wrong? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132976|0 |1 is obsolete| | --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 137905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137905&action=edit Bug 30458:- Librarian ( manager_id ) not included in accountline when using "Payout amount" button When using the "Payout amount" button, accountlines.manager_id is not populated. This is not the case with the "Issue payout" buttons. Test Plan: 1) Create a manual credit 2) Issue a payout using the "Payout amount" button 3) Inspect the payout accountline, note it has no manager_id 4) Apply this patch, restart all the things! 5) Repeat steps 1 and 2 6) Note the new payout accountline has a manager_id! Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Sally from comment #5)

I can replicate on master (the manager_id shows if 'issue payout' is used on the individual line, but doesn't show if the 'payout amount' button at the bottom of the lines is used).

After replicating the bug, I've tested the patch and it works - so signing off. Thanks for the patch.

Thanks for testing, Sally! (in general, but for this one too) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137905|0 |1 is obsolete| | --- Comment #7 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 137949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137949&action=edit Bug 30458: Include librarian (manager_id) in accountline when using "Payout amount" button When using the "Payout amount" button, accountlines.manager_id is not populated. This is not the case with the "Issue payout" buttons. Test Plan: 1) Create a manual credit 2) Issue a payout using the "Payout amount" button 3) Inspect the payout accountline, note it has no manager_id 4) Apply this patch, restart all the things! 5) Repeat steps 1 and 2 6) Note the new payout accountline has a manager_id! Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> JK: Fix commit title Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 --- Comment #11 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.