[Bug 16415] New: Layout problem on staff client detail page if local cover images are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415 Bug ID: 16415 Summary: Layout problem on staff client detail page if local cover images are enabled Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/catalogue/detail.pl?biblionumber=X OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Created attachment 51102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51102&action=edit Screenshot showing layout problem If you have local cover images enabled in the staff client but not Amazon images, local covers are not displayed in a column on the right like they should be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51103&action=edit Bug 16415 - Layout problem on staff client detail page if local cover images are enabled This patch fixes a layout problem which appears on the staff client bibliographic detail page if local covers are enabled but Amazon covers are not. To test, apply the patch and turn off AmazonCoverImages. - Enable the LocalCoverImages system preference and locate or create a record which has a local cover image associated with it. - View the bibliographic detail page. The bibliographic details should display in two columns, with text on the left and local cover image on the right. - Test with AmazonCoverImages and LocalCoverImages enabled. - Test with AmazonCoverImages enabled and LocalCoverImages disabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51103|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 51109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51109&action=edit Bug 16415 - Layout problem on staff client detail page if local cover images are enabled This patch fixes a layout problem which appears on the staff client bibliographic detail page if local covers are enabled but Amazon covers are not. To test, apply the patch and turn off AmazonCoverImages. - Enable the LocalCoverImages system preference and locate or create a record which has a local cover image associated with it. - View the bibliographic detail page. The bibliographic details should display in two columns, with text on the left and local cover image on the right. - Test with AmazonCoverImages and LocalCoverImages enabled. - Test with AmazonCoverImages enabled and LocalCoverImages disabled. All combinations are OK. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51109|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51209&action=edit Bug 16415 - Layout problem on staff client detail page if local cover images are enabled This patch fixes a layout problem which appears on the staff client bibliographic detail page if local covers are enabled but Amazon covers are not. To test, apply the patch and turn off AmazonCoverImages. - Enable the LocalCoverImages system preference and locate or create a record which has a local cover image associated with it. - View the bibliographic detail page. The bibliographic details should display in two columns, with text on the left and local cover image on the right. - Test with AmazonCoverImages and LocalCoverImages enabled. - Test with AmazonCoverImages enabled and LocalCoverImages disabled. All combinations are OK. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16415 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org