https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 163633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163633&action=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: ========== 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163633|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163652&action=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: ========== 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 --- Comment #3 from Andrii Nugged <nugged@gmail.com> --- Note: there was related issue: Bug 35383, solved differently, but I think we should analyze how to make "common", unified solution with same coding style -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com --- Comment #4 from Esther Melander <esther.melander@bywatersolutions.com> --- Also referencing Bug 36324, which I should have referenced was happening in a Chrome based browser. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | CC| |victor@tuxayo.net Status|Signed Off |Failed QA --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- The first attempt, the selected text in a subfield has a 1 second latency before highlighting text selected. (auth and biblios so it's from Bug 35383) That's weird but not blocking. (In reply to Andrii Nugged from comment #3)

Note: there was related issue: Bug 35383, solved differently, but I think we should analyze how to make "common", unified solution with same coding style

Good point, I had issues testing and when it worked, I forgot about this and attached a second signoff (it's just a 2nd signoff, it's valid). Back to this remark, for QA that's an issue because copying the change of bug 35425 is introducing duplication. initializeSortable() is totally duplicated and even the calls to it would benefit from being in the same place for biblios and auths to be sure that if those for on editor are changed, the others are. cataloging.js is included in addbiblio.tt and authorities.tt so unless something unexpected, moving the js change from addbiblio.tt and authorities.tt to cataloging.js should work. And then it's possible to solve the duplication of when cloning a field in cataloging.js. Because that part has the same code as initializeSortable() I don't know if it was noticed in bug 35425 that duplication was introduced, but it was it might have been ok to not bother. But now it's a third time duplication, see rule of three: https://en.wikipedia.org/wiki/Rule_of_three_(computer_programming) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165851|0 |1 is obsolete| | --- Comment #9 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 165852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165852&action=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: ========== 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165852|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166105&action=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: ========== 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166105|0 |1 is obsolete| | --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 166478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166478&action=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: ========== 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.11 |Main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed in 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.