[Bug 16554] New: Web installer fails to load i18n sample data on MySQL 5.6+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Bug ID: 16554 Summary: Web installer fails to load i18n sample data on MySQL 5.6+ Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Followup to bug 13669 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51619&action=edit Bug 13669: (alternative) use DBIx::RunSQL Alternative POC solution, on top of previous patches, feel free to obsolte. This patch use DBIx::RunSQL->run_sql_file to procees each sql file. To test: 1) Apply all patches 2) Same test plan of patch 1 Timing test running web installer, marc21, all sample data, time in seconds a) without patch structure data 59.7 66.5 58.6 66.0 b) SQL::SplitStatement (patch 1+2) 59.4 101 59.7 102 c) DBIx::RunSQL (patch 3) 60.7 66.8 59.4 66.2 Tomas' version is a bit slower loading sample data, all give similar results processing kohastructure. New dependency to package: DBIx::RunSQL Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51620&action=edit Bug 16554: Fix fr-FR sample files Needs Bug 13669 Rewrite autorites_norme_unimarc.sql to use only one INSERT IGNORE. New load method complains about duplicate keys, and both auth files are mandatory! Also removed blank space from sample_labels.sql Tested with unimarc_complet and all sample files. To test 1) Apply the patch 2) Try fr-FR web installer, unimarc_complet + all sample files There must be no errors Don't know if fr-FR marc21 and unimarc_lecture_pub are used, need a look from french users. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51621&action=edit Bug 16554: Fix I18N sample files Needs Bug 13669 This patch fix web installer for de-DE, es-ES, fr-CA, nb-NO and pl-PL To test: 1) Apply patch 2) Try web installer for any/all listed languages. a) de-DE, es-ES, fr-CA and pl-PL There must be no problems for marc21 + all sample files b) nb-NO There must be no problems for normarc + all sample files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51619|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13669 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 [Bug 13669] Web installer fails to load sample data on MySQL 5.6+ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is it ready to be tested? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51752&action=edit Bug 16554: rewrite mandatory and sample data - de-DE More changes to de-DE files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51753&action=edit Bug 16554: rewrite mandatory and sample data - es-ES More changes to es-ES files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51754&action=edit Bug 16554: rewrite mandatory and sample data - it-IT More changes to it-IT files Checked marc21 and unimarc files unimarc_relatorterms.sql had bad encoding, others minor errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51754|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51755&action=edit Bug 16554: rewrite mandatory and sample data - it-IT More changes to it-IT files Checked marc21 and unimarc files unimarc_relatorterms.sql had bad encoding, others minor errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51756&action=edit Bug 16554: rewrite mandatory and sample data - nb-NO More changes to nb-NO files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51757&action=edit Bug 16554: rewrite mandatory and sample data - pl-PL More changes to pl-PL files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13669 |16573 Status|ASSIGNED |Needs Signoff --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #4)
Is it ready to be tested?
Yep, it's ready. ru-RU and uk-UA not fixed, yet. Perhaps on other bug after release. I think we need this ASAP. TEST PLAN --------- ON TOP OF: Bug 16573 1) Apply ALL patches 2) Use MySQL 5.7 3) Then test web installer for all langs marc21: de-DE, es-ES, fr-CA, pl-PL unimarc: fr-FR (complete), it-IT normarc: nb-NO There must be no errors 4) Enjoy !!! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 [Bug 13669] Web installer fails to load sample data on MySQL 5.6+ https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51840&action=edit Bug 16554: DO NOT PUSH - test for all sample files You will need to create a koha_test_installer DB before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #12)
Created attachment 51840 [details] [review] Bug 16554: DO NOT PUSH - test for all sample files
You will need to create a koha_test_installer DB before
I did not finish the execution of this script but it should permit to test all sample files without inserting it manually. Could someone test it on MySQL 5.7 and all patches from this bug report (and from bug 16573 as well). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #13)
Could someone test it on MySQL 5.7 and all patches from this bug report (and from bug 16573 as well).
And make sure it raises warnings/errors without! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51890&action=edit Bug 16554: DO NOT PUSH - (followup) - sorted filenames Filenames must be loaded in alphabetical order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #13)
I did not finish the execution of this script but it should permit to test all sample files without inserting it manually.
I did, several times. Great tool Jonathan, it deserves to stay... somewhere :)
Could someone test it on MySQL 5.7 and all patches from this bug report (and from bug 16573 as well).
I found and fixed files for en, es-ES, fr-*, nb & pl I'm fixing ru & uk, it's a nightmare. I'll upload more patches soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51897&action=edit Bug 16554: More i18n changes - en, es, nb and pl files Mostly fixes bad values in auth files ( '' -> 0 ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51898&action=edit Bug 16554: More i18n changes - fr-FR files Mostly fixes bad values in auth files ( '' -> 0 ) Small rewrite of files. Too big for git-bz and/or bugzilla :( It's a compressed patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51899&action=edit Bug 16554: More i18n changes - ru-RU files Mostly fixes bad values in framework files ( '' -> 0 ) Rewriting of some files Removing truncations Too big for git-bz, compressed patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51900&action=edit Bug 16554: More i18n changes - uk-UA files Mostly fixes bad values in framework files ( '' -> 0 ) Rewriting of some files Removing truncations Too big for git-bz, compressed patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Large patch --- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- REVISED TEST PLAN ----------------- Apply all patches from 16573, all patches from this one, download, gunzip and apply last three patches On MySQL 5.7 create koha_test_installer db, then run Jonathan test file :) Must see no warnings/errors SAMPLE OUTPUT ------------- $ mysql --version mysql Ver 14.14 Distrib 5.7.12, for Linux (x86_64) using EditLine wrapper $ prove -v t/db_dependent/Test_installer.t t/db_dependent/Test_installer.t .. loading kohastructure for de-DE | not marc21 loading kohastructure for de-DE | not unimarc loading kohastructure for en | not marc21 loading kohastructure for en | not unimarc loading kohastructure for es-ES | not marc21 loading kohastructure for es-ES | not unimarc loading kohastructure for fr-CA | not marc21 loading kohastructure for fr-CA | not unimarc loading kohastructure for fr-FR | not marc21 loading kohastructure for fr-FR | not unimarc loading kohastructure for it-IT | not marc21 loading kohastructure for it-IT | not unimarc loading kohastructure for nb-NO | not marc21 loading kohastructure for nb-NO | not unimarc loading kohastructure for pl-PL | not marc21 loading kohastructure for pl-PL | not unimarc loading kohastructure for ru-RU | not marc21 loading kohastructure for ru-RU | not unimarc loading kohastructure for uk-UA | not marc21 loading kohastructure for uk-UA | not unimarc 110/110 No subtests run Test Summary Report ------------------- t/db_dependent/Test_installer.t (Wstat: 0 Tests: 0 Failed: 0) Parse errors: No plan found in TAP output Files=1, Tests=0, 3916 wallclock secs ( 0.06 usr 0.01 sys + 10.68 cusr 1.46 csys = 12.21 CPU) Result: FAIL Don't worry about FAIL message, with this output all is Ok. On my very modest system it took ~ 60 minutes. This has become a gigantic patchset, which guarantees that Koha installs on MySQL 5.7, any language/marcflavour, no that it runs. But it's a first step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset@hotmail.com --- Comment #22 from M. Tompsett <mtompset@hotmail.com> --- Please rebase. I was going to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #23 from M. Tompsett <mtompset@hotmail.com> --- de-DE and it-IT are the ones that fail. the zip files still apply, though whitespace issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sad to see this stuck - any chance for a rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51755|0 |1 is obsolete| | --- Comment #25 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 54136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54136&action=edit Bug 16554: rewrite mandatory and sample data - it-IT More changes to it-IT files Checked marc21 and unimarc files unimarc_relatorterms.sql had bad encoding, others minor errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51752|0 |1 is obsolete| | --- Comment #26 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 54137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54137&action=edit Bug 16554: rewrite mandatory and sample data - de-DE More changes to de-DE files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #27 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- de-DE and it-IT rebased prove -v t/db_dependent/Test_installer.t still works for all languages. Download compressed files using wget -O fr-FR.gz http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51898 wget -O ru-RU.gz http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51899 wget -O uk-UA.gz http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51900 gunzip and apply using git am -3 xx-YY -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from M. Tompsett <mtompset@hotmail.com> --- Finally got around to attempting to run it on my shiny new Ubuntu 16.04 LTS server VM. --- SNIP --- loading kohastructure for it-IT | not unimarc C4::Installer::load_sql returned the following errors while attempting to load /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql: DBD::mysql::st execute failed: Incorrect string value: '\xE0 l'an...' for column 'description' at row 5 at /usr/share/perl5/DBIx/RunSQL.pm line 273. loading kohastructure for nb-NO | not marc21 C4::Installer::load_sql returned the following errors while attempting to load /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql: DBD::mysql::st execute failed: Incorrect string value: '\xE0 l'an...' for column 'description' at row 5 at /usr/share/perl5/DBIx/RunSQL.pm line 273. --- END SNIP --- So I added a note line... # /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql C4::Installer::load_sql returned the following errors while attempting to load /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql: DBD::mysql::st execute failed: Incorrect string value: '\xE0 l'an...' for column 'description' at row 5 at /usr/share/perl5/DBIx/RunSQL.pm line 273. Fix and I'll retest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #29 from M. Tompsett <mtompset@hotmail.com> --- vi installer/.../subscription_numberpatterns.sql -- notice the [converted] :set fileencoding=utf-8 :wq I believe that is all that is needed to fix it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #30 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #29)
vi installer/.../subscription_numberpatterns.sql -- notice the [converted] :set fileencoding=utf-8 :wq
I believe that is all that is needed to fix it.
While that fixes some, still issues with: installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/autorites_norme_unimarc.sql -- something about 'CO' duplicate primary key. installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/framework_DEFAULT.sql -- something about '000' duplicate primary key. Also, ru-RU and uk-UA also seem to trigger on mandatory and repeatable fields now. They are rather floody. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #31 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 54399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54399&action=edit Bug 16554: Fix encoding on it-IT file This patch only fixes encoding of file installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #32 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to M. Tompsett from comment #30) ...
While that fixes some, still issues with: installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/ autorites_norme_unimarc.sql -- something about 'CO' duplicate primary key. installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/ framework_DEFAULT.sql -- something about '000' duplicate primary key. Also, ru-RU and uk-UA also seem to trigger on mandatory and repeatable fields now. They are rather floody.
Did you apply the compressed patches? Fixed encoding on it-IT file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #33 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #32)
Did you apply the compressed patches?
Oh, I may have forgotten that. Let me recheck with your encoding fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #34 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54404&action=edit Bug 16554 - DO NOT PUSH - Follow up to testing script Made it so that it really does fail or not based on testing. Also, added printing of files it is loading as it goes along. Forced a fail test for the files that don't load so they will get summarized at the end. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51620|0 |1 is obsolete| | --- Comment #35 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54405&action=edit Bug 16554: Fix fr-FR sample files Needs Bug 13669 Rewrite autorites_norme_unimarc.sql to use only one INSERT IGNORE. New load method complains about duplicate keys, and both auth files are mandatory! Also removed blank space from sample_labels.sql Tested with unimarc_complet and all sample files. To test 1) Apply the patch 2) Try fr-FR web installer, unimarc_complet + all sample files There must be no errors Don't know if fr-FR marc21 and unimarc_lecture_pub are used, need a look from french users. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51621|0 |1 is obsolete| | --- Comment #36 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54406&action=edit Bug 16554: Fix I18N sample files Needs Bug 13669 This patch fix web installer for de-DE, es-ES, fr-CA, nb-NO and pl-PL To test: 1) Apply patch 2) Try web installer for any/all listed languages. a) de-DE, es-ES, fr-CA and pl-PL There must be no problems for marc21 + all sample files b) nb-NO There must be no problems for normarc + all sample files Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51753|0 |1 is obsolete| | --- Comment #37 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54407&action=edit Bug 16554: rewrite mandatory and sample data - es-ES More changes to es-ES files Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51756|0 |1 is obsolete| | --- Comment #38 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54408&action=edit Bug 16554: rewrite mandatory and sample data - nb-NO More changes to nb-NO files Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51757|0 |1 is obsolete| | --- Comment #39 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54409&action=edit Bug 16554: rewrite mandatory and sample data - pl-PL More changes to pl-PL files Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51840|0 |1 is obsolete| | --- Comment #40 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54410&action=edit Bug 16554: DO NOT PUSH - test for all sample files You will need to create a koha_test_installer DB before Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51890|0 |1 is obsolete| | --- Comment #41 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54411&action=edit Bug 16554: DO NOT PUSH - (followup) - sorted filenames Filenames must be loaded in alphabetical order. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51897|0 |1 is obsolete| | --- Comment #42 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54412&action=edit Bug 16554: More i18n changes - en, es, nb and pl files Mostly fixes bad values in auth files ( '' -> 0 ) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54136|0 |1 is obsolete| | --- Comment #43 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54413&action=edit Bug 16554: rewrite mandatory and sample data - it-IT More changes to it-IT files Checked marc21 and unimarc files unimarc_relatorterms.sql had bad encoding, others minor errors Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54137|0 |1 is obsolete| | --- Comment #44 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54414&action=edit Bug 16554: rewrite mandatory and sample data - de-DE More changes to de-DE files Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54399|0 |1 is obsolete| | --- Comment #45 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54415&action=edit Bug 16554: Fix encoding on it-IT file This patch only fixes encoding of file installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54404|0 |1 is obsolete| | --- Comment #46 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 54416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54416&action=edit Bug 16554 - DO NOT PUSH - Follow up to testing script Made it so that it really does fail or not based on testing. Also, added printing of files it is loading as it goes along. Forced a fail test for the files that don't load so they will get summarized at the end. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #47 from M. Tompsett <mtompset@hotmail.com> --- Those gzip's are a pain to handle. This comment serves as notice that I, Mark Tompsett, sign those off too! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pallavi.tomar@gmail.com --- Comment #48 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 16775 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Did the test script pass for you guys? I get errors on "loading kohastructure for fr-FR | not marc21", stuffs like "Cannot add or update a child row: a foreign key constraint fails" and "Duplicate entry 'CO' for key 'PRIMARY'" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #49)
Did the test script pass for you guys? I get errors on "loading kohastructure for fr-FR | not marc21", stuffs like "Cannot add or update a child row: a foreign key constraint fails" and "Duplicate entry 'CO' for key 'PRIMARY'"
Forgot the gzip files! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #51 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Still fails, even with gzip files: # 21/26: /home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorite_default.sql C4::Installer::load_sql returned the following errors while attempting to load /home/koha/src/installer/data/mysql/fr-FR/marcflavour/un imarc_complet/Obligatoire/autorites_norme_unimarc.sql: not ok 1 - /home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql: DBD::mysql::s t execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_test_installer`.`auth_subfield_structure`, CO NSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`) REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UP DATE C) at /usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 254. # # Failed test '/home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql: DBD::my sql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_test_installer`.`auth_subfield_structur e`, CONSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`) REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UPDATE C) at /usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 254. # ' # at t/db_dependent/Test_installer.t line 48. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #52 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- With all patches applied, all test succeed with Marc fix :) git log --oneline | head -16 c1bfb24 Bug 16554: More i18n changes - uk-UA files 23001ea Bug 16554: More i18n changes - ru-RU files ca09bf0 Bug 16554: More i18n changes - fr-FR files 72ca21d Bug 16554 - DO NOT PUSH - Follow up to testing script 4c32489 Bug 16554: Fix encoding on it-IT file 0644c60 Bug 16554: rewrite mandatory and sample data - de-DE 989c319 Bug 16554: rewrite mandatory and sample data - it-IT 9c6ce1d Bug 16554: More i18n changes - en, es, nb and pl files c85d6e7 Bug 16554: DO NOT PUSH - (followup) - sorted filenames 79c2f1f Bug 16554: DO NOT PUSH - test for all sample files 1442061 Bug 16554: rewrite mandatory and sample data - pl-PL 596721f Bug 16554: rewrite mandatory and sample data - nb-NO 63afd53 Bug 16554: rewrite mandatory and sample data - es-ES 83b2d0d Bug 16554: Fix I18N sample files 1ba4ed1 Bug 16554: Fix fr-FR sample files 3315a88 Bug 17023: Repair "cancel" link ... ok All tests successful. Files=1, Tests=1, 3975 wallclock secs ( 0.24 usr 0.02 sys + 10.02 cusr 1.48 csys = 11.76 CPU) Result: PASS Dropping and re-creating database and running for fr-FR only it's Ok, all success. $ prove -v t/db_dependent/Test_installer.t t/db_dependent/Test_installer.t .. DBD::mysql::db do failed: Table 'koha_test_installer.systempreferences' doesn't exist [for Statement " SELECT * FROM systempreferences WHERE 1 = 0 "] at /home/bgkriegel/kohaclone/Koha/Database.pm line 93. loading kohastructure for fr-FR | not marc21 # 01/26: /home/bgkriegel/kohaclone/installer/data/mysql/audio_alerts.sql ... # 26/26: /home/bgkriegel/kohaclone/installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/framework_DEFAULT.sql loading kohastructure for fr-FR | not unimarc # 01/24: /home/bgkriegel/kohaclone/installer/data/mysql/audio_alerts.sql ... # 24/24: /home/bgkriegel/kohaclone/installer/data/mysql/fr-FR/marcflavour/marc21/Optionnel/marc21_simple_bib_frameworks.sql ok 1 - No failures 1..1 ok All tests successful. Files=1, Tests=1, 327 wallclock secs ( 0.05 usr 0.00 sys + 2.01 cusr 0.22 csys = 2.28 CPU) Result: PASS Don't know what to think :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #53 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #51)
Still fails, even with gzip files:
Could you ls -la the offending files? $ ls -la /home/mtompset/kohaclone/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql -rw-rw-r-- 1 mtompset mtompset 323371 Aug 22 21:28 /home/mtompset/kohaclone/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql I just retested on Debian, which is still <5.7, and Ubuntu 16.04 LTS. Perhaps your files are older? Try reloading them from scratch? mkdir ~/16554 cd ~/16554 wget -O fr-FR.gz https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51898 wget -O ru-RU.gz https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51899 wget -O uk-UA.gz https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51900 gunzip fr-FR.gz gunzip ru-RU.gz gunzip uk-UA.gz cd ~/kohaclone git checkout -b bug_16554 origin/master git pull git am < ~/16554/fr-FR git am < ~/16554/ru-RU git am < ~/16554/uk-UA git bz apply 16554 ... Because I'm just as confused as BGK as to why you might have those issues, JD. Though, I really hate those white space issues with the patches, but that isn't causing me any failures. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #54 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #51)
Still fails, even with gzip files: # 21/26: /home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/ Obligatoire/autorite_default.sql C4::Installer::load_sql returned the following errors while attempting to load /home/koha/src/installer/data/mysql/fr-FR/marcflavour/un imarc_complet/Obligatoire/autorites_norme_unimarc.sql: not ok 1 - /home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/ Obligatoire/autorites_norme_unimarc.sql: DBD::mysql::s t execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_test_installer`.`auth_subfield_structure`, CO NSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`) REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UP DATE C) at /usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 254. # # Failed test '/home/koha/src/installer/data/mysql/fr-FR/marcflavour/unimarc_complet/ Obligatoire/autorites_norme_unimarc.sql: DBD::my sql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_test_installer`.`auth_subfield_structur e`, CONSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authtypecode`) REFERENCES `auth_types` (`authtypecode`) ON DELETE CASCADE ON UPDATE C) at /usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 254. # ' # at t/db_dependent/Test_installer.t line 48.
OH! I think I have it. If you recall ALTER IGNORE doesn't work in MySQL 5.7.4, so if you upgraded through 3.19.00.042, you may find the upgrade had issues. I have a massive head cold. If no one posts a "make all the ALTER IGNORE into ALTER only" patch later, I will. I'm going to bed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #54)
OH! I think I have it. If you recall ALTER IGNORE doesn't work in MySQL 5.7.4, so if you upgraded through 3.19.00.042, you may find the upgrade had issues.
I have a massive head cold. If no one posts a "make all the ALTER IGNORE into ALTER only" patch later, I will. I'm going to bed.
I don't understand, I was just using the test script t/db_dependent/Test_installer.t, there is nothing about the updatedatabase script inside. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #56 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #55)
(In reply to M. Tompsett from comment #54)
OH! I think I have it. If you recall ALTER IGNORE doesn't work in MySQL 5.7.4, so if you upgraded through 3.19.00.042, you may find the upgrade had issues.
I don't understand, I was just using the test script t/db_dependent/Test_installer.t, there is nothing about the updatedatabase script inside.
Yes, but is your schema for koha_test_installer current? Did you copy if from an upgraded DB? I'm just trying to think of ways you could get up with the constraint failing. I don't guarantee they are good ideas. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #56)
(In reply to Jonathan Druart from comment #55)
(In reply to M. Tompsett from comment #54)
OH! I think I have it. If you recall ALTER IGNORE doesn't work in MySQL 5.7.4, so if you upgraded through 3.19.00.042, you may find the upgrade had issues.
I don't understand, I was just using the test script t/db_dependent/Test_installer.t, there is nothing about the updatedatabase script inside.
Yes, but is your schema for koha_test_installer current? Did you copy if from an upgraded DB? I'm just trying to think of ways you could get up with the constraint failing. I don't guarantee they are good ideas. :)
The script recreate the DB before each run/language. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #58 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #57)
The script recreate the DB before each run/language.
No, each table. But that wouldn't explain fr-FR which wasn't first. *sigh* Just trying to think of something. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #58)
(In reply to Jonathan Druart from comment #57)
The script recreate the DB before each run/language.
No, each table. But that wouldn't explain fr-FR which wasn't first. *sigh* Just trying to think of something.
It's not important, but the script recreates the table before each new "install" (lang+marcflavour): 29 for my $lang ( qw ( de-DE en es-ES fr-CA fr-FR it-IT nb-NO pl-PL ru-RU uk-UA ) ) { 30 for my $marcflavour ( qw( marc21 unimarc ) ) { 31 say "loading kohastructure for $lang | not $marcflavour"; 32 recreate_db( $db_name ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54405|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55219&action=edit Bug 16554: Fix fr-FR sample files Needs Bug 13669 Rewrite autorites_norme_unimarc.sql to use only one INSERT IGNORE. New load method complains about duplicate keys, and both auth files are mandatory! Also removed blank space from sample_labels.sql Tested with unimarc_complet and all sample files. To test 1) Apply the patch 2) Try fr-FR web installer, unimarc_complet + all sample files There must be no errors Don't know if fr-FR marc21 and unimarc_lecture_pub are used, need a look from french users. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54406|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55220&action=edit Bug 16554: Fix I18N sample files Needs Bug 13669 This patch fix web installer for de-DE, es-ES, fr-CA, nb-NO and pl-PL To test: 1) Apply patch 2) Try web installer for any/all listed languages. a) de-DE, es-ES, fr-CA and pl-PL There must be no problems for marc21 + all sample files b) nb-NO There must be no problems for normarc + all sample files Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54407|0 |1 is obsolete| | --- Comment #62 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55221&action=edit Bug 16554: rewrite mandatory and sample data - es-ES More changes to es-ES files Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54408|0 |1 is obsolete| | --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55222&action=edit Bug 16554: rewrite mandatory and sample data - nb-NO More changes to nb-NO files Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54409|0 |1 is obsolete| | --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55223&action=edit Bug 16554: rewrite mandatory and sample data - pl-PL More changes to pl-PL files Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54412|0 |1 is obsolete| | --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55224&action=edit Bug 16554: More i18n changes - en, es, nb and pl files Mostly fixes bad values in auth files ( '' -> 0 ) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54413|0 |1 is obsolete| | --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55225&action=edit Bug 16554: rewrite mandatory and sample data - it-IT More changes to it-IT files Checked marc21 and unimarc files unimarc_relatorterms.sql had bad encoding, others minor errors Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54414|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55226&action=edit Bug 16554: rewrite mandatory and sample data - de-DE More changes to de-DE files Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54415|0 |1 is obsolete| | --- Comment #68 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55227&action=edit Bug 16554: Fix encoding on it-IT file This patch only fixes encoding of file installer/data/mysql/it-IT/necessari/sample_numberpatterns.sql Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55228&action=edit Bug 16554: More i18n changes - fr-FR files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51898|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51899|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51900|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55229&action=edit Bug 16554: More i18n changes - ru-RU files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55230&action=edit Bug 16554: More i18n changes - uk-UA files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #72 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have successfully made an install with complet and STRICT_TRANS_TABLES, so I think we could let them go. We need this patch set pushed ASAP to catch remaining bugs before the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #73 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #74 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #75 from Julian Maurice <julian.maurice@biblibre.com> --- @RM @Joubu: I think the last 3 patches have been forgotten because they are wrapped inside a .tar.gz file. Can you have a look ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #76 from Julian Maurice <julian.maurice@biblibre.com> --- All patches but the 3 last ones are pushed to 3.22.x, they will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- ALL patches should have been pushed! The 3 tar.gz file should have been extracted to apply these 3 patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17360 --- Comment #78 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> ---
Bug 16554: DO NOT PUSH - test for all sample files
You will need to create a koha_test_installer DB before
I have moved this script to its own bug report, see bug 17360. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 [Bug 16797] errors in UNIMARC complet sample authorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |z.tajoli@cineca.it Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org