[Bug 41682] New: Syspref discrepancies between new and upgraded installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Bug ID: 41682 Summary: Syspref discrepancies between new and upgraded installs Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191858&action=edit Bug 41682: Add tests Patch from commit e4023c2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191859&action=edit Bug 41682: Sync DB and sysprefs.sql for new and upgraded installs This patch removes the discrepancies and put in sync the systempreferences table for new and upgraded installations. Main changes: * Set options to NULL when options="" * Fix explanation when different * Fix wrong order (some rows had options=explanation) * Fix wrong type "Yes/No" => "YesNo" * Remove StaffLoginBranchBasedOnIP: both StaffLoginLibraryBasedOnIP and StaffLoginBranchBasedOnIP are in the DB for upgraded installs * Remove the 'showsql' from the test. If we need it back then it must be a maintenance script. * Improve the tests: * Compare sysprefs.sql and the DB content for options, explanation and type * Catch type not defined * Catch incorrect YesNo values (must be 0 or 1) Later: * Add a C4::Installer sub to add new syspref: add_pref( { variable => $variable, value => $value, options => $options, explanation => $explanation, type => $type } ); * Clean 'type' and make it an ENUM * Make it easy to run the test for devs (should be in xt but we need it in t/db_dependent for packages - FIXME?) * Run the tests on upgraded installs on CI Test plan: 0. Apply the "tests" patch only 1. prove it => It fails loudly 2. Apply the DB change and run updatedatabase, prove the tests => they pass 3. Test upgraded installs: * checkout v24.05.00 (the version we use for Jenkins' Koha_Main_MariaDB_update job) * reset_all * checkout the branch with this patchset * updatabase * prove t/db_dependent/check_sysprefs.t => Should be green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com, | |martin.renvoize@openfifth.c | |o.uk, | |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41663 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- The second patch doesn't apply for me: git bz apply 41682 Bug 41682 - Syspref discrepancies between new and upgraded installs 191858 - Bug 41682: Add tests 191859 - Bug 41682: Sync DB and sysprefs.sql for new and upgraded installs Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 41682: Sync DB and sysprefs.sql for new and upgraded installs Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 41682: Sync DB and sysprefs.sql for new and upgraded installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191859|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191906&action=edit Bug 41682: Sync DB and sysprefs.sql for new and upgraded installs This patch removes the discrepancies and put in sync the systempreferences table for new and upgraded installations. Main changes: * Set options to NULL when options="" * Fix explanation when different * Fix wrong order (some rows had options=explanation) * Fix wrong type "Yes/No" => "YesNo" * Remove StaffLoginBranchBasedOnIP: both StaffLoginLibraryBasedOnIP and StaffLoginBranchBasedOnIP are in the DB for upgraded installs * Remove the 'showsql' from the test. If we need it back then it must be a maintenance script. * Improve the tests: * Compare sysprefs.sql and the DB content for options, explanation and type * Catch type not defined * Catch incorrect YesNo values (must be 0 or 1) Later: * Add a C4::Installer sub to add new syspref: add_pref( { variable => $variable, value => $value, options => $options, explanation => $explanation, type => $type } ); * Clean 'type' and make it an ENUM * Make it easy to run the test for devs (should be in xt but we need it in t/db_dependent for packages - FIXME?) * Run the tests on upgraded installs on CI Test plan: 0. Apply the "tests" patch only 1. prove it => It fails loudly 2. Apply the DB change and run updatedatabase, prove the tests => they pass 3. Test upgraded installs: * checkout v24.05.00 (the version we use for Jenkins' Koha_Main_MariaDB_update job) * reset_all * checkout the branch with this patchset * updatabase * prove t/db_dependent/check_sysprefs.t => Should be green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Nind from comment #3)
The second patch doesn't apply for me:
Yes, that will be a nightmare to rebase, we should push ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191858|0 |1 is obsolete| | Attachment #191906|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191931&action=edit Bug 41682: Add tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191932&action=edit Bug 41682: Sync DB and sysprefs.sql for new and upgraded installs This patch removes the discrepancies and put in sync the systempreferences table for new and upgraded installations. Main changes: * Set options to NULL when options="" * Fix explanation when different * Fix wrong order (some rows had options=explanation) * Fix wrong type "Yes/No" => "YesNo" * Remove StaffLoginBranchBasedOnIP: both StaffLoginLibraryBasedOnIP and StaffLoginBranchBasedOnIP are in the DB for upgraded installs * Remove the 'showsql' from the test. If we need it back then it must be a maintenance script. * Improve the tests: * Compare sysprefs.sql and the DB content for options, explanation and type * Catch type not defined * Catch incorrect YesNo values (must be 0 or 1) Later: * Add a C4::Installer sub to add new syspref: add_pref( { variable => $variable, value => $value, options => $options, explanation => $explanation, type => $type } ); * Clean 'type' and make it an ENUM * Make it easy to run the test for devs (should be in xt but we need it in t/db_dependent for packages - FIXME?) * Run the tests on upgraded installs on CI Test plan: 0. Apply the "tests" patch only 1. prove it => It fails loudly 2. Apply the DB change and run updatedatabase, prove the tests => they pass 3. Test upgraded installs: * checkout v24.05.00 (the version we use for Jenkins' Koha_Main_MariaDB_update job) * reset_all * checkout the branch with this patchset * updatabase * prove t/db_dependent/check_sysprefs.t => Should be green Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191931|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191932|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 191949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191949&action=edit Bug 41682: Add tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Edit: uncommented the `Test::NoWarnings` line, probably commented by mistake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #9 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 191950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191950&action=edit Bug 41682: Sync DB and sysprefs.sql for new and upgraded installs This patch removes the discrepancies and put in sync the systempreferences table for new and upgraded installations. Main changes: * Set options to NULL when options="" * Fix explanation when different * Fix wrong order (some rows had options=explanation) * Fix wrong type "Yes/No" => "YesNo" * Remove StaffLoginBranchBasedOnIP: both StaffLoginLibraryBasedOnIP and StaffLoginBranchBasedOnIP are in the DB for upgraded installs * Remove the 'showsql' from the test. If we need it back then it must be a maintenance script. * Improve the tests: * Compare sysprefs.sql and the DB content for options, explanation and type * Catch type not defined * Catch incorrect YesNo values (must be 0 or 1) Later: * Add a C4::Installer sub to add new syspref: add_pref( { variable => $variable, value => $value, options => $options, explanation => $explanation, type => $type } ); * Clean 'type' and make it an ENUM * Make it easy to run the test for devs (should be in xt but we need it in t/db_dependent for packages - FIXME?) * Run the tests on upgraded installs on CI Test plan: 0. Apply the "tests" patch only 1. prove it => It fails loudly 2. Apply the DB change and run updatedatabase, prove the tests => they pass 3. Test upgraded installs: * checkout v24.05.00 (the version we use for Jenkins' Koha_Main_MariaDB_update job) * reset_all * checkout the branch with this patchset * updatabase * prove t/db_dependent/check_sysprefs.t => Should be green Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #10 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 191951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191951&action=edit Bug 41682: Add ApiKeyLog description This particular case already introduced discrepancies. Fixing. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #11 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 191952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191952&action=edit Bug 41682: Fix 'integer' vs. 'Integer' inconsistency There are 72 occurences for the 'Integer' type, and 8 for 'integer'. Tests fail because of `StoreLastBorrower` already, so fixing them all for good. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #12 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 191953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191953&action=edit Bug 41682: Fix 'cancelation' typo Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Lucas <lucasmontoya@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucasmontoya@theke.io --- Comment #13 from Lucas <lucasmontoya@theke.io> --- *** Bug 41663 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |26.05.00 release notes| | Status|Passed QA |Pushed to main --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work all! Pushed to main for 26.05.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Text to go in the|26.05.00 |This fixes several system release notes| |preferences discrepancies | |and adds tests, including: | | | |* Setting options to NULL | |when options="" | |* Fixing the explanation | |when different | |* Fixing the wrong order | |(some rows had | |options=explanation) | |* Fixing the wrong type | |"Yes/No" => "YesNo" | |* Removed | |StaffLoginBranchBasedOnIP: | |both | |StaffLoginLibraryBasedOnIP | |and | |StaffLoginBranchBasedOnIP | |are in the database for | |upgraded installs | |* Adding a description for | |ApiKeyLog | |* Fixing 'integer' vs. | |'Integer' inconsistency | |* Fixing 'cancelation' typo | |* Improving the tests: | | * Compare sysprefs.sql | |and the database content | |for options, explanation | |and type | | * Catch type not defined | | * Catch incorrect YesNo | |values (must be 0 or 1) | | | |An example where | |discrepancies have crept in | |during upgrades includes | |warnings in the About Koha | |> System information - the | |system preferences had no | |value (either 1 or 0) in | |the 'value' field: | |* Warning System preference | |'ILLHistoryCheck' must be | |'0' or '1', but is ''. | |* Warning System preference | |'ILLOpacUnauthenticatedRequ | |est' must be '0' or '1', | |but is ''. | |* Warning System preference | |'SeparateHoldingsByGroup' | |must be '0' or '1', but is | |''. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41460 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Excellent, thanks a lot! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- The tests are failing on Jenkins: # Too many sysprefs in DB: Version, marcflavour, FrameworksLoaded, ElasticsearchIndexStatus_mydb, language -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41710 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- See bug 41710 for ElasticsearchIndexStatus_mydb -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39745 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- See bug 39745 for language -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192017&action=edit Bug 41682: Ignore 'FrameworksLoaded' Patch from commit f3c4dcb -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192027&action=edit Bug 41682: Ensure that sysprefs.sql is kept ordered by syspref's name Patch from commit d4b143c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192031&action=edit Bug 41682: More fixes * free => Free * options=NULL where type=Free * fix options and type for ArticleRequestsSupportedFormats * fix more explanation and options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at recent atomicupdates for examples I noticed that the database update here has no success or other output after the SQL has been run. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #22)
Looking at recent atomicupdates for examples I noticed that the database update here has no success or other output after the SQL has been run.
I didn't manage to produce easily a consistent output (because of the UPDATE returning always 1) so I decided to not produce any. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-ups pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41745 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41745 [Bug 41745] syspref's types need cleaning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> ---
* Clean 'type' and make it an ENUM
See bug 41745 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41746 [Bug 41746] Add a dev script to insert a new syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> ---
* Add a C4::Installer sub to add new syspref:
See bug 41746 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41800 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41800 [Bug 41800] Yet more syspref discrepancies between new and upgraded installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 --- Comment #27 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43339 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 [Bug 43339] automatic_item_modification_by_age_configuration is not a real system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|43339 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 [Bug 43339] automatic_item_modification_by_age_configuration is not a real system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #28 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is a big plumbing change. I propose not backport to older versions. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org