[Bug 27920] New: Add ability to update patron expiration dates when importing patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Bug ID: 27920 Summary: Add ability to update patron expiration dates when importing patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 118079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118079&action=edit Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 [Bug 27883] Add ability to preserve patron field from being overwritten by import -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Could not apply the patch ------------------------------------ Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all: a Applying: Bug 27920: Add ability to update patron expiration dates when importing patrons fatal: sha1 information is lacking or useless (Koha/Patrons/Import.pm). error: could not build fake ancestor Patch failed at 0001 Bug 27920: Add ability to update patron expiration dates when importing patrons The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- You'll need to apply the patches from bug 27883 first. (In reply to Amit Gupta from comment #2)
Could not apply the patch ------------------------------------
Bug 27920: Add ability to update patron expiration dates when importing patrons
Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file.
Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all: a Applying: Bug 27920: Add ability to update patron expiration dates when importing patrons fatal: sha1 information is lacking or useless (Koha/Patrons/Import.pm). error: could not build fake ancestor Patch failed at 0001 Bug 27920: Add ability to update patron expiration dates when importing patrons The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118079|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 119234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119234&action=edit Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind <david@davidnind.com> --- Hi Kyle. I get this message when applying the patch (after applying 27883): Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27920: Add ability to update patron expiration dates when importing patrons error: sha1 information is lacking or useless (Koha/Patrons/Import.pm). error: could not build fake ancestor Patch failed at 0001 Bug 27920: Add ability to update patron expiration dates when importing patrons ... David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119234|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120940&action=edit Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120940|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 120951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120951&action=edit Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120951|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 121885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121885&action=edit Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121885|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 121886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121886&action=edit Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Bug 27920 depends on bug 27883, which changed state. Bug 27883 Summary: Add ability to preserve patron field from being overwritten by import https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA tests fail, please fix! FAIL misc/import_patrons.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid syntax error update_dateexpiry_from_today" Global symbol "$return" requires explicit package name (did you forget to declare "my $return"?) misc/import_patrons.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121886|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 138524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138524&action=edit Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Are you sure about the test plan? No need to test the UI? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- "Update patron's expiration date based on the current date instead of the patron's enrollment date" This checkbox is always disabled, how is it useful? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Comment 10 still valid FAIL misc/import_patrons.pl FAIL valid syntax error update_dateexpiry_from_today" Global symbol "$return" requires explicit package name (did you forget to declare "my $return"?) misc/import_patrons.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138524|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139017&action=edit Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139018&action=edit Bug 27920: (QA follow-up) Update expiration date Checkbox should be enabled when overwriting existing patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139019&action=edit Bug 27920: (QA follow-up) Fix syntax error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- +import_patrons.pl --file /path/to/patrons.csv --matchpoint cardnumber --confirm [--default branchcode=MPL] [--overwrite] [--preserve_field <column>] [--preserve-extended-attributes] [--update-expiration] [--verbose] Only one added? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Unit test With the patch applied, the tests output some warn, without the patch the output is clean: prove t/db_dependent/Koha/Patrons/Import.t t/db_dependent/Koha/Patrons/Import.t .. 166/176 Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$fh> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$fh> line 2. t/db_dependent/Koha/Patrons/Import.t .. ok BorrowerRenewalPeriodBase 2) GUI I am not sure the options are described clearly as is: Update existing patron expiration dates. * Maybe instead of update it should be "recalculate"? Otherwise I would understand this as 'use the expiration date from the file'. Update patron's expiration date based on the current date instead of the patron's enrollment date * We have BorrowerRenewalPeriodBase, maybe we could have a pull down or preselect the option according to the pref? * The 2 options feel disconnected. Maybe the second should only be enabled, if the first was checked? Or use identation? * What's the supposed behaviour when there is an expiration date in the import file? Will it be used or do the checkboxes take precedence? If so, maybe we could add: ... values in the import file will be ignored. * While we are there... can we also remove the . from the only option that has it? :) 3) Test plan Can we have a test plan please? 4) CLI Marcel is right, expiration-from-today is missing: +import_patrons.pl --file /path/to/patrons.csv --matchpoint cardnumber --confirm [--default branchcode=MPL] [--overwrite] [--preserve_field <column>] [--preserve-extended-attributes] [--update-expiration] [--verbose] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142176&action=edit Bug 27920: (QA follow-up) Change radios to a single select pulldown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142178&action=edit Bug 27920: (QA follow-up) Fix POD in cli tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> ---
1) Unit test
I'm not getting that warning. Can you see if it's still there for you?
2) GUI
I've added a following to unify the options into a single pulldown menu. This feels more unified and clear to me. What do you think?
3) Test plan
Test Plan: 1) Create a patron CSV file with a datexpiry column 2) Apply this patch 3) Restart all the things 4) Upload your file, choose to overwrite existing patrons, test with each of the 3 dateexpiry options, verify each performs correctly!
4) CLI
Fixed with another followup! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Back here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #22)
1) Unit test
I'm not getting that warning. Can you see if it's still there for you?
It's gone!
2) GUI
I've added a following to unify the options into a single pulldown menu. This feels more unified and clear to me. What do you think?
This is much easier to understand, thx! I made 2 changes in the follow-ups, please check.
3) Test plan
Test Plan: 1) Create a patron CSV file with a datexpiry column 2) Apply this patch 3) Restart all the things 4) Upload your file, choose to overwrite existing patrons, test with each of the 3 dateexpiry options, verify each performs correctly!
4) CLI
Fixed with another followup!
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139017|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142738&action=edit Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139018|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142739&action=edit Bug 27920: (QA follow-up) Update expiration date Checkbox should be enabled when overwriting existing patrons Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139019|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142740&action=edit Bug 27920: (QA follow-up) Fix syntax error Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142176|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142741&action=edit Bug 27920: (QA follow-up) Change radios to a single select pulldown Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142178|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142742&action=edit Bug 27920: (QA follow-up) Fix POD in cli tool Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142743&action=edit Bug 27920: (QA follow-up) Remove now obsolete JavaScript lines There JS lines were left over from the first suggested GUI using a checkbox. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142744&action=edit Bug 27920: (QA follow-up) Improve alignment of new option on patron form Switches from ul to ol as used by other options which improves the alignment of the options. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23757 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a new option to release notes| |the patron import from that | |allows to use the | |expiration date from the | |import file or recalculate | |the patron's expiration | |date using today's date or | |the original expiration | |date as base. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621 [Bug 34621] Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34883 [Bug 34883] Regression in Patron Import dateexpiry function -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org