[Bug 39960] New: Improve messages in opac-discharge.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 Bug ID: 39960 Summary: Improve messages in opac-discharge.tt Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org There's a use of 'item(s)' that can be avoided, and the messages contain a redundant 'checked out items' that could just be 'them'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |tomascohen@gmail.com Depends on| |14250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 [Bug 14250] Don't allow generating discharges for patrons with fines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 182700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182700&action=edit Bug 39960: Improve messages in opac-discharge.tt This patch makes the messages more streamlined. To test: 1. Enable `useDischarge` 2. Have a patron with two checkouts 3. Log into the OPAC and try to request a discharge => FAIL: You get a message that says '2 item(s)' and has redundant words. 4. Check one of the items in 5. Repeat 3 => FAIL: Same, but says '1 item(s)'. 6. Check it in 7. Add a manual fee 8. Repeat 3 => FAIL: Another redundant text about charges. 9. Apply this patch and repeat 2-8 => SUCCESS: Things read better 10. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182700|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 182707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182707&action=edit Bug 39960: Improve messages in opac-discharge.tt This patch makes the messages more streamlined. To test: 1. Enable `useDischarge` 2. Have a patron with two checkouts 3. Log into the OPAC and try to request a discharge => FAIL: You get a message that says '2 item(s)' and has redundant words. 4. Check one of the items in 5. Repeat 3 => FAIL: Same, but says '1 item(s)'. 6. Check it in 7. Add a manual fee 8. Repeat 3 => FAIL: Another redundant text about charges. 9. Apply this patch and repeat 2-8 => SUCCESS: Things read better 10. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement improves release notes| |the messages in the OPAC on | |the ask for a discharge | |page (Your account > Ask | |for discharge, when the | |useDischarge system | |preference is enabled). | | | |Improvements: | |- Improved | |wording for the number of | |items checked out: instead | |of "..2 item(s).." and "..1 | |item(s)..." the text | |changes based on the actual | |number of checkouts - "...2 | |items..." and "...an | |item...". | |- More succinct | |text: for example, instead | |of "Please pay your charges | |before reapplying.", | |"Please pay them before | |reapplying." CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve messages in |Improve messages in the |opac-discharge.tt |OPAC ask for a discharge | |page (opac-discharge.tt) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182707|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 184655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184655&action=edit Bug 39960: Improve messages in opac-discharge.tt This patch makes the messages more streamlined. To test: 1. Enable `useDischarge` 2. Have a patron with two checkouts 3. Log into the OPAC and try to request a discharge => FAIL: You get a message that says '2 item(s)' and has redundant words. 4. Check one of the items in 5. Repeat 3 => FAIL: Same, but says '1 item(s)'. 6. Check it in 7. Add a manual fee 8. Repeat 3 => FAIL: Another redundant text about charges. 9. Apply this patch and repeat 2-8 => SUCCESS: Things read better 10. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org