[Bug 23192] New: Cancelling holds over returning to wrong tabon waitingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Bug ID: 23192 Summary: Cancelling holds over returning to wrong tabon waitingreserves.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- Bug 21628 moved the tables to an include, however, it didn't take the 'tab' input into account To recreate: 1 - Place a hold 2 - Confirm the hold 3 - In the db change the expiration date: UPDATE reserves SET expirationdate = '2019-01-01'; 4 - Go to Home->Circulation->Holds awaiting pickup 5 - View your holds on the 'Holds waiting over' tab 6 - Inspect the button, note tab = "holdswaiting" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90942&action=edit Bug 23192: Correct tab input on waiting_holds.inc To test: 1 - Place 2 holds 2 - Confirm the holds 3 - In the db change the expiration date: UPDATE reserves SET expirationdate = '2019-01-01'; 4 - Go to Home->Circulation->Holds awaiting pickup 5 - View your holds on the 'Holds waiting over' tab 6 - Inspect the cancel button for one of the holds, note tab = "holdswaiting" 7 - Apply patch 8 - Refresh the page 9 - Inspect the buttton, note tab = "holdsover" 10 - Cancel the hold 11 - Note you return to the holds over tab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21628 [Bug 21628] Simplify holds awaiting pickup report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cancelling holds over |Cancelling holds over |returning to wrong tabon |returning to wrong tab on |waitingreserves.pl |waitingreserves.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90942|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91359&action=edit Bug 23192: Correct tab input on waiting_holds.inc To test: 1 - Place 2 holds 2 - Confirm the holds 3 - In the db change the expiration date: UPDATE reserves SET expirationdate = '2019-01-01'; 4 - Go to Home->Circulation->Holds awaiting pickup 5 - View your holds on the 'Holds waiting over' tab 6 - Inspect the cancel button for one of the holds, note tab = "holdswaiting" 7 - Apply patch 8 - Refresh the page 9 - Inspect the buttton, note tab = "holdsover" 10 - Cancel the hold 11 - Note you return to the holds over tab Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91359|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91392&action=edit Bug 23192: Correct tab input on waiting_holds.inc To test: 1 - Place 2 holds 2 - Confirm the holds 3 - In the db change the expiration date: UPDATE reserves SET expirationdate = '2019-01-01'; 4 - Go to Home->Circulation->Holds awaiting pickup 5 - View your holds on the 'Holds waiting over' tab 6 - Inspect the cancel button for one of the holds, note tab = "holdswaiting" 7 - Apply patch 8 - Refresh the page 9 - Inspect the buttton, note tab = "holdsover" 10 - Cancel the hold 11 - Note you return to the holds over tab Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.03 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Note there is a second commit : Bug 23192: (RM follow-up) Add missing filters to waiting_holds.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 [Bug 25883] Show transfer on checkin screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25883 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 [Bug 25883] Show transfer on checkin screen -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org