[Bug 7239] New: Acquisitions basket, add order to basket, from new, Source of classification or shelving scheme being blank caused internal error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 Bug #: 7239 Summary: Acquisitions basket, add order to basket, from new, Source of classification or shelving scheme being blank caused internal error Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: chrish@catalyst.net.nz QAContact: ian.walls@bywatersolutions.com When creating a new basket in Acquisitions the fields "Title" and "quantity" are red (indicating mandatory) so I fill them in and click save, however if you do not select an option from "Source of classification or shelving scheme" (leaving it blank) then after clicking save an internal error occurs[1]. Using the back button to go back and fill in this field then clicking save will then show a basket with an excess entry (as the entry from before, although it caused an error, appears to still be added to the basket). Should "Source of classification or shelving scheme" be marked mandatory, or is this a bug in the display of the basket? [1] on mykoha.co.nz it is mentioned as "an internal error occured", however using my local setup I get "mismatched tag at line 7, column 2, byte 273 at /usr/lib/perl5/XML/Parser.pm line 187". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 --- Comment #1 from Chris Hall <chrish@catalyst.net.nz> 2011-11-17 03:17:04 UTC --- Created attachment 6324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6324 Patch adds a stronger check on adding a closing </datafield> tag -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 --- Comment #2 from Chris Hall <chrish@catalyst.net.nz> 2011-11-17 03:18:35 UTC --- Here is a further explanation of the bug, I was planning to post it with the patch but the attach patch button took me to another page. The bug seems to be caused by the line: $xml .= "</datafield>\n" if @$tags > 0; in C4/Biblio.pm (line 1955) It seems that if the Source of classification or shelving scheme is not filed in then the resulting xml is: <collection$ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd" xmlns="http://www.loc.gov/MARC21/slim"> <record> </datafield> </record> </collection> and if you do fill in the field then the xml is: <collection xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd" xmlns="http://www.loc.gov/MARC21/slim"> <record> <datafield tag="952" ind1=" " ind2=" "> <subfield code="2">ddc</subfield> </datafield> </record> </collection> Patch places a stronger check on that line (checking if $xml contains a <datafield tag, rather than if $tags size is > 0) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff Severity|enhancement |minor -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-17 07:16:39 UTC --- I think the problem is perhaps not classification source, but that you have to fill out at least one field from the items form. Normally I use itemtype, branches would probably work too. Bug 4955 might be a duplicate. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 --- Comment #4 from Chris Hall <chrish@catalyst.net.nz> 2011-11-18 00:55:01 UTC --- Hey Katrin It appears you are right about any one of the fields having to be filled out, silly me. The issue described in bug 4955 seems to be related, sorry for the duplicate. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-18 05:49:42 UTC --- I spent a lot of time in acq running into this problem a lot. Glad you came up with a patch for it - it's an annoying bug. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 Marijana <mglavica@ffzg.hr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mglavica@ffzg.hr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-05 20:59:50 UTC --- Hi Chris, something seems to be wrong with your patch: git bz apply 7239 Bug 7239 - Acquisitions basket, add order to basket, from new, Source of classification or shelving scheme being blank caused internal error Patch adds a stronger check on adding a closing </datafield> tag Apply? [yn] y Patch format detection failed. git am -is3 /tmp/Patch-adds-a-stronger-check-on-adding-a-closing-da-zOWPN2.patch Patch format detection failed. Can you check and attach a new file please? Thx! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6324|0 |1 is obsolete| | --- Comment #7 from Chris Hall <chrish@catalyst.net.nz> 2011-12-06 03:05:30 UTC --- Created attachment 6588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6588 Patch adds a stronger check on adding a closing </datafield> tag Sorry about that, it seems I generated that using git diff rather than format-patch. Corrected formatted patch attached. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6588|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-06 06:01:52 UTC --- Created attachment 6589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6589 [SIGNED-OFF] bug 7239 fix to avoid error being thrown even though a record is created Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> When creating an item in acquisitions while ordering and not filling out any fields, there is no longer shown a perl error message. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed Summary|Acquisitions basket, add |Acquisitions, add order to |order to basket, from new, |basket, from new, no item |Source of classification or |field filed, |shelving scheme being blank |AcqCreateItem=ordering |caused internal error |cause internal error -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-14 16:43:25 UTC --- QA comment: description updated, everything else fine, 1 line patch works as expected -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-27 20:38:06 UTC --- *** Bug 4955 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 --- Comment #11 from Nicole C. Engard <nengard@gmail.com> --- *** Bug 7692 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7239 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch was included in 3.6.x prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org