[Bug 18139] New: 'Too many checked out' can confuse librarians
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Bug ID: 18139 Summary: 'Too many checked out' can confuse librarians Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The too many checked out message can be very confusing for librarians when the limit specified is more or less than the number of checkouts the patron already has. We should make it clear to the librarian that this is only counting certain types of checkouts by giving them the issuing rule criteria used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60427&action=edit Bug 18139 - Prep unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60428&action=edit Bug 18139 - 'Too many checked out' can confuse librarians The too many checked out message can be very confusing for librarians when the limit specified is more or less than the number of checkouts the patron already has. We should make it clear to the librarian that his is only counting certain types of checkouts by giving them the issuing rule criteria used. Test Plan: 1) Apply this patch 2) Try to check out more items than the circ rules allow for regular and on-site checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60429&action=edit Bug 18139 - Add additional unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #4 from Marc Véron <veron@veron.ch> --- Hi Kyle, I like this feature very much. However, I get an Internal Server Error while systematically testing. It occurs with following settings: - Delete all rules in 'Circulation rules and fines'. - Set a Default limit by patron category, e.g. Student 2 current checkouts , 2 on-site-chekouts Checkout to a student until the limit is reached. Result: Internal server error Plack error log says: Template process failed: undef error - Can't call method "description" on an undefined value at (...)/Koha/Template/Plugin/Categories.pm line 32. Without patch, it works fine, the message is triggered. BTW: I can always check out one item more than defined by the rules. E.g. I allow 2 checkouts (by any rule), the message triggers with the 4th checkout. I would expect it to trigger with the 3rd checkout. This happens with and without patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Eric Gosselin <eric.gosselin@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60427|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60428|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60429|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61489&action=edit Bug 18139 - Prep unit tests Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61490&action=edit Bug 18139 - 'Too many checked out' can confuse librarians The too many checked out message can be very confusing for librarians when the limit specified is more or less than the number of checkouts the patron already has. We should make it clear to the librarian that his is only counting certain types of checkouts by giving them the issuing rule criteria used. Test Plan: 1) Apply this patch 2) Try to check out more items than the circ rules allow for regular and on-site checkouts Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61491&action=edit Bug 18139 - Add additional unit tests Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marc Véron from comment #4) Mark, I do not recreate. Could you double check please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #10 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #9)
(In reply to Marc Véron from comment #4)
Mark, I do not recreate. Could you double check please?
Hi Jonathan I can no longer recreate the first part of comment #4 (internal server error) However I can recreate the "BTW": I can always check out one item more than defined by the rules. E.g. I allow 2 checkouts (by any rule), the message triggers with the 4th checkout. I would expect it to trigger with the 3rd checkout. This happens with and without patch. With the 4th checkout, message says: "Too many checked out. 3 checked out, only 2 are allowed." Should that go to a separate Bug? Marc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61489|0 |1 is obsolete| | --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 61541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61541&action=edit Bug 18139 - Prep unit tests Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61490|0 |1 is obsolete| | --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 61542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61542&action=edit Bug 18139 - 'Too many checked out' can confuse librarians The too many checked out message can be very confusing for librarians when the limit specified is more or less than the number of checkouts the patron already has. We should make it clear to the librarian that his is only counting certain types of checkouts by giving them the issuing rule criteria used. Test Plan: 1) Apply this patch 2) Try to check out more items than the circ rules allow for regular and on-site checkouts Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61491|0 |1 is obsolete| | --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 61543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61543&action=edit Bug 18139 - Add additional unit tests Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> Tested al patches together, works OK, can no longer reprocuce internal server error from comment 4. Regarding "Too meny count" (see BTW in comment #4) I will file a separate bug. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marc Véron from comment #10)
However I can recreate the "BTW": I can always check out one item more than defined by the rules. E.g. I allow 2 checkouts (by any rule), the message triggers with the 4th checkout. I would expect it to trigger with the 3rd checkout. This happens with and without patch.
With the 4th checkout, message says: "Too many checked out. 3 checked out, only 2 are allowed."
Should that go to a separate Bug?
Yes please, with more information because I did not recreate either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 [Bug 18321] One more checkouts possible than allowed by rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #15 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #14)
(In reply to Marc Véron from comment #10)
However I can recreate the "BTW": I can always check out one item more than defined by the rules. E.g. I allow 2 checkouts (by any rule), the message triggers with the 4th checkout. I would expect it to trigger with the 3rd checkout. This happens with and without patch.
With the 4th checkout, message says: "Too many checked out. 3 checked out, only 2 are allowed."
Should that go to a separate Bug?
Yes please, with more information because I did not recreate either.
See Bug 18321 :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61541|0 |1 is obsolete| | Attachment #61543|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61663&action=edit Bug 18139: Adapt tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, I think the way you changed the tests is wrong. We need to deeply check if the issuing rule is correct instead of only check if the key exists. Take a look at these tests, they almost all passed, unless if an issuing rule does not exist but one exists at patron category level (BranchBorrowerCircRule). I think it highlights an issue with your changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18321 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18321 [Bug 18321] One more checkouts possible than allowed by rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61542|0 |1 is obsolete| | Attachment #61663|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159307&action=edit Bug 18139: Display the rule critera used to determin the checkout limits to the template The too many checked out message can be very confusing for librarians when the limit specified is more or less than the number of checkouts the patron already has. We should make it clear to the librarian that his is only counting certain types of checkouts by giving them the issuing rule criteria used. Test Plan: 1) Apply this patch 2) Try to check out more items than the circ rules allow for regular and on-site checkouts Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159308&action=edit Bug 18139: Add/update unit tests Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159307|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159522&action=edit Bug 18139: Display the rule critera used to determin the checkout limits to the template The too many checked out message can be very confusing for librarians when the limit specified is more or less than the number of checkouts the patron already has. We should make it clear to the librarian that his is only counting certain types of checkouts by giving them the issuing rule criteria used. Test Plan: 1) Apply this patch 2) Try to check out more items than the circ rules allow for regular and on-site checkouts Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159308|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159523&action=edit Bug 18139: Add/update unit tests Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All working here.. minor perltidy issues highlighted, but on inspection, I can't work out how to resolve them. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Please tidy! WARN C4/Circulation.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 1093, now: 1098) OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt WARN t/db_dependent/Circulation/TooMany.t WARN tidiness The file is less tidy than before (bad/messy lines before: 172, now: 178) 2) We have "All libraries" in the include, but "All" for categories and itemtypes. Can we make this consistent? Sorry, running out of time today for adjusting myself! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159728&action=edit Bug 18139: Change 'All libraries' to 'All' for consistency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159729&action=edit Bug 18139: Tidy code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #24)
Created attachment 159728 [details] [review] Bug 18139: Change 'All libraries' to 'All' for consistency
Argh, I am sorry, I was not clear. The "All" is causing a bit of a translation headache, I meant to make them all specific. See bug 31735 for context. "In French, those different things have different genders and the "All" must be in that gender ("tous" for "male-gendered" things and "toutes" for "female-gendered" things)." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159728|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159740&action=edit Bug 18139: Specify 'all item types' and 'all patron categories' in template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #26)
(In reply to Kyle M Hall from comment #24)
Created attachment 159728 [details] [review] [review] Bug 18139: Change 'All libraries' to 'All' for consistency
Argh, I am sorry, I was not clear. The "All" is causing a bit of a translation headache, I meant to make them all specific.
See bug 31735 for context.
"In French, those different things have different genders and the "All" must be in that gender ("tous" for "male-gendered" things and "toutes" for "female-gendered" things)."
Np! New patch fixes that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159522|0 |1 is obsolete| | Attachment #159523|0 |1 is obsolete| | Attachment #159729|0 |1 is obsolete| | Attachment #159740|0 |1 is obsolete| | --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159904&action=edit Bug 18139: Display the rule critera used to determin the checkout limits to the template The too many checked out message can be very confusing for librarians when the limit specified is more or less than the number of checkouts the patron already has. We should make it clear to the librarian that his is only counting certain types of checkouts by giving them the issuing rule criteria used. Test Plan: 1) Apply this patch 2) Try to check out more items than the circ rules allow for regular and on-site checkouts Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159905&action=edit Bug 18139: Add/update unit tests Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159906&action=edit Bug 18139: Tidy code Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159907&action=edit Bug 18139: Specify 'all item types' and 'all patron categories' in template Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #34 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #35 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 23.05.x, will not backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35776 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35776 [Bug 35776] Wrong circulation rule displayed when parent itemtypes are used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19037 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org