[Bug 17767] New: Let Koha::Patron::Modification handle extended attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Bug ID: 17767 Summary: Let Koha::Patron::Modification handle extended attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org This is actually needed in order to implement bug 13757, because the underlying code doesn't handle extended attributes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 58256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58256&action=edit Bug 17767: Add borrower_modification.extended_attributes This patch changes the DB structure adding borrower_modifications.extended_attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 58257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58257&action=edit Bug 17767: DBIC update This patch can be skipped by the RM, it just updates the DBIC schema files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 58258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58258&action=edit Bug 17767: Make Koha::Patron::Modification handle extended attributes This patch makes Koha::Patron::Modification aware of the new extended_attributes column, which is expected to contain valid JSON data. The ->store method is modified so it validates the field value (i.e. the content is decoded using the JSON library) and raises a convenient exception in case of failure. This behaviour change is covered by the provided unit tests. To test: - Apply the patchset - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: Tests make sense, and they pass - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 58259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58259&action=edit Bug 17767: Unit tests This patch introduces tests for the new behaviour, and also enhances the existing ones aiming to reach full coverage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 58260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58260&action=edit Bug 17767: (followup) Rename test file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17755 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58256|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 58358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58358&action=edit Bug 17767: Add borrower_modification.extended_attributes This patch changes the DB structure adding borrower_modifications.extended_attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58257|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 58359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58359&action=edit Bug 17767: DBIC update This patch can be skipped by the RM, it just updates the DBIC schema files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58258|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 58360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58360&action=edit Bug 17767: Make Koha::Patron::Modification handle extended attributes This patch makes Koha::Patron::Modification aware of the new extended_attributes column, which is expected to contain valid JSON data. The ->store method is modified so it validates the field value (i.e. the content is decoded using the JSON library) and raises a convenient exception in case of failure. This behaviour change is covered by the provided unit tests. To test: - Apply the patchset - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: Tests make sense, and they pass - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58259|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 58361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58361&action=edit Bug 17767: Unit tests This patch introduces tests for the new behaviour, and also enhances the existing ones aiming to reach full coverage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58260|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 58362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58362&action=edit Bug 17767: (followup) Rename test file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58358|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58365&action=edit [SIGNED-OFF] Bug 17767: Add borrower_modification.extended_attributes This patch changes the DB structure adding borrower_modifications.extended_attributes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58359|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58366&action=edit [SIGNED-OFF] Bug 17767: DBIC update This patch can be skipped by the RM, it just updates the DBIC schema files. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58360|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58367&action=edit [SIGNED-OFF] Bug 17767: Make Koha::Patron::Modification handle extended attributes This patch makes Koha::Patron::Modification aware of the new extended_attributes column, which is expected to contain valid JSON data. The ->store method is modified so it validates the field value (i.e. the content is decoded using the JSON library) and raises a convenient exception in case of failure. This behaviour change is covered by the provided unit tests. To test: - Apply the patchset - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: Tests make sense, and they pass - Sign off :-D Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58361|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58368&action=edit [SIGNED-OFF] Bug 17767: Unit tests This patch introduces tests for the new behaviour, and also enhances the existing ones aiming to reach full coverage. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58362|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58369&action=edit [SIGNED-OFF] Bug 17767: (followup) Rename test file Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Passes the test plan, in which it passes the test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58365|0 |1 is obsolete| | Attachment #58366|0 |1 is obsolete| | Attachment #58367|0 |1 is obsolete| | Attachment #58368|0 |1 is obsolete| | Attachment #58369|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58437&action=edit Bug 17767: Add borrower_modification.extended_attributes This patch changes the DB structure adding borrower_modifications.extended_attributes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58438&action=edit Bug 17767: DBIC update This patch can be skipped by the RM, it just updates the DBIC schema files. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58439&action=edit Bug 17767: Make Koha::Patron::Modification handle extended attributes This patch makes Koha::Patron::Modification aware of the new extended_attributes column, which is expected to contain valid JSON data. The ->store method is modified so it validates the field value (i.e. the content is decoded using the JSON library) and raises a convenient exception in case of failure. This behaviour change is covered by the provided unit tests. To test: - Apply the patchset - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: Tests make sense, and they pass - Sign off :-D Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58440&action=edit Bug 17767: Unit tests This patch introduces tests for the new behaviour, and also enhances the existing ones aiming to reach full coverage. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58441&action=edit Bug 17767: (followup) Rename test file Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It would have been good to use the column_exists subroutine added by 17234 (but not pushed yet...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134 [Bug 21134] Wrong error handling in Koha/Patron/Modification.pm hides a bug -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org