[Bug 16429] New: Going to circulation from notice triggers may change logged in branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Bug ID: 16429 Summary: Going to circulation from notice triggers may change logged in branch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If you edit notice triggers and then use the "Checko out" tab from the top bar, you may change your logged in library by accident! To reproduce: 1) Disable the system preference CircAutocompl 2) Go to the notice triggers 3) Select the triggers for a library other than the one you logged in as 4) Use the "Check out" tab at the top to check out to a patron 5) Note your logged in branch has changed ( you'll need to refresh the page if the check out search took you directly to one patron ). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 51127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51127&action=edit Bug 16429 - Going to circulation from notice triggers may change logged in branch If you edit notice triggers and then use the "Checko out" tab from the top bar, you may change your logged in library by accident! Test Plan: 1) Disable the system preference CircAutocompl 2) Go to the notice triggers 3) Select the triggers for a library other than the one you logged in as 4) Use the "Check out" tab at the top to check out to a patron 5) Note your logged in branch has changed ( you'll need to refresh the page if the check out search took you directly to one patron ). 6) Apply this patch 7) Repeat steps 2-4 8) Note the branch no longer changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 51128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51128&action=edit Bug 16429 - Fix root problem The root of this issue is old code in circulation.pl that is no longer needed and leaves the affected scripts open to future regressions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51128|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 51129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51129&action=edit Bug 16429 - Fix root problem The root of this issue is old code in circulation.pl that is no longer needed and leaves the affected scripts open to future regressions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11779 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51129|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 51130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51130&action=edit Bug 16429 - Fix root problem The root of this issue is old code in circulation.pl that is no longer needed and leaves the affected scripts open to future regressions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51127|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 51134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51134&action=edit Bug 16429 - Going to circulation from notice triggers may change logged in branch If you edit notice triggers and then use the "Checko out" tab from the top bar, you may change your logged in library by accident! Test Plan: 1) Disable the system preference CircAutocompl 2) Go to the notice triggers 3) Select the triggers for a library other than the one you logged in as 4) Use the "Check out" tab at the top to check out to a patron 5) Note your logged in branch has changed ( you'll need to refresh the page if the check out search took you directly to one patron ). 6) Apply this patch 7) Repeat steps 2-4 8) Note the branch no longer changes Tested with both patches applied. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51130|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 51135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51135&action=edit Bug 16429 - Fix root problem The root of this issue is old code in circulation.pl that is no longer needed and leaves the affected scripts open to future regressions. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51134|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 51141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51141&action=edit Bug 16429 - Going to circulation from notice triggers may change logged in branch If you edit notice triggers and then use the "Checko out" tab from the top bar, you may change your logged in library by accident! Test Plan: 1) Disable the system preference CircAutocompl 2) Go to the notice triggers 3) Select the triggers for a library other than the one you logged in as 4) Use the "Check out" tab at the top to check out to a patron 5) Note your logged in branch has changed ( you'll need to refresh the page if the check out search took you directly to one patron ). 6) Apply this patch 7) Repeat steps 2-4 8) Note the branch no longer changes Tested with both patches applied. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Heather Braum <hbraum@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51135|0 |1 is obsolete| | --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 51142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51142&action=edit Bug 16429 - Fix root problem The root of this issue is old code in circulation.pl that is no longer needed and leaves the affected scripts open to future regressions. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Heather Braum <hbraum@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51141|0 |1 is obsolete| | Attachment #51142|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51194&action=edit Bug 16429 - Going to circulation from notice triggers may change logged in branch If you edit notice triggers and then use the "Checko out" tab from the top bar, you may change your logged in library by accident! Test Plan: 1) Disable the system preference CircAutocompl 2) Go to the notice triggers 3) Select the triggers for a library other than the one you logged in as 4) Use the "Check out" tab at the top to check out to a patron 5) Note your logged in branch has changed ( you'll need to refresh the page if the check out search took you directly to one patron ). 6) Apply this patch 7) Repeat steps 2-4 8) Note the branch no longer changes Tested with both patches applied. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Good catch Kyle! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51195&action=edit Bug 16429 - Fix root problem The root of this issue is old code in circulation.pl that is no longer needed and leaves the affected scripts open to future regressions. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.05! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16429 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org