[Bug 16874] New: Making serials collections actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Bug ID: 16874 Summary: Making serials collections actions buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 53208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53208&action=edit Bug 16874: Making serials collections actions buttons To test: 1) Go to serials -> Search a subscription (or make a new one) 2) Ensure that subscription has an end-date that has passed or will pass soon 3) Go to Serials collection (left sidebar menu) 4) Ensure that Subscription summary table has two buttons, Create routing list and Renew. These buttons should be bolded and the table cell highlighted 5) Ensure 'Print list' is a button in year tables below 6) Edit subscription to have a later end-date (will not expire soon) 7) Go bacl to serials collection 8) Ensure that table cell is no longer highlighted and buttons not bolded. Renew button should not be there. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53208|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 53543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53543&action=edit Bug 16874: Making serials collections actions buttons To test: 1) Go to serials -> Search a subscription (or make a new one) 2) Ensure that subscription has an end-date that has passed or will pass soon 3) Go to Serials collection (left sidebar menu) 4) Ensure that Subscription summary table has two buttons, Create routing list and Renew. These buttons should be bolded and the table cell highlighted 5) Ensure 'Print list' is a button in year tables below 6) Edit subscription to have a later end-date (will not expire soon) 7) Go back to serials collection 8) Ensure that table cell is no longer highlighted and buttons not bolded. Renew button should not be there. 9) Ensure that both buttons do not wrap when the browser is narrow Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |c.gravely@arts.ac.uk --- Comment #3 from Claire Gravely <c.gravely@arts.ac.uk> --- Hi, Sorry, I didn't get two buttons in step 4 of the test. Just the one for 'create routing list'. The line wasn't highlighted either. 'Print list' was displaying just fine as a button. Claire -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Claire Gravely from comment #3)
Hi, Sorry, I didn't get two buttons in step 4 of the test. Just the one for 'create routing list'. The line wasn't highlighted either.
'Print list' was displaying just fine as a button.
Claire
Sorry, I should've added that the Renew button and row highlighting will only show if the subscription is about to expire or has expired. Could you please retest? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 --- Comment #5 from Claire Gravely <c.gravely@arts.ac.uk> --- (In reply to Aleisha Amohia from comment #4)
(In reply to Claire Gravely from comment #3)
Hi, Sorry, I didn't get two buttons in step 4 of the test. Just the one for 'create routing list'. The line wasn't highlighted either.
'Print list' was displaying just fine as a button.
Claire
Sorry, I should've added that the Renew button and row highlighting will only show if the subscription is about to expire or has expired. Could you please retest?
Hi, I just tried again. Same result. I set the expiration date in the past, today and in the future and saw the same results each time with no renew button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Claire Gravely from comment #5)
Hi, I just tried again. Same result. I set the expiration date in the past, today and in the future and saw the same results each time with no renew button.
Actually, I just realised that this functionality kind of doesn't work without the patch applied also. The way I describe what to expect in the test case is exactly how it should work with and without the patch, but even without it it's not acting as it should. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Aliki Pavlidou <pavlidoualiki@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pavlidoualiki@gmail.com --- Comment #7 from Aliki Pavlidou <pavlidoualiki@gmail.com> --- Hello, I tried to test this patch with the sandbox system, but it does not work. I've got this log in message in which the test/test credentials don't apply. "Welcome to the Koha web installer Before we begin, please verify you have the correct credentials to continue. Please log in with the username and password given to you by your systems administrator and located in your koha-conf.xml configuration file. Please enter your username and password:" Kind regards Aliki -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Aliki, could you try again with another sandbox? Make sure you try with a selected test database, to avoid the web installer if possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #9 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Patch tested with a sandbox, by Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53543|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 --- Comment #10 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 54946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54946&action=edit Bug 16874: Making serials collections actions buttons To test: 1) Go to serials -> Search a subscription (or make a new one) 2) Ensure that subscription has an end-date that has passed or will pass soon 3) Go to Serials collection (left sidebar menu) 4) Ensure that Subscription summary table has two buttons, Create routing list and Renew. These buttons should be bolded and the table cell highlighted 5) Ensure 'Print list' is a button in year tables below 6) Edit subscription to have a later end-date (will not expire soon) 7) Go back to serials collection 8) Ensure that table cell is no longer highlighted and buttons not bolded. Renew button should not be there. 9) Ensure that both buttons do not wrap when the browser is narrow Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54946|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 54961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54961&action=edit [PASSED QA] Bug 16874: Making serials collections actions buttons To test: 1) Go to serials -> Search a subscription (or make a new one) 2) Ensure that subscription has an end-date that has passed or will pass soon 3) Go to Serials collection (left sidebar menu) 4) Ensure that Subscription summary table has two buttons, Create routing list and Renew. These buttons should be bolded and the table cell highlighted 5) Ensure 'Print list' is a button in year tables below 6) Edit subscription to have a later end-date (will not expire soon) 7) Go back to serials collection 8) Ensure that table cell is no longer highlighted and buttons not bolded. Renew button should not be there. 9) Ensure that both buttons do not wrap when the browser is narrow Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org