[Bug 7755] New: C4::Items::GetAnalyticsCount needs C4::Search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7755 Priority: P3 Change sponsored?: --- Bug ID: 7755 Assignee: julian.maurice@biblibre.com Blocks: 7162 Summary: C4::Items::GetAnalyticsCount needs C4::Search QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: julian.maurice@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Architecture, internals, and plumbing Product: Koha GetAnalyticsCount needs some C4::Search subs but there is no 'use C4::Search' in C4::Items. This can cause GetAnalyticsCount to fail if called in a context where C4::Search is not loaded. This blocks bug 7162 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7755 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 8340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8340&action=edit use C4::Search in C4::Items GetAnalyticsCount needs subs from C4::Search -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7755 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7755 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- How can this be tested? Do you have one or more examples of where GetAnalyticsCount fails, because C4::Search is not loaded? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7755 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Problem was discovered testing the patch for bug 7162 which use C4::Items::DelItemCheck (which use GetAnalyticsCount). I don't know where DelItemCheck is used, but you can apply this patch and patch for bug 7162, and try to cancel an order line (in basket.pl or parcel.pl) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7755 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- C4::Search is already used in C4/Items.pm use C4::Search qw/SimpleSearch/; -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7755 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- ok so this patch is not useful anymore. marking as resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org