[Bug 20631] New: C4::Acounts claims to use ReturnLostItem but doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Bug ID: 20631 Summary: C4::Acounts claims to use ReturnLostItem but doesn't Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org use C4::Circulation qw(ReturnLostItem); When looking for ReturnLostItem I noticed it's listed in C4::Accounts, but appears not to be used there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |15896 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Call has been removed by commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Bug 15896 - Use Koha::Account::pay internally for makepayment Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 [Bug 15896] Use Koha::Account::pay internally for makepayment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77603&action=edit Bug 20631: Remove unused RemoveLostItem from C4::Accounts RemoveLostItem was 'used' in C4::Accounts, but is not actually used there. Call has been removed by commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Bug 15896 - Use Koha::Account::pay internally for makepayment To test: - Verify that the routine was actually not used! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77603|0 |1 is obsolete| | --- Comment #3 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 77714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77714&action=edit Bug 20631: Remove unused RemoveLostItem from C4::Accounts RemoveLostItem was 'used' in C4::Accounts, but is not actually used there. Call has been removed by commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Bug 15896 - Use Koha::Account::pay internally for makepayment To test: - Verify that the routine was actually not used! Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77714|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 78048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78048&action=edit Bug 20631: Remove unused RemoveLostItem from C4::Accounts RemoveLostItem was 'used' in C4::Accounts, but is not actually used there. Call has been removed by commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Bug 15896 - Use Koha::Account::pay internally for makepayment To test: - Verify that the routine was actually not used! Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 It is Koha::Account that uses ReturnLostItem now. This module is missing use C4::Circulation maybe ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21396 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #7)
Pushed to 17.11.x for 17.11.10
It is Koha::Account that uses ReturnLostItem now. This module is missing use C4::Circulation maybe ?
Yes, see bug 21396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21396 [Bug 21396] Missing use statements in Koha::Account -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org