https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Chronological order for |Make list of lists in OPAC |public lists in OPAC |sortable --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just checked, the table is not sortable, but it would be nice to have. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- The list of lists in the OPAC is paginated server-side, so adding sorting would require one of these methods: 1. Add sorting to the query, including handling of ascending and descending and the ability to order by the number of titles on the list. 2. Remove the server-side pagination and use DataTables to sort and paginate the all the results client-side. This would be adequate only if it isn't expected that there might be a very large number of lists. 3. Remove the server-side pagination and re-implement the table with an AJAX datasource, doing AJAX pagination. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Owen Leonard from comment #2)

The list of lists in the OPAC is paginated server-side, so adding sorting would require one of these methods:

1. Add sorting to the query, including handling of ascending and descending and the ability to order by the number of titles on the list.

2. Remove the server-side pagination and use DataTables to sort and paginate the all the results client-side. This would be adequate only if it isn't expected that there might be a very large number of lists.

3. Remove the server-side pagination and re-implement the table with an AJAX datasource, doing AJAX pagination.

4. Add an API route for this, and use the features we've recently added (specially bug 24561). It would make sorting by any column just trivial. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #6 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- We don't have a metric tonne, because we review and remove ours periodically, but it would be brilliant to have lists be sortable on the OPAC. It'd be even better if the staff client could control the default order (e.g. date added, date desc). We don't have a preference over 1, 2, 3 or 4 - they're all workable solutions. 2 might be nice for consistency; I think the Charges table uses DataTables on the OPAC? We can always target a DataTable with jQuery to set the default sort. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 [Bug 28959] virtualshelves.category is really a boolean -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 [Bug 28965] Add public routes for lists -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 --- Comment #8 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Ah brilliant - sounds like a great approach! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #10 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Our library would like to be able to sort the list of lists alphabetically and by date. It would also be nice if there was a way to bump a specific list (such as a seasonal list or hot top) to the top of the list of lists in order to highlight it for patrons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #12 from Donna <bwsdonna@gmail.com> --- We've recently had more libraries asking for options in how the lists display in the OPAC. Ideally, the option to order them like news items are handled using "display in position" would be best. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #14 from David Cook <dcook@prosentient.com.au> --- Had a library ask for this today, but it sounds like the community is a bit stuck on how to proceed? For what it's worth, on the server side, we're using DataTables. We may as well do it on the OPAC too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Fiona Fogden <ffogden@rics.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 CC| |ffogden@rics.org --- Comment #15 from Fiona Fogden <ffogden@rics.org> --- PLEASE can the list of lists at the very least be sortable alphabetically? Sorted by creation or some other random order really makes it a challenge to promote the lists and the only workaround is to create links to the lists manually in alpha order in an html page so defeating the otherwise brilliant idea of the lists. This is coming from a Koha user & Librarian in a membership organisation. Thank you, Fiona, RICS. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- I do want to look at this before the end of the year. Reminder to myself and others that the DataTable wrapper around the REST API comes from bug 24561 I'm not sure this feature is currently used in OPAC at all, but bug 24561 appears to have added it for OPAC so fingers crossed that it works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 --- Comment #19 from Fiona Fogden <ffogden@rics.org> --- Thank you @david cook. I am not technical but happy to help with testing if I can remember how to do that from my recent PTFS customer forum session! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Bug 18148 depends on bug 28965, which changed state. Bug 28965 Summary: Add public routes for lists https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Are you still intending to look into this David? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Maura Stephens <maura.stephens@atu.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maura.stephens@atu.ie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #22)

As I say that... it looks like there might be a discrepancy between the API and the existing table... and that's the "Contents" column. The /public/lists endpoint doesn't provide this information.

So the next step might be to add the contents count to /public/lists... as I could see people complaining if they had an API driven table without it. Of course, I could work on this in parallel to get the basics together and just add in that column a the end... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 --- Comment #25 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #4)

(In reply to Owen Leonard from comment #2)

...

The list of lists in the OPAC is paginated server-side, so adding sorting would require one of these methods:

1. Add sorting to the query, including handling of ascending and descending and the ability to order by the number of titles on the list.

2. Remove the server-side pagination and use DataTables to sort and paginate the all the results client-side. This would be adequate only if it isn't expected that there might be a very large number of lists.

3. Remove the server-side pagination and re-implement the table with an AJAX datasource, doing AJAX pagination.

4. Add an API route for this, and use the features we've recently added (specially bug 24561). It would make sorting by any column just trivial.

After doing some investigating, I think that option 1 (or rather option 1 with reduced functionality) might be the only feasible one. Option 3/4 would be great but the current API endpoints added aren't sufficient for this purpose, so they'd either need to be refactored or new API endpoints added. There's a bit of UI complexity that's unique to lists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #27 from David Cook <dcook@prosentient.com.au> --- Curious if Owen has any ideas for how this could be styled for a server-side sort without re-inventing the wheel... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 --- Comment #29 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #28)

Actually, I think that I've had a brain wave.

In the search results (/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1), there is a dropdown menu above the results that typically says "Relevance" but lets you choose alternate sorts.

So we have a precedent that we can work with.

I think that I've actually figured out a way to get them to both display nicely on one line of the toolbar...

I think it's a very practical solution.

Actually... it looks like there's a Sort option for the toolbar on per shelf basis (e.g. /cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=4) -- Some thinking to do on the styling perhaps but yeah... I think that's something I can work with... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 --- Comment #30 from David Cook <dcook@prosentient.com.au> --- Created attachment 188459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188459&action=edit Bug 18148: Make list of lists in OPAC sortable This patch adds sorting to lists of lists in the OPAC. The mechanism used here for op=list is similar to the one used in op=view, so it's stylistically and functionally consistent with the rest of the Lists module in the OPAC. Test plan: 0. Apply the patch and restart Plack (ie koha-plack --restart kohadev) 1. Create 20+ public lists and 20+ private lists for a particular user you control (try to use names that range throughout the alphabet) 2. Using SQL, update the Modification date for at least 1 public list and 1 private list 3. As an anonymous (ie not logged in user), go to /cgi-bin/koha/opac-shelves.pl?op=list&public=0 4. Note you cannot see any lists 5. Go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=list&public=1 6, Note you can see public lists with a toolbar with the button "Sort" below the alert "Log in to create a new list" 7. Using the "Sort" option, try out all the different sort options for default, "List name", and "Modification date" 8. After sorting, try paging through the list of lists. You should note that the sorting is retained through the paging. 9. prove t/db_dependent/Virtualshelves.t 10. Celebrate! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188459|0 |1 is obsolete| | Attachment #188460|0 |1 is obsolete| | --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188470&action=edit Bug 18148: Make list of lists in OPAC sortable This patch adds sorting to lists of lists in the OPAC. The mechanism used here for op=list is similar to the one used in op=view, so it's stylistically and functionally consistent with the rest of the Lists module in the OPAC. Test plan: 0. Apply the patch and restart Plack (ie koha-plack --restart kohadev) 1. Create 20+ public lists and 20+ private lists for a particular user you control (try to use names that range throughout the alphabet) 2. Using SQL, update the Modification date for at least 1 public list and 1 private list 3. As an anonymous (ie not logged in user), go to /cgi-bin/koha/opac-shelves.pl?op=list&public=0 4. Note you cannot see any lists 5. Go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=list&public=1 6, Note you can see public lists with a toolbar with the button "Sort" below the alert "Log in to create a new list" 7. Using the "Sort" option, try out all the different sort options for default, "List name", and "Modification date" 8. After sorting, try paging through the list of lists. You should note that the sorting is retained through the paging. 9. prove t/db_dependent/Virtualshelves.t 10. Celebrate! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 --- Comment #34 from David Cook <dcook@prosentient.com.au> --- You're a legend, Owen. Thanks heaps! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188471|0 |1 is obsolete| | --- Comment #36 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 188636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188636&action=edit Bug 18148: Add unit tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |lucas@bywatersolutions.com --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Please add release notes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #40 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Backported to 25.05.07 -- You are receiving this mail because: You are watching all bug changes.