[Bug 30740] New: Link to authorities 'used in' should not use equal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 Bug ID: 30740 Summary: Link to authorities 'used in' should not use equal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org When showing an authority, there is a link to search biblio records it is used in. Actually this link uses 'q=an=$auth_id', this is wrong for an URL, and other places use 'idx:value'. It does not break search with Zebra nor Elasticsearch but it is better to use ':' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 134916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134916&action=edit Bug 30740: Link to authorities 'used in' should not use equal When showing an authority, there is a link to search biblio records it is used in. Actually this link uses 'q=an=$auth_id', this is wrong for an URL, and other places use 'idx:value'. It does not break search with Zebra nor Elasticsearch but it is better to use ':' Test plan : Check changed links return same results with and without patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134916|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 134938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134938&action=edit Bug 30740: Link to authorities 'used in' should not use equal When showing an authority, there is a link to search biblio records it is used in. Actually this link uses 'q=an=$auth_id', this is wrong for an URL, and other places use 'idx:value'. It does not break search with Zebra nor Elasticsearch but it is better to use ':' Test plan : Check changed links return same results with and without patch Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes using koha-testing-docker. I used the authority term "Agile software development" (authority id = 133) - this is used in two records in the sample data. The search results were the same before and after the patch was applied. I only tested with the Zebra search engine. Links are changed/fixed on: - the OPAC search results page - number of records link: changes an=133 to an:133 - the staff interface details page - "Used on X record(s)" link: changes an=133 to an:133 Details ======= OPAC ~~~~ - Before: . Search results page - number of records link: http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?type=opac&op=do_search&q=an=133 . Authority details page - "Number of records used in: 2": http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?type=opac&q=133&idx=an,phr - After: . Search results page - number of records link: http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?type=opac&op=do_search&q=an:133 . Authority details page - "Number of records used in: 2": http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?type=opac&q=133&idx=an,phr Staff interface ~~~~~~~~~~~~~~~ - Before: . Search results page - number of records link: http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?type=intranet&op=do_search&idx=an,phr&q=133 . Authority details page - "Used in 2 record(s)": http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?type=intranet&op=do_search&q=an=133 - After: . Search results page - number of records link: http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?type=intranet&op=do_search&idx=an,phr&q=133 . Authority details page - "Used in 2 record(s)": http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?type=intranet&op=do_search&q=an:133 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ahhh link is different between results and detail page : q=133&idx=an,phr q=an=133 I will open an other bug report for that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #4)
Ahhh link is different between results and detail page : q=133&idx=an,phr q=an=133
I will open an other bug report for that
No need to - I did and fixed it, has been waiting for sign-off: Bug 29048 - Incorrect search for linked authority records from authority search result list in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134938|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134945&action=edit Bug 30740: Link to authorities 'used in' should not use equal When showing an authority, there is a link to search biblio records it is used in. Actually this link uses 'q=an=$auth_id', this is wrong for an URL, and other places use 'idx:value'. It does not break search with Zebra nor Elasticsearch but it is better to use ':' Test plan : Check changed links return same results with and without patch Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29048 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 [Bug 29048] Incorrect search for linked authority records from authority search result list in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30740 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org