[Bug 18630] New: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Bug ID: 18630 Summary: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to mistakes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 63536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63536&action=edit Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to mistakes. To test: - Apply patch - Enroll a patron to a club - Enable public enrollment in OPAC - Verify that the button to cancel enrollment in both OPAC and staff client reads 'Cancel enrollement' (instead of 'Cancel' without patch) (The button appears on the patron's detail pages in OPAC and staff client) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 dilan@calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan@calyx.net.au --- Comment #2 from dilan@calyx.net.au --- Created attachment 63563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63563&action=edit Patch fails to apply with fatal sha1 error Patch fails to apply with the attached error message being displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 --- Comment #3 from Marc Véron <veron@veron.ch> --- (In reply to dilan from comment #2)
Created attachment 63563 [details] Patch fails to apply with fatal sha1 error
Patch fails to apply with the attached error message being displayed.
Tested on current master: git bz apply 18630 Applies cleanly here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec@gmail.com --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Just tested 1) I think the word "enrollement" should be "enrollment" 2) The patch fixes only OPAC, in staff client remains "Cancel" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63536|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 63624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63624&action=edit Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to mistakes. To test: - Apply patch - Enroll a patron to a club - Enable public enrollment in OPAC - Verify that the button to cancel enrollment in both OPAC and staff client reads 'Cancel enrollement' (instead of 'Cancel' without patch) (The button appears on the patron's detail pages in OPAC and staff client) Amended for comment #4 / mv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63624|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63641&action=edit [SIGNED-OFF] Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to mistakes. To test: - Apply patch - Enroll a patron to a club - Enable public enrollment in OPAC - Verify that the button to cancel enrollment in both OPAC and staff client reads 'Cancel enrollement' (instead of 'Cancel' without patch) (The button appears on the patron's detail pages in OPAC and staff client) Amended for comment #4 / mv Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63641|0 |1 is obsolete| | Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 64328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64328&action=edit Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to mistakes. To test: - Apply patch - Enroll a patron to a club - Enable public enrollment in OPAC - Verify that the button to cancel enrollment in both OPAC and staff client reads 'Cancel enrollement' (instead of 'Cancel' without patch) (The button appears on the patron's detail pages in OPAC and staff client) Amended for comment #4 / mv Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer@bsz-bw.de Status|Pushed to Stable |RESOLVED --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No clubs in 16.11.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org