[Bug 23323] New: Koha::RefundLostItemFeeRules->find() should require `branchcode`, `categorycode` and `itemtype`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 Bug ID: 23323 Summary: Koha::RefundLostItemFeeRules->find() should require `branchcode`, `categorycode` and `itemtype` Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org We overload the find method in Koha::RefundLostItemFeeRules but we only test with branchcode calls and do not pupulate the database with sufficient test data to show that find would fail in a number of cases where a different rule may be present for distinct itemtypes or categorycodes per branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 [Bug 18930] Move lost item refund rules to circulation_rules table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 Bug 23323 depends on bug 18930, which changed state. Bug 18930 Summary: Move lost item refund rules to circulation_rules table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think this is done on bug 18936: Koha/CirculationRules.pm 54 our $RULE_KINDS = { 55 refund => { 56 scope => [ 'branchcode' ], 57 default_value => 1, 58 }, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also this rule must not exist in the DB for different categories or itemtypes, you can only define it (via the interface) for different libraries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 Bug 23323 depends on bug 18936, which changed state. Bug 18936 Summary: Convert issuingrules fields to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can this be closed with bug 18936 pushed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23323 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good call.. lets close it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org