[Bug 34080] New: Updating suggestion status can result in 500 eror
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Bug ID: 34080 Summary: Updating suggestion status can result in 500 eror Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Sometimes using "Mark selection as" to update a suggestions can result in a 500 error with the logged error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'suggestion_itemtype' in 'where clause' at /usr/share/koha/lib/Koha/Objects.pm line 394 It appears that the search params are built from *all* the form fields and then some form fields are removed from the hashref, but not all ( hence the error ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Updating suggestion status |Updating suggestion status |can result in 500 eror |can result in 500 error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 152524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152524&action=edit Bug 34080 - Updating suggestion status can result in 500 error Sometimes using "Mark selection as" to update a suggestions can result in a 500 error with the logged error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'suggestion_itemtype' in 'where clause' at /usr/share/koha/lib/Koha/Objects.pm line 394 It appears that the search params are built from *all* the form fields and then some form fields are removed from the hashref, but not all ( hence the error ). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Marci <mchen@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mchen@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- This patch stops the 500 error from occurring. However, with it applied I am unable to switch the status of suggestions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- To recreate: 1. Make some suggestions with different statuses. 2. Try moving some suggestion to different statuses. 3. Going from PENDING to another status works fine. 4. Moving from other status (REJECTED, ORDERED, etc ) will cause a 500 error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33322 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- The suggestions_batch_ops div is repeated and therefore should be a class not and an ID. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 152643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152643&action=edit Bug 34080: Make suggestions_batch_ops a class To test: 1. Make some suggestions with different statuses. 2. Try moving some suggestion to different statuses. 3. Going from PENDING to another status works fine. 4. Moving from other status (REJECTED, ORDERED, etc ) will cause a 500 error. 5. Apply patch 6. Try 2 - 4 again, no more 500 errors, yay! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|normal |major Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Marked as major because this effects libraries ability to manage purchase suggestions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152643|0 |1 is obsolete| | --- Comment #7 from Sam Lau <samalau@gmail.com> --- Created attachment 152644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152644&action=edit Bug 34080: Make suggestions_batch_ops a class To test: 1. Make some suggestions with different statuses. 2. Try moving some suggestion to different statuses. 3. Going from PENDING to another status works fine. 4. Moving from other status (REJECTED, ORDERED, etc ) will cause a 500 error. 5. Apply patch 6. Try 2 - 4 again, no more 500 errors, yay! Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152644|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152645&action=edit Bug 34080: Make suggestions_batch_ops a class To test: 1. Make some suggestions with different statuses. 2. Try moving some suggestion to different statuses. 3. Going from PENDING to another status works fine. 4. Moving from other status (REJECTED, ORDERED, etc ) will cause a 500 error. 5. Apply patch 6. Try 2 - 4 again, no more 500 errors, yay! Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial fix works as expected.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Charles Quain <csq@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |csq@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Patrick <pm@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pm@interleaf.ie --- Comment #11 from Patrick <pm@interleaf.ie> --- Is this bug going to be backported to 22.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate, | |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34601 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org