[Bug 8483] New: Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Priority: P5 - low Change sponsored?: --- Bug ID: 8483 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Borrower reading history should include deleted items Severity: enhancement Classification: Unclassified OS: All Reporter: robin@catalyst.net.nz Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |robin@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3397 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #1 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Work is currently in progress on this bug for Horowhenua District Council. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Mickey Coalwell <mcoalwell@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcoalwell@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #2 from Heather Braum <hbraum@nekls.org> --- Is this bug still being worked on by Horowhenua? We are very interested in this one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- It's very much on the backburner, but is fairly close to being done. If memory serves, it needs some minor schema changes, and that should be about it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #4 from Heather Braum <hbraum@nekls.org> --- Has there been any further movement on this bug? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #5 from Heather Braum <hbraum@nekls.org> --- Checking back in to see if the patch for this has moved forward, any further. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41013&action=edit Bug 8483 - Borrower reading history should include deleted items TODO: Break patch into smaller parts, add unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41013|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41014&action=edit Bug 8483 - Add checkout classes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41014|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41015&action=edit Bug 8483 - Add checkout classes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41016&action=edit Bug 8483 - Add record and item related classes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41017&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Verify old checkouts for deleted items show in reading history -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #11 from Robin Sheat <robin@catalyst.net.nz> --- Is this a bit overengineered? Could you not just extend the query? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #12 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Robin Sheat from comment #11)
Is this a bit overengineered? Could you not just extend the query?
I can see why you'd think that. I'd consider this as an opportunity to add some more useful Koha objects. There's little point to having an OO model if we don't take advantage of it, and there always has to be that first step! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41015|0 |1 is obsolete| | Attachment #41016|0 |1 is obsolete| | Attachment #41017|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41999&action=edit Bug 8483 - Add checkout classes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42000&action=edit Bug 8483 - Add record and item related classes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42001&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Verify old checkouts for deleted items show in reading history -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia@hotmail.com --- Comment #16 from Aleisha Amohia <aleishaamohia@hotmail.com> --- DBD::mysql::db do failed: Lock wait timeout exceeded; try restarting transaction at ../t/db_dependent/Members/GetAllIssues.t line 20. # Looks like your test exited with 255 before it could output anything. ../t/db_dependent/Members/GetAllIssues.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 16/16 subtests Test Summary Report ------------------- ../t/db_dependent/Members/GetAllIssues.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 16 tests but ran 0. Files=1, Tests=0, 56 wallclock secs ( 0.01 usr 0.03 sys + 1.19 cusr 0.22 csys = 1.45 CPU) Result: FAIL Setting to Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Kyle M Hall <kyle.m.hall@gmail.com> --- I'm unable to reproduce your test failure: prove t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/GetAllIssues.t .. ok All tests successful. Files=1, Tests=16, 5 wallclock secs ( 0.02 usr 0.01 sys + 1.06 cusr 0.08 csys = 1.17 CPU) Result: PASS (In reply to Aleisha Amohia from comment #16)
DBD::mysql::db do failed: Lock wait timeout exceeded; try restarting transaction at ../t/db_dependent/Members/GetAllIssues.t line 20. # Looks like your test exited with 255 before it could output anything. ../t/db_dependent/Members/GetAllIssues.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 16/16 subtests
Test Summary Report ------------------- ../t/db_dependent/Members/GetAllIssues.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 16 tests but ran 0. Files=1, Tests=0, 56 wallclock secs ( 0.01 usr 0.03 sys + 1.19 cusr 0.22 csys = 1.45 CPU) Result: FAIL
Setting to Failed QA
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41999|0 |1 is obsolete| | Attachment #42000|0 |1 is obsolete| | Attachment #42001|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42787&action=edit Bug 8483 - Add checkout classes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42788&action=edit Bug 8483 - Add record and item related classes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42789&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Verify old checkouts for deleted items show in reading history -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42789|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42932&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Verify old checkouts for deleted items show in reading history -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42932|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42935&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Check out and return an item for a patron 4) Delete that item 5) Verify the record still shows in the patron's reading history 6) Delete the record entirely 7) Verify the record still shows in the patron's reading history, but that the title is now just text instead of a hyperlink. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42787|0 |1 is obsolete| | Attachment #42788|0 |1 is obsolete| | Attachment #42935|0 |1 is obsolete| | --- Comment #23 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 42939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42939&action=edit Bug 8483 - Add checkout classes Signed-off-by: Heather Braum <hbraum@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #24 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 42940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42940&action=edit Bug 8483 - Add record and item related classes Signed-off-by: Heather Braum <hbraum@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #25 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 42941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42941&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Check out and return an item for a patron 4) Delete that item 5) Verify the record still shows in the patron's reading history 6) Delete the record entirely 7) Verify the record still shows in the patron's reading history, but that the title is now just text instead of a hyperlink. Signed-off-by: Heather Braum <hbraum@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|robin@catalyst.net.nz |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I was afraid of the complexity in the call stack, so did some tests: $ more bug_8483.pl use Modern::Perl; use C4::Members; my $borrowernumber=42; my $issues = GetAllIssues( $borrowernumber, 'date_due desc' );
select count(*) from old_issues where borrowernumber=42; 43 select count(*) from issues where borrowernumber=42; 7
select count(*) from issues where borrowernumber=42; 49 # master
$ git checkout master; git reset --hard origin/master $ git checkout -b bug_8483; git bz apply 8483 $ git checkout master; time perl bug_8483.pl perl bug_8483.pl 1.23s user 0.04s system 99% cpu 1.270 total $ git checkout bug_8483; time perl bug_8483.pl perl bug_8483.pl 1.50s user 0.05s system 99% cpu 1.560 total # => Ok we get the old_issues in addition of # Adding some issues to the patron perl bug_8483.pl 1.21s user 0.08s system 99% cpu 1.280 total # bug_8483 perl bug_8483.pl 1.82s user 0.07s system 97% cpu 1.933 total 210 # master perl bug_8483.pl 1.21s user 0.07s system 98% cpu 1.293 total # bug_8483 perl bug_8483.pl 2.73s user 0.09s system 95% cpu 2.959 total 600 # master perl bug_8483.pl 1.28s user 0.03s system 97% cpu 1.340 total # bug_8483 perl bug_8483.pl 4.78s user 0.10s system 94% cpu 5.154 total -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #27 from Kyle M Hall <kyle.m.hall@gmail.com> --- With 540 checkouts I get the following with your script: on master: real 0m1.023s user 0m0.980s sys 0m0.044s with bug 8483: real 0m1.032s user 0m0.980s sys 0m0.052s -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #27)
With 540 checkouts I get the following with your script:
on master: real 0m1.023s user 0m0.980s sys 0m0.044s
with bug 8483: real 0m1.032s user 0m0.980s sys 0m0.052s
Is it 500 checkouts for 1 patron? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #29 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Jonathan Druart from comment #28)
(In reply to Kyle M Hall from comment #27)
With 540 checkouts I get the following with your script:
on master: real 0m1.023s user 0m0.980s sys 0m0.044s
with bug 8483: real 0m1.032s user 0m0.980s sys 0m0.052s
Is it 500 checkouts for 1 patron?
Yes, all the checkouts are for one patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- tested again, without plack, and got exactly the same difference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall@gmail.com |kyle@bywatersolutions.com CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org