[Bug 9836] New: Filtering sort1 list according to patron category in patron data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Bug ID: 9836 Summary: Filtering sort1 list according to patron category in patron data Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Sort1 criterias are often used as subcategories of patron ones This patch adds the possibility to link a sort1 criteria to a patron category in the Bsort1 authorised_values settings. Then in the patron edition Library management block, the sort1 list is filtered according to the selected patron category and displays only the criterias linked to it. Test plan : 1) Apply patch 2) Go to Administration/Authorized values and select Bsort1 category 3) Edit a value you 'd like to bind with a patron category 4) Select the patron category in "Linked to" list and save 5) Do same thing for some other values 6) Go to an existing patron page, Details tab and set the patron category to the one you had linked some Bsort1 values with; 7) If you click below on Sort1 list, you 'll see that only these values are displayed. 8) From Patrons home module choose the category for a new patron in "New patron" list : again, you 'll see that only the linked values are to be seen in Sort1 list 9) Sign off the patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 --- Comment #1 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 16255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16255&action=edit Bug 9836 Filtering sort1 list according to patron category in patron data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 16258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16258&action=edit linked_with column in Bsort1 Authorized values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |koha@univ-lyon3.fr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 cedric.vita@dracenie.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |cedric.vita@dracenie.com --- Comment #3 from cedric.vita@dracenie.com --- Something went wrong ! Applying: Bug 9836 Filtering sort1 list according to patron category in patron data Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Failed to merge in the changes. Patch failed at 0001 Bug 9836 Filtering sort1 list according to patron category in patron data When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9836 - Filtering sort1 list according to patron category in patron data Bug 9836 Filtering sort1 list according to patron category in patron data Apply? [yn] Patch left in /tmp/Bug-9836-Filtering-sort1-list-according-to-patron--nJMbY9.patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16255|0 |1 is obsolete| | --- Comment #4 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 16301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16301&action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Always the same problem on updatedatabase.pl. I am really missing something on that mechanism. I set the version like this : 3.11.00.XXX. but it seems not to be sufficient. This new patch applies but if in the meanwhile something is added to updatedatabase, i suppose it won't any more ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #5 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Tested on sandbox : Maybe your patch is too restrictive, it would be more useful if : - we could link an authorised value to several borrowers categories (as it works for branches limitation in the same table) - we could use an authorised value linked to a patron category for other categories Last point : When you edit your bsort1 authorised value, you loose the link to the category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16301|0 |1 is obsolete| | --- Comment #6 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 17929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17929&action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Hello Patch modified. It's now possible to link a sort1 criteria to several borrower categories -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17929|0 |1 is obsolete| | --- Comment #7 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 18074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18074&action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Hello Forgot to report the add of new column linked_with in kohastructure.sql file corrected. Test plan : 1) Apply patch As a modification had to be made in authorised_values sql table, the database update should be be proposed when launching the Pro interface if not, make it through command line : cd src/installer/data/mysql perl updatadatabase.pl 2) Go to Administration/Authorized values and select Bsort1 category 3) Edit a value you 'd like to bind with a patron category 4) Select the patron category in "Linked to" list and save 5) Do same thing for some other values 6) Go to an existing patron page, Details tab and set the patron category to the one you had linked some Bsort1 values with; 7) If you click below on Sort1 list, you 'll see that only these values are displayed. 8) From Patrons home module choose the category for a new patron in "New patron" list : again, you 'll see that only the linked values are to be seen in Sort1 list 9) Sign off the patch. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 --- Comment #8 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- I tried to test on sandbox1 and had this message (it might not be tested on sandbox ?) Something went wrong ! Applying: Bug 9836 Filtering sort1 list according to patron category in patron data Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Failed to merge in the changes. Patch failed at 0001 Bug 9836 Filtering sort1 list according to patron category in patron data When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9836 - Filtering sort1 list according to patron category in patron data Bug 9836 Filtering sort1 list according to patron category in patron data Apply? [yn] Patch left in /tmp/Bug-9836-Filtering-sort1-list-according-to-patron--ED9Blz.patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18074|0 |1 is obsolete| | --- Comment #9 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 18426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18426&action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Hello Jean-Manuel, I rebased the patch. It should apply now if nothing is added to updatedatabase.pl in the meanwhile. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 --- Comment #10 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Sorry Olivier, I don't have private sandbox and there's a merge conflict. Database might be updated with the command u mentionned in your plan test ? There are 5 other users of this patch, maybe somenone with private ("fromagere") sandbox could test it ? Applying: Bug 9836 Filtering sort1 list according to patron category in patron data Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging admin/authorised_values.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging members/memberentry.pl Failed to merge in the changes. Patch failed at 0001 Bug 9836 Filtering sort1 list according to patron category in patron data When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9836 - Filtering sort1 list according to patron category in patron data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18426|0 |1 is obsolete| | --- Comment #11 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 18461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18461&action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Hello Jean-Manuel really sorry, my fault : I squeezed 2 lines of updatedatabase.pl when rebasing Olivier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 --- Comment #12 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Applying: Bug 9836 Filtering sort1 list according to patron category in patron data Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging admin/authorised_values.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging members/memberentry.pl Failed to merge in the changes. Patch failed at 0001 Bug 9836 Filtering sort1 list according to patron category in patron data When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9836 - Filtering sort1 list according to patron category in patron data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18461|0 |1 is obsolete| | --- Comment #13 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 18541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18541&action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Hey Jean-Manuel, I corrected a displaying error on the modified sort1 criteria Olivier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- tested on sandbox pro. Seems to work fine. Thanks for someone to do the QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |koha@univ-lyon3.fr |ity.org | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: There is a design issue in this patch: First, you add a column in a sql table only for some rows (in this case for categorycode=Bsort1). Then, multiple values are added into this column (you lost the foreign key to the patron categories). I don't like to say that but maybe a syspref is much more appropriate here. Ergonomic issue: A new column is added in the authorised values table, but the header only exists for the Bsort1 category. So there is a shift in others categories. Looking at the code: 1/ You use an unused tt variable (looploop). 2/ - SELECT id, category, authorised_value, lib, lib_opac, imageurl + SELECT * It is preferable to enumerate fields. Marked as Failed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org