http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2662 Summary: Random password suggestion should respect minimum password setting Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: normal Priority: P3 Component: Patrons AssignedTo: galen.charlton@liblime.com ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha.org member-password.pl suggests a random password to the user, but it doesn't consider the minimum password length when doing so. Koha should suggest passwords that meet the minimum password length. [10:08] <owen> My point is that since there can be a minimum length for passwords, this form shouldn't suggest something too short. [10:08] <owen> Trying to get to the bottom of how to make that work with all this random stuff [10:10] <acmoore> would it help to move that kind of logic to a function that we can write some test methods for? maybe in the C4::Members module or somewhere? [10:10] <owen> Or, we could junk it altogether. member-password.pl is the only place that tries to suggest a random password. [10:10] <owen> Does anyone use it? [10:11] <owen> It might become relevant if we do some kind of online patron registration system, but as it is I don't personally see the point [10:13] <acmoore> I don't know if anyone or any code actually uses it. [10:14] <acmoore> I wrote a similar method in t/lib/KohaTest.pm: 'random_string'. it's pretty similar. If you're looking to replace the logic in member-password with something, feel free to copy that method to a function somewhere in C4 or something. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.