[Bug 39089] New: Delivery note in patron notice table is confusing when the delivery method is print
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Bug ID: 39089 Summary: Delivery note in patron notice table is confusing when the delivery method is print Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Set a overdue trigger for print notice 2. Set up an overdue to be captured by overdue_notices.pl 3. Make sure the patron has an email address 4. Run overdue_notices.pl 5. Run gather_print_notices.pl 6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x) 7. Find the print row for the overdue just generated. 8. See that under the 'Delivery note' it says "To: test@test.com". This is confusing to staff as it is a print notice and wasn't delivered to an email address. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177718&action=edit Bug 39089: Do not show an email address when the tranport type is print To test: 1. Set a overdue trigger for print notice 2. Set up an overdue to be captured by overdue_notices.pl 3. Make sure the patron has an email address 4. Run overdue_notices.pl 5. Run gather_print_notices.pl 6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x) 7. Find the print row for the overdue just generated. 8. See that under the 'Delivery note' it says "To: test@test.com". 9. APPLY PATCH 10. Try again, you should now see no "To:" field when the transport type is print 11. Make sure that when the transport type is anything but print, you do see it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes a problem release notes| |where a patron's email | |address is shown in the | |'Delivery note' column when | |the message transport type | |is print. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177718|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177915&action=edit Bug 39089: Do not show an email address when the tranport type is print To test: 1. Set a overdue trigger for print notice 2. Set up an overdue to be captured by overdue_notices.pl 3. Make sure the patron has an email address 4. Run overdue_notices.pl 5. Run gather_print_notices.pl 6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x) 7. Find the print row for the overdue just generated. 8. See that under the 'Delivery note' it says "To: test@test.com". 9. APPLY PATCH 10. Try again, you should now see no "To:" field when the transport type is print 11. Make sure that when the transport type is anything but print, you do see it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Rebased using the auto-rebase script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177915|0 |1 is obsolete| | --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- Created attachment 179919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179919&action=edit Bug 39089: Do not show an email address when the tranport type is print To test: 1. Set a overdue trigger for print notice 2. Set up an overdue to be captured by overdue_notices.pl 3. Make sure the patron has an email address 4. Run overdue_notices.pl 5. Run gather_print_notices.pl 6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x) 7. Find the print row for the overdue just generated. 8. See that under the 'Delivery note' it says "To: test@test.com". 9. APPLY PATCH 10. Try again, you should now see no "To:" field when the transport type is print 11. Make sure that when the transport type is anything but print, you do see it. Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179919|0 |1 is obsolete| | --- Comment #5 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 180032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180032&action=edit Bug 39089: Do not show an email address when the tranport type is print To test: 1. Set a overdue trigger for print notice 2. Set up an overdue to be captured by overdue_notices.pl 3. Make sure the patron has an email address 4. Run overdue_notices.pl 5. Run gather_print_notices.pl 6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x) 7. Find the print row for the overdue just generated. 8. See that under the 'Delivery note' it says "To: test@test.com". 9. APPLY PATCH 10. Try again, you should now see no "To:" field when the transport type is print 11. Make sure that when the transport type is anything but print, you do see it. Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 180033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180033&action=edit Bug 39089: (QA follow-up) Apply the same fix to from address and CC address Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.08 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39089 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org