https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jake.deery@ptfs-europe.com |ity.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 --- Comment #1 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 168970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168970&action=edit Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37346 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168970|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169252&action=edit Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> QA script unhappy: FAIL installer/data/mysql/atomicupdate/bug_30955-add-new-notice.pl FAIL forbidden patterns forbidden pattern: tab char (line 1) WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 13) WARN t/db_dependent/Koha/Virtualshelf.t WARN tidiness The file is less tidy than before (bad/messy lines before: 9, now: 12) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 --- Comment #5 from Jake Deery <jake.deery@ptfs-europe.com> --- Yes, it was a bit ugly, apologies! Fixed now :-) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 --- Comment #7 from Jake Deery <jake.deery@ptfs-europe.com> --- Rebased atop the Bootstrap5 changes. As this only includes a 22-character change on one line, and the change is purely cosmetic, I have left the sign-off line in. Please feel free to revert this status if this was not the right thing to do. Jake. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jake Deery from comment #9)

Hey Lucas,

I suppose we have three options, here: a) don't include a notice out of the box, and let libraries figure out the new notice exists b) add a syspref for this (yet another syspref?) c) include the notice, let the notices fly, and propose we won't upset anyone

Happy to go with any of these, though a syspref does seem a bit bonkers for this?

Jake.

Jake, I agree with you. Sys pref is bonkers. I think, in this case we should include the notice and let em fly. Which I think means all is well here, no additional work needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170748|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170826&action=edit Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Status|Passed QA |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some hopefully smaller stuff here: 1) This patch introduces a new notice category: Lists. I think this is a good idea, but right now this will only contain one notice, wihle the other list related ones are still under OPAC, creating an inconsistency. I see 2 options: * Add the new category on a separate bug and then move all the notices into it at the same time * Move them here, notices are: LIST, SHARE_INVITE, SHARE_ACCEPT 2) The big question: add notice on update or not. I just pushed another bug recently that decided to not add on update. I think we could probably argue for both. But maybe we should try to have some guideline/consistency here? Bug 36915 - Send email notification when a booking is cancelled Don't add on update * Least surprise, no behavior change * Libraries will not miss to translate/adapt the notice text to local guidelines Add on update * Libraries can see how the notice looks like. But: bug 36815 will help with that now. I am leaning towards removing the database update right now. But happy to discus and be persuaded. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jake Deery from comment #14)

Hi Katrin,

Agree on point 1) – I can create a new bug for this shortly.

On point 2) – I am happy to go with removing the database update, but it raises a question for me: should we have a repository of default notices for libraries to refer to?

Jake.

We have had them on the wiki so far, but with Martin's new feature, one should be able to get the sample notice content once the notice with the right code has been created: bug 36815 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 --- Comment #17 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 172443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172443&action=edit Bug 30955: (follow-up) Remove database update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Would you mind squashing them? :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172443|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172445|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173213&action=edit Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173213|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173215&action=edit Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 --- Comment #27 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 173254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173254&action=edit Bug 30955: (follow-up) Merged related notices into lists This patch merges the SHARE_ACCEPT and SHARE_INVITE notices into the lists module. This makes a clearer case for introducing the lists module in the first place. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 --- Comment #29 from Jake Deery <jake.deery@ptfs-europe.com> --- Oh, and, I think we had this problem before with the author line. It was because I was pushing a few patches from my other laptop :/ Can we update the mailmap to solve this, or can I change this some other way? Jake. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173215|0 |1 is obsolete| | --- Comment #31 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 173255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173255&action=edit Bug 30955: Sends notice to new owner at transfer This patch adds a new notice, TRANSFER_OWNERSHIP, under a new module, Lists. When a list is transferred to a new owner, this notice is triggered, containing a short paragraph detailing the list name. TO TEST: a) log in as a koha superlibrarian b) go to the lists module, create a public list, and make a note of the title used c) on the lists module, transfer the list to some other user, and make a note of the user used d) go to the patron notices page for the user in step c e) ensure that a notice has been generated 1) check the contents of the notice, it should contain - the new owner's name - the list's title - the old owner's name & (if set) email f) under tools > notices, modify the notice for TRANSFER_OWNERSHIP g) repeat steps c-e 1) ensure the modifications you've made are now visible in the notice Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 --- Comment #34 from Jake Deery <jake.deery@ptfs-europe.com> --- Thanks cait, another one to remember for the future :-) Jake. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39052 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 --- Comment #37 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I notice there is a database update for transferring the existing notices to the new module. But there isn't one to add the new letter to existing databases. Is this on purpose or added in some other way? -- You are receiving this mail because: You are watching all bug changes.