[Bug 19822] New: Add system preferences for ILL Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Bug ID: 19822 Summary: Add system preferences for ILL Module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com Depends on: 7317 Right now, the ILL module is only configurable through the .conf file on the server. It would be great if we could add system preferences so that the configuration can be done through Koha's staff interface. - Tab in system preferences for all ILL configurations - Make StaffRequestComments (hide/show) a sys pref - Make ReplyDate (hide/show) a sys pref - Make DigitalRecipient (borrower/branch) a sys pref - Make PartnerCode (text entry, with by default ILLLIBS entered) a sys pref Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7317 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19605 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20536 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm wondering if this should be a distinct area under tools rather than exposed in the preferences page. That would more easily allow for different backends to expose their own individual configuration parameters more easily than each one having to attempt to somehow add to the preferences framework. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the plugins can have their own configuration pages as well. Maybe system preferences for the global values? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Joe McGlynn <joe.mcglynn@educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joe.mcglynn@educampus.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Bug 19822 depends on bug 7317, which changed state. Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7317 |19605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 [Bug 19605] ILL backends should be pluggable through regular Koha plugins -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- (In reply to Martin Renvoize from comment #1)
I'm wondering if this should be a distinct area under tools rather than exposed in the preferences page. That would more easily allow for different backends to expose their own individual configuration parameters more easily than each one having to attempt to somehow add to the preferences framework.
If ILL backends are turned into KPZ style plugins, this should solve itself. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21548 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood@ptfs-europ | |e.com --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Magnus Enger from comment #3)
If ILL backends are turned into KPZ style plugins, this should solve itself.
Not entirely sadly. A number of the config elements apply to ILL as a whole, rather than being backend specific. Certainly the config elements that are backend specific would be moved to plugin config, but I think the ones that applied to ILL as a whole would still need moving to sysprefs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- (In reply to Andrew Isherwood from comment #4)
Not entirely sadly. A number of the config elements apply to ILL as a whole, rather than being backend specific. Certainly the config elements that are backend specific would be moved to plugin config, but I think the ones that applied to ILL as a whole would still need moving to sysprefs.
Sorry for being unclear, I mean the same as you. General setting as sysprefs, backend-specific ones handled by the KPZ plugin system. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Niamh <niamh.walker-headon@it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon@hse.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we identify the global settings from the conf-settings? My impression is that not even the mandatory ones are used by the backend, even tho they are required to allow access to the module: https://wiki.koha-community.org/wiki/ILL_backends 1 <interlibrary_loans> 2 <!-- Path to where Illbackends are located on the system 3 - This setting should normally not be touched --> 4 <backend_directory>__PERL_MODULE_DIR__/Koha/Illbackends</backend_directory> 5 <!-- How should we treat staff comments? 6 - hide: don't show in OPAC 7 - show: show in OPAC --> 8 <staff_request_comments>hide</staff_request_comments> 9 <!-- How should we treat the reply_date field? 10 - hide: don't show this field in the UI 11 - any other string: show, with this label --> 12 <reply_date>hide</reply_date> 13 <!-- Where should digital ILLs be sent? 14 - borrower: send it straight to the borrower email 15 - branch: send the ILL to the branch email --> 16 <digital_recipient>branch</digital_recipient> 17 <!-- What patron category should we use for p2p ILL requests? 18 - By default this is set to 'ILLLIBS' --> 19 <partner_code>ILLLIBS</partner_code> 20 <branch><code>code_for_your_branch</code></branch> 21 </interlibrary_loans> backend_directory: If we moved to plugins, this would probably be replaced by the plugin path. How will Koha recognize that it's an ILL type plugin? staff_request_comments: Could be a system preference reply_date: Could be a system preference digital_recipient: Could be a system preference, not sure how this is implemented in the ILL module partner_code: Could be moved to plugins but also be a system preference. It should be updated to be set to IL on ktd/dev environments to match sample data. branch: I am not sure how and if this is used at all, need to verify. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Katrin, please note the below comments and let me know if you agree. Should be a sys pref: partner_code: - Only used by generic_confirm in Koha/Illrequest.pm; - Requires backend to have GENREQ request status to have "Place request with partners" button available and show the UI screen that uses partner_code; - Requires patron of <partner_code> category to have a primary email else it's not listed in the partners list; - Sys pref would maintain current default ILLLIBS value; - @Katrin should we have a separate bug to update sample_patron.yml and patron_categories.yml in the sample data's patron category from IL to ILLLIBS? staff_request_comments and reply_date: - Are both 'censorship' flags handled in load_configuration in Illrequest/Config.pm - Unfortunately these are strings and code is checking if they match 'hide'. Converting these into sys pref, they should be renamed to hide_staff_request_comments and hide_reply_date and be boolean. digital_recipient: - Either 'borrower' or 'branch'. Illrequest/Config.pm has a getter for this but it's only used by backends as far as I can tell. - As a sys pref, would be a dropdown with both values. Should stay in config: backend_directory; branch: - A check is made for if <branch> element exists in koha-conf.xml; - The <branch> block is repeatable. branch/code and branch/prefix: - I believe these are only to be used in tandem with each other, to possibilitate different request ID prefixes for different branches; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #7)
Katrin, please note the below comments and let me know if you agree.
Should be a sys pref:
partner_code: - Only used by generic_confirm in Koha/Illrequest.pm; - Requires backend to have GENREQ request status to have "Place request with partners" button available and show the UI screen that uses partner_code; - Requires patron of <partner_code> category to have a primary email else it's not listed in the partners list; - Sys pref would maintain current default ILLLIBS value; - @Katrin should we have a separate bug to update sample_patron.yml and patron_categories.yml in the sample data's patron category from IL to ILLLIBS?
There already is a separate one: bug 21548, but I'd actually standardize by changing ILLLIBS to IL. The sample data has been used like this forever, the ILL never matching was an early oversight in my opinion. I wonder how we could add a good general description to the system preference - might have to include some technical information too. Or we'd just make it the common spot to define your ILL patron category.
staff_request_comments and reply_date: - Are both 'censorship' flags handled in load_configuration in Illrequest/Config.pm - Unfortunately these are strings and code is checking if they match 'hide'. Converting these into sys pref, they should be renamed to hide_staff_request_comments and hide_reply_date and be boolean.
+1 I'd have said 'display' maybe?
digital_recipient: - Either 'borrower' or 'branch'. Illrequest/Config.pm has a getter for this but it's only used by backends as far as I can tell. - As a sys pref, would be a dropdown with both values.
Should stay in config:
backend_directory;
branch: - A check is made for if <branch> element exists in koha-conf.xml; - The <branch> block is repeatable.
How and what is this used for? I think 'our' backend doesn't use it at all. Does it need to remain mandatory? I think having to add a valid branchcode complicates standardized setups unnecessarily.
branch/code and branch/prefix: - I believe these are only to be used in tandem with each other, to possibilitate different request ID prefixes for different branches;
Just a thought: maybe we could move to a YAML style pref? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32546 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Pedro, I just wrote a patch to move the ILL preferences to their own tab in administration. It could be nice preparation for this bug, where we want to add more preferences: bug 32546 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |pedro.amorim@ptfs-europe.co |.com |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32546 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 [Bug 32546] Move ILL system preferences to their own tab in administration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19605 | Blocks| |19605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 [Bug 19605] ILL backends should be pluggable through regular Koha plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 [Bug 21548] ILLLIBS patron category / partner_code seems extraneous -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Adding 21548 as a dependency as partner_code in koha-conf.xml is ILLLIBS but sample data is using IL. This would cause a future test plan to be more work than it has to be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32899 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32899 [Bug 32899] Unused ILL configs in koha-conf.xml should be removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32911 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Bug 19822 depends on bug 21548, which changed state. Bug 21548 Summary: Make ILL patron category in koha-conf.xml match with ILL patron category in sample data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Bug 19822 depends on bug 21548, which changed state. Bug 21548 Summary: Make ILL patron category in koha-conf.xml match with ILL patron category in sample data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Bug 19822 depends on bug 32546, which changed state. Bug 32546 Summary: Move ILL system preferences to their own tab in administration https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Bug 19822 depends on bug 21548, which changed state. Bug 21548 Summary: Make ILL patron category in koha-conf.xml match with ILL patron category in sample data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Now that the depending bugs are done - could we resume here? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19605 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 [Bug 19605] ILL backends should be pluggable through regular Koha plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Heather <flyingendpaper@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |flyingendpaper@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk --- Comment #12 from Aude Charillon <aude.charillon@openfifth.co.uk> --- It would be nice to see more of the ILL .conf file settings moved to the staff interface. I am especially looking forward to the branch prefixes being either a system preference or managed in the libraries settings :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 --- Comment #13 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Aude Charillon from comment #12)
It would be nice to see more of the ILL .conf file settings moved to the staff interface. I am especially looking forward to the branch prefixes being either a system preference or managed in the libraries settings :-D
+1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org