[Bug 28603] New: check-url-quick.pl does not encode spaces in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Bug ID: 28603 Summary: check-url-quick.pl does not encode spaces in urls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz To recreate: 1 - Add an 856$u to a record with: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street shuffle 2 - perl misc/cronjobs/check-url-quick.pl > test.txt 2>&1 3 - grep shuffle test.txt 4 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street shuffle 596 Connection timed out 'URL' => 'http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street shuffle' 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street shuffle 596 Connection timed out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122177&action=edit Bug 28603: Encode spaces in urls in url checker To test: 1 - Add a url to a record like: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street%20shuffle 2 - perl misc/cronjobs/check-url-quick.pl -v > test.txt 3 - grep shuffle test.txt 4 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street shuffle 596 Connection timed out 5 - Apply patch 6 - perl misc/cronjobs/check-url-quick.pl -v > test.txt 7 - grep shuffle test.txt 8 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street%20shuffle 200 OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122177|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 122182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122182&action=edit Bug 28603: Encode spaces in urls in url checker To test: 1 - Add a url to a record like: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street%20shuffle 2 - perl misc/cronjobs/check-url-quick.pl -v > test.txt 3 - grep shuffle test.txt 4 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street shuffle 596 Connection timed out 5 - Apply patch 6 - perl misc/cronjobs/check-url-quick.pl -v > test.txt 7 - grep shuffle test.txt 8 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street%20shuffle 200 OK Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- $url = encode_utf8($url); + $url = uri_escape( $url, " " ); Normally we escape with uri_escape_utf8. This appears to be not exactly the same. Please explain why we should do so? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- uri_escape_utf8( $string, $unsafe ) Works like uri_escape(), but will encode chars as UTF-8 before escaping them. This makes this function able to deal with characters with code above 255 in $string. Note that chars in the 128 .. 255 range will be escaped differently by this function compared to what uri_escape() would. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I couldn't recreate the 303 error kohadev-koha@kohadevbox:koha((1516f227f9c...))$ grep shuffle test.txt 11 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street%20shuffle 200 OK Nick, are you happy for us to close this report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org