[Bug 25104] New: Small adjustments in NewVersion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25104 Bug ID: 25104 Summary: Small adjustments in NewVersion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25104 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25104 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 102677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102677&action=edit Bug 25104: Small adjustments to NewVersion Main point: all descriptions go under the line with version/bugno. Simplify the code in NewVersion. Test plan: Run updatedatabase on command line as well as interface. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25104 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25104 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25104 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The idea was to keep 1 line per entry, so I do not think we should split them into 2. Also I liked the idea of not having to pass an arrayref when we have only 1 line (90% of the time). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25104 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24131 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 [Bug 24131] Improved formatting for output of updatedatabase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25104 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I agree with Jonathan here, keeping comments on one line where we can is a feature rather than a bug.. The code may be a little messy, but it's also clear what it does. What I would like to see at some point is more of a guideline for how to best use the multi-line descriptions.. I think in general we should lead with a short summary and following lines should be for either deeper descriptions or warnings.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25104 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org