[Bug 21513] New: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Bug ID: 21513 Summary: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: arouss1980@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 80175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80175&action=edit missing 'Cancel' button and duplicate 'Save' button The bibliographic editor (cataloguing/addbiblio.pl) includes a 'Cancel' button in its toolbar at the top. Actually, most pages in Koha which allow you to add/edit something (e.g. MARC Framework, Authority types, Authorised values, etc.) have a 'Cancel' button or link. The authority editor (authorities/authorities.pl), however, does not have a 'Cancel' button. Oddly, it has two 'Save' buttons, as per the attached screenshot. I propose to: a) add a 'Cancel' button to the toolbar at the top of the page b) remove the 'Save' button from the bottom of the page since the floating toolbar already has one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |arouss1980@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 --- Comment #1 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 80176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80176&action=edit Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button The authority editor (authorities/authorities.pl) does not have a 'Cancel' button. Also, it has two 'Save' buttons. This patch fixes that by: a) adding a 'Cancel' button to the floating toolbar at the top b) removing the 'Save' button from the bottom of the page Test plan: 1) Go to Home > Authorities and launch the authority editor by clicking on 'New authority'. Notice how the editor doesn't have a 'Cancel' button. Also notice the two 'Save' buttons. 2) Apply the patch. 3) Re-launch the authority editor, and hit cancel; you should be taken back to Home > Authorities. 4) Edit an existing authority, and hit cancel; you should be taken back to the details page for the authority you chose. 5) Edit an authority as new (duplicate), and hit cancel; you should be taken back to Home > Authorities (this behaviour is mimicking the bibliographic editor: when duplicating a biblio the 'Cancel' button will take you back to Home > Cataloging). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80176|0 |1 is obsolete| | --- Comment #2 from Michal Denar <black23@gmail.com> --- Created attachment 80177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80177&action=edit Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button The authority editor (authorities/authorities.pl) does not have a 'Cancel' button. Also, it has two 'Save' buttons. This patch fixes that by: a) adding a 'Cancel' button to the floating toolbar at the top b) removing the 'Save' button from the bottom of the page Test plan: 1) Go to Home > Authorities and launch the authority editor by clicking on 'New authority'. Notice how the editor doesn't have a 'Cancel' button. Also notice the two 'Save' buttons. 2) Apply the patch. 3) Re-launch the authority editor, and hit cancel; you should be taken back to Home > Authorities. 4) Edit an existing authority, and hit cancel; you should be taken back to the details page for the authority you chose. 5) Edit an authority as new (duplicate), and hit cancel; you should be taken back to Home > Authorities (this behaviour is mimicking the bibliographic editor: when duplicating a biblio the 'Cancel' button will take you back to Home > Cataloging). Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80177|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80254&action=edit Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button The authority editor (authorities/authorities.pl) does not have a 'Cancel' button. Also, it has two 'Save' buttons. This patch fixes that by: a) adding a 'Cancel' button to the floating toolbar at the top b) removing the 'Save' button from the bottom of the page Test plan: 1) Go to Home > Authorities and launch the authority editor by clicking on 'New authority'. Notice how the editor doesn't have a 'Cancel' button. Also notice the two 'Save' buttons. 2) Apply the patch. 3) Re-launch the authority editor, and hit cancel; you should be taken back to Home > Authorities. 4) Edit an existing authority, and hit cancel; you should be taken back to the details page for the authority you chose. 5) Edit an authority as new (duplicate), and hit cancel; you should be taken back to Home > Authorities (this behaviour is mimicking the bibliographic editor: when duplicating a biblio the 'Cancel' button will take you back to Home > Cataloging). Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, no regressions found. Code is good and moves us towards a more unified experience. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Very nice and useful. Pushed to 17.11.x for 17.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21513 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org