[Bug 40265] New: t/db_dependent/OAI/Server.t tests fail when OPACHiddenItems have a value that's doesn't exist in the DB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Bug ID: 40265 Summary: t/db_dependent/OAI/Server.t tests fail when OPACHiddenItems have a value that's doesn't exist in the DB Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -Add something to OPACHiddenItems like withdrawn: [1] -Have no items in your DB with that value -prove -v /kohadevbox/koha/t/db_dependent/OAI/Server.t Tests fail -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |martin.renvoize@openfifth.c | |o.uk, | |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Hmm nope. Seems to work fine for me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I couldn't replicate eiterh - the tests passed for me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- What was the error? This one? 21:50:07 koha_1 | # got : '2025-06-26T19:50:06Z' 21:50:07 koha_1 | # expect : '2025-06-26T19:50:07Z' this is "expected" we should not compare timestamp without using t::lib::Dates::compare -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183723&action=edit Bug 40265: (try to) prevent OAI/Server.t to fail on slow server Jenkins failed with: 21:50:07 koha_1 | # got : '2025-06-26T19:50:06Z' 21:50:07 koha_1 | # expect : '2025-06-26T19:50:07Z' A guess is that we change second between the 2 dt_from_string calls, and the comparison fails. One thing however: it seems that we want to deal with timezone correctly here, but if we change the timezone in koha-conf.xml, the tests fail... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Summary|t/db_dependent/OAI/Server.t |t/db_dependent/OAI/Server.t |tests fail when |is failing randomly |OPACHiddenItems have a | |value that's doesn't exist | |in the DB | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183723|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 183725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183725&action=edit Bug 40265: (try to) prevent OAI/Server.t to fail on slow server Jenkins failed with: 21:50:07 koha_1 | # got : '2025-06-26T19:50:06Z' 21:50:07 koha_1 | # expect : '2025-06-26T19:50:07Z' A guess is that we change second between the 2 dt_from_string calls, and the comparison fails. One thing however: it seems that we want to deal with timezone correctly here, but if we change the timezone in koha-conf.xml, the tests fail... Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- not ok 34 - Tests for timestamp handling # Failed test 'Tests for timestamp handling' # at t/db_dependent/OAI/Server.t line 992. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #6)
not ok 34 - Tests for timestamp handling # Failed test 'Tests for timestamp handling' # at t/db_dependent/OAI/Server.t line 992.
Wait. Could be my timezone.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Still failing on Etc/UTC with me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- This is passing for me on a fresh ktd. Does it pass on main? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #9)
This is passing for me on a fresh ktd.
Does it pass on main?
Retried on current main. Exported TZ=Etc/UTC and set the same in koha-conf. Still fails with me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183725|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 186953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186953&action=edit Bug 40265: (try to) prevent OAI/Server.t to fail on slow server Jenkins failed with: 21:50:07 koha_1 | # got : '2025-06-26T19:50:06Z' 21:50:07 koha_1 | # expect : '2025-06-26T19:50:07Z' A guess is that we change second between the 2 dt_from_string calls, and the comparison fails. One thing however: it seems that we want to deal with timezone correctly here, but if we change the timezone in koha-conf.xml, the tests fail... Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Change looks good, but does not work for another timezone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- See commit message. And comment10 (no response). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|25.11.00,25.05.05 |25.11.00,25.05.05,24.11.11 released in| | --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.11 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Still an issue Koha_Main_MDB_Latest/3625 18:15:50 # Failed test 'GetRecord - biblio with a single item hidden by OpacHiddenItems returns as deleted' 18:15:50 # at t/db_dependent/OAI/Server.t line 187. 18:15:50 # Compared $data->{"GetRecord"}{"record"}{"header"}{"datestamp"} 18:15:50 # got : '2026-03-18T18:15:50Z' 18:15:51 # expect : '2026-03-18T18:15:51Z' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Again, Koha_Main/3642 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40962 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40962 [Bug 40962] t/db_dependent/OAI/Server.t is failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40265 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #19 from David Nind <david@davidnind.com> --- Test suite related - no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org