[Bug 41314] New: Does ExportCircHistory still has a purpose ?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 Bug ID: 41314 Summary: Does ExportCircHistory still has a purpose ? Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com I came up to this question while studying following bug: 1 - Set ExportCircHistory to "Don't show" 2 - Check out a book to Henry Acevedo 3 - Look at their circulation history : the footer is broken (it does not fit the lenght of the array), and you cannot export anymore. This bug is still valid and is due to this lines from checkouts-table-footer.inc: 7 [% IF Koha.Preference('ExportCircHistory') %] 8 [% SET td_colspan = 4 %] 9 [% ELSE %] 10 [% SET td_colspan = 3 %] 11 [% END %] However, as far as I understand the syspref the column concerned is always displayed and there is no change in the amount of displayed columns, colspan 3 does not fit. Hence I have two questions : 1 - Has it really been the purpose of this system preference to manage the column named "Export" (I did not explore the history of the code, I'll dig if no one knows) 2 - Shouldn't we simply delete this system preference and have it managed by the columns manager ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #1 from David Nind <david@davidnind.com> --- Some observations: 1. ExportCircHistory is incorrectly named: see Bug 40623 - ExportCircHistory preference is misnamed (and Bug 33828 - ExportCircHistory description is misleading, pushed in 23.11). If enabled, you get the export column and this text under the check outs table: "Export checkouts using format: [MARC with items|MARC without items] Export items bundle contents [] Don't export fields: _________ "Export" 2. A related system preference is ExportRemoveFields. If you add a value to this, such as 100a, then it is shown in "Don't export fields". However, if you do this, then the export column is not shown! (Even if you clear the browser cache). 3. There is also a problem at the moment when you turn off ExportCircHistory: - If you change it to "Don't show", the "Export" column is still shown, and only clearing the browser cache (or maybe just local storage?) removes the column. - If you don't clear the cache, the standard data tables export option "doesn't work" - there is a spinner when you select any of the export options, nothing is exported, and the spinner stays there (this looks the same as Bug 39389 - Cannot use dataTables export function on checkout table in members/moremember.pl, pushed to 25.05 - maybe it is back?) So, to answer your question (I think): 1. The export column on the patron check out table is not related to the standard DataTables export option. 2. There is a problem turning off ExportCircHistory - the export column is still shown unless you clear your cache. 3. ExportCircHistory is misnamed, it allows you to export current checkouts in MARC format, with and without items. 4. There is also a problem if you use the related system preference ExportRemoveFields. If you add a value to this, such as 100a, then it is shown in "Don't export fields" when ExportCircHistory is enabled. However, if you do this, then the export column is not shown! (Even if you clear the browser cache). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40623 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28905, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39389, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33828 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Depends on| |33484 Summary|Does ExportCircHistory |Column visibility broken on |still has a purpose ? |the checkouts table CC| |jonathan.druart@gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Currently the column visibility is broken because the table is not using bKohaColumnsUseNames. We should first fix that because it's a bug (and a regression certainly caused by DT's saveState, bug 33484). Then it will be quite trivial to move it to the table's settings. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 [Bug 33484] Ability to remember user's selected table configuration and search filters for tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189986&action=edit Bug 41314: Fix column visibility on the checkouts table Currently the column visibility is broken because the table is not using bKohaColumnsUseNames. We should first fix that because it's a bug (and a regression certainly caused by DT's saveState, bug 33484). Then it will be quite trivial to move it to the table's settings. Column visibility must use bKohaColumnsUseNames when some columns are displayed/hidden depending on sysprefs (or other variables). Test plan: 0. Do not apply this patch 1. Check an item out for a patron 2. Turn on ExportCircHistory 3. Reload the checkouts table => The export column is not displayed (FAIL) 4. Open the dev console (ctrl+shift+c on Firefox), Storage tab => local storage. Remove the 2 keys (only one may exist) DataTables_circ_circulation_issues-table DataTables_members_moremember_issues-table 5. Reload the checkouts table => The export column is displayed 6. Turn off ExportCircHistory 7. Reload the checkouts table => The column column is displayed (FAIL) Well, you got the idea, the syspref's value is not taken into account when a DataTable's state already exists in the local storage. Now apply this patch and repeat the different steps, on the two tabs * "Check out" (circ/circulation.pl) * "Default" (members/moremember.pl) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189986|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 189987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189987&action=edit Bug 41314: Fix column visibility on the checkouts table Currently the column visibility is broken because the table is not using bKohaColumnsUseNames. We should first fix that because it's a bug (and a regression certainly caused by DT's saveState, bug 33484). Then it will be quite trivial to move it to the table's settings. Column visibility must use bKohaColumnsUseNames when some columns are displayed/hidden depending on sysprefs (or other variables). Test plan: 0. Do not apply this patch 1. Check an item out for a patron 2. Turn on ExportCircHistory 3. Reload the checkouts table => The export column is not displayed (FAIL) 4. Open the dev console (ctrl+shift+c on Firefox), Storage tab => local storage. Remove the 2 keys (only one may exist) DataTables_circ_circulation_issues-table DataTables_members_moremember_issues-table 5. Reload the checkouts table => The export column is displayed 6. Turn off ExportCircHistory 7. Reload the checkouts table => The column column is displayed (FAIL) Well, you got the idea, the syspref's value is not taken into account when a DataTable's state already exists in the local storage. Now apply this patch and repeat the different steps, on the two tabs * "Check out" (circ/circulation.pl) * "Default" (members/moremember.pl) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |the 'Export' column on a | |patron's check out and | |details sections when | |ExportCircHistory is | |enabled and disabled. | |Because of a regression | |(caused by DT's saveState, | |bug 33484), the column was | |not correctly shown unless | |you cleared the cache/local | |storage: | |- If ExportCircHistory was | |set to 'Show', it is shown | |the first time. | |- If ExportCircHistory is | |then set to 'Don't show', | |the export column continues | |to show until you clear the | |browser cache/local | |storage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189987|0 |1 is obsolete| | --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 189992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189992&action=edit Bug 41314: Fix column visibility on the checkouts table Currently the column visibility is broken because the table is not using bKohaColumnsUseNames. We should first fix that because it's a bug (and a regression certainly caused by DT's saveState, bug 33484). Then it will be quite trivial to move it to the table's settings. Column visibility must use bKohaColumnsUseNames when some columns are displayed/hidden depending on sysprefs (or other variables). Test plan: 0. Do not apply this patch 1. Check an item out for a patron 2. Turn on ExportCircHistory 3. Reload the checkouts table => The export column is not displayed (FAIL) 4. Open the dev console (ctrl+shift+c on Firefox), Storage tab => local storage. Remove the 2 keys (only one may exist) DataTables_circ_circulation_issues-table DataTables_members_moremember_issues-table 5. Reload the checkouts table => The export column is displayed 6. Turn off ExportCircHistory 7. Reload the checkouts table => The column column is displayed (FAIL) Well, you got the idea, the syspref's value is not taken into account when a DataTable's state already exists in the local storage. Now apply this patch and repeat the different steps, on the two tabs * "Check out" (circ/circulation.pl) * "Default" (members/moremember.pl) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the display of |This fixes the display of release notes|the 'Export' column on a |the 'Export' column on a |patron's check out and |patron's check out and |details sections when |details sections when |ExportCircHistory is |ExportCircHistory is |enabled and disabled. |enabled and disabled. |Because of a regression |Because of a regression |(caused by DT's saveState, |(caused by DataTable's |bug 33484), the column was |saveState, bug 33484), the |not correctly shown unless |column was not correctly |you cleared the cache/local |shown unless you cleared |storage: |the cache/local storage: |- If ExportCircHistory was |- If ExportCircHistory was |set to 'Show', it is shown |set to 'Show', it is shown |the first time. |the first time. |- If ExportCircHistory is |- If ExportCircHistory is |then set to 'Don't show', |then set to 'Don't show', |the export column continues |the export column continues |to show until you clear the |to show until you clear the |browser cache/local |browser cache/local |storage. |storage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Impossible to backport to 24.11.x LTS due to checkouts.js not using yet kohaTable(). Patch adds "bKohaColumnsUseNames: true" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41468 [Bug 41468] Dont force show checkin column if user hid it previously -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #9 from David Nind <david@davidnind.com> --- Bug fix, no changes to the documentation required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 [Bug 41604] Impossible to hide Checkin column in issues-table in circ/circulation.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- We had complaints about this following our first wave of upgrades to 25.05(.06) from 24.05(.05). Instances where they had hidden the Checkin column now have it shown all the time. It is a regression. I'm not sure I understand why the visibility is forced. Especially that I personally find the checkin column particularly dangerous as staff don't need to scan the item to return it, leading to potentially checking in items that weren't actually returned by the patron. I created bug 41604. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42063 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org