[Bug 16016] New: Integrate sitemap.pl into the packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Bug ID: 16016 Summary: Integrate sitemap.pl into the packages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz The sitemap generating tool needs to be integrated into the packages so users can take advantage of it. Steps to do it: - Write koha-sitemap wrapper script that handles multiple instances and sets directories and files in a kosher place. - Integrate it into Apache -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 48859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48859&action=edit Bug 16016: Sitemap handling scripts for packages This patch introduces the koha-sitemap script. This script wraps calls to the misc/cronjobs/sitemap.pl script so it can be done easily instance-wise. It sets /var/lib/koha/${instance}/sitemap as the destination directory for the sitemap files. A followup will make them available through an Apache configuration entry. koha-functions.sh is provided with a handy is_sitemap_enabled function so we can later add filters to other commands (koha-list, koha-foreach, etc). To test: - You can build a package out of this patchset, or do the following on a kohadevbox cp debian/scripts/koha-functions.sh /usr/share/koha/bin - Run $ debian/scripts/koha-sitemap --help - Go through all the options (--enable, --disable, generate). (a) --enable: - debian/scripts/koha-sitemap --enable kohadev => SUCCESS: /var/lib/koha/kohadev/sitemap.enabled is created - call it again, a suitable warning is raised and the file is still there (b) debian/scripts/koha-sitemap --disable kohadev => SUCCESS: /var/lib/koha/kohadev/sitemap.enabled is deleted - call it again, a suitable warning is raised and the file does not exist (c) --generate: - debian/scripts/koha-sitemap --generate kohadev => SUCCESS: sitemapindex.xml and sitemap000X.xml files are generated in /var/lib/koha/kohadev/sitemap/ - Sign off :-D Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 48860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48860&action=edit Bug 16016: Apache file tweak This patch makes apache expose the sitemap files. This is suitable for including the sitemap in the robots.txt file as proposed in http://www.sitemaps.org/protocol.html#submit_robots Note: it depends on Apache 2.4+ so we can patch the file as needed. Older Apache users will be warned that they need to tweak the apache files on their own. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 [Bug 11190] sitemap.pl -- Generate a catalog sitemap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|robin@catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49194&action=edit Bug 16016: (followup) let the package know about koha-sitemap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48859|0 |1 is obsolete| | Attachment #48860|0 |1 is obsolete| | Attachment #49194|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 50498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50498&action=edit Bug 16016: Sitemap handling scripts for packages This patch introduces the koha-sitemap script. This script wraps calls to the misc/cronjobs/sitemap.pl script so it can be done easily instance-wise. It sets /var/lib/koha/${instance}/sitemap as the destination directory for the sitemap files. A followup will make them available through an Apache configuration entry. koha-functions.sh is provided with a handy is_sitemap_enabled function so we can later add filters to other commands (koha-list, koha-foreach, etc). Exposes sitemap files to apache. This is suitable for including the sitemap in the robots.txt file as proposed in http://www.sitemaps.org/protocol.html#submit_robots Note: it depends on Apache 2.4+ so we can patch the file as needed. Older Apache users will be warned that they need to tweak the apache files on their own. To test: - You can build a package out of this patchset, or do the following on a kohadevbox cp debian/scripts/koha-functions.sh /usr/share/koha/bin - Run $ debian/scripts/koha-sitemap --help - Go through all the options (--enable, --disable, generate). (a) --enable: - debian/scripts/koha-sitemap --enable kohadev => SUCCESS: /var/lib/koha/kohadev/sitemap.enabled is created - call it again, a suitable warning is raised and the file is still there (b) debian/scripts/koha-sitemap --disable kohadev => SUCCESS: /var/lib/koha/kohadev/sitemap.enabled is deleted - call it again, a suitable warning is raised and the file does not exist (c) --generate: - debian/scripts/koha-sitemap --generate kohadev => SUCCESS: sitemapindex.xml and sitemap000X.xml files are generated in /var/lib/koha/kohadev/sitemap/ - Sign off :-D Sponsored-by: Orex Digital Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50498|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 50831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50831&action=edit Bug 16016: Sitemap handling scripts for packages This patch introduces the koha-sitemap script. This script wraps calls to the misc/cronjobs/sitemap.pl script so it can be done easily instance-wise. It sets /var/lib/koha/${instance}/sitemap as the destination directory for the sitemap files. A followup will make them available through an Apache configuration entry. koha-functions.sh is provided with a handy is_sitemap_enabled function so we can later add filters to other commands (koha-list, koha-foreach, etc). Exposes sitemap files to apache. This is suitable for including the sitemap in the robots.txt file as proposed in http://www.sitemaps.org/protocol.html#submit_robots Note: it depends on Apache 2.4+ so we can patch the file as needed. Older Apache users will be warned that they need to tweak the apache files on their own. To test: - You can build a package out of this patchset, or do the following on a kohadevbox cp debian/scripts/koha-functions.sh /usr/share/koha/bin - Run $ debian/scripts/koha-sitemap --help - Go through all the options (--enable, --disable, generate). (a) --enable: - debian/scripts/koha-sitemap --enable kohadev => SUCCESS: /var/lib/koha/kohadev/sitemap.enabled is created - call it again, a suitable warning is raised and the file is still there (b) debian/scripts/koha-sitemap --disable kohadev => SUCCESS: /var/lib/koha/kohadev/sitemap.enabled is deleted - call it again, a suitable warning is raised and the file does not exist (c) --generate: - debian/scripts/koha-sitemap --generate kohadev => SUCCESS: sitemapindex.xml and sitemap000X.xml files are generated in /var/lib/koha/kohadev/sitemap/ - Sign off :-D Sponsored-by: Orex Digital Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Kyle beat me to it. One thing i saw:
if /usr/sbin/apache2ctl -v | grep -q -v "Server version: Apache/2.4"; then
I guess that will break it for Apache > 2.4? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Mirko Tietgen from comment #6)
Kyle beat me to it. One thing i saw:
if /usr/sbin/apache2ctl -v | grep -q -v "Server version: Apache/2.4"; then
I guess that will break it for Apache > 2.4?
I'll fix it once new Apaches are born. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16016 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org