[Bug 19249] New: date picker broken in quick add brief form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Bug ID: 19249 Summary: date picker broken in quick add brief form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If a date input like date of birth is mandatory, in quick add brief form the calendar icon appears but clicking on it does nothing. This is because quick add brief form creates a clone of inputs in the original form. An input with date picker is changed and linked to Javascript code (see calendar.inc) so it can not be cloned. Note also that creating a clone of an input in another form does not update the form value in its DOM. It can generate errors. In my opinion this feature should be reconsidered to hide unwanted fields instead of cloning wanted ones. Many bugs may be avoided. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17344 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 [Bug 3534] Patron quick add form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Also date of birth has a small JS code showing age when date is changed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 J. Kramer <gandaro@is-a-lie.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gandaro@is-a-lie.de --- Comment #2 from J. Kramer <gandaro@is-a-lie.de> --- How to reproduce this bug? 1. In the system preferences, add "dateofbirth" to "Patrons > General > BorrowerMandatoryField". 2. Go to the "Patrons" page. 3. Click "Quick add new patron" and select a patron category. 4. You will be shown the brief form. 5. Click on the calendar icon next to the "Date of birth" input field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 J. Kramer <gandaro@is-a-lie.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|date picker broken in quick |Date picker broken in |add brief form |"Quick add new patron" form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick@bywatersolutions.com |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|fridolin.somers@biblibre.co |koha-bugs@lists.koha-commun |m |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is still valid - when marking dateofbirth mandatory, the datepicker doesn't work on the quick add patron form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes, as well as all other date fields. As Fridolin said we should rework the way the fields are displayed/hidden. It's not an easy fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29303 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #5 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- I came here to log this bug - the clone of inputs has been giving me a headache this week when trying to target those areas with jQuery, and the non-working datepicker is a real issue for us. I realise it's not an easy fix from what's been said, but just adding a 'still valid' comment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can confirm this is still an issue on master. Kind of a sore spot: a quick is not as quick with a broken datepicker. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Agnes Rivers-Moore <arm@hanover.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm@hanover.ca --- Comment #7 from Agnes Rivers-Moore <arm@hanover.ca> --- In our system we do not have Date of Birth as mandatory. We actually have DateOfBirth in BorrowerUnwantedField so it does not appear in either the long or quick patron form. I wanted to comment that we are unable to get the registration date and expiry date fields to appear in the Quick Add form. They are listed as in the Preference PatronQuickAddFields, but are absent from the staff interface. Not sure if this is related to the broken picker issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Carolyn Hughesman <chughesman@cclsny.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chughesman@cclsny.org --- Comment #8 from Carolyn Hughesman <chughesman@cclsny.org> --- This is an issue for us. Quick add is not as useful to us without the datepicker. If fact, when adding a dateofbirth manually, it does not save. The dateofbirth field is empty when one goes back to edit said patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #9 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- On koha version 20.11, we could still enter the date manually but from 21.11.11, it's not even possible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Updating severity - this is a bad issue and we have kept it around for too long. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150589&action=edit Bug 19249: Fix date inputs on patron quick add form This patch create a "apply_flatpickr" JS function to make the code reusable from the template, where we loop over the date inputs to reinstantiate flatpickr. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150589|0 |1 is obsolete| | --- Comment #12 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 150632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150632&action=edit Bug 19249: Fix date inputs on patron quick add form This patch create a "apply_flatpickr" JS function to make the code reusable from the template, where we loop over the date inputs to reinstantiate flatpickr. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described, thanks for this important fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150632|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150644&action=edit Bug 19249: Fix date inputs on patron quick add form This patch create a "apply_flatpickr" JS function to make the code reusable from the template, where we loop over the date inputs to reinstantiate flatpickr. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 nicolas.giraud@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150644|0 |1 is obsolete| | --- Comment #15 from nicolas.giraud@inlibro.com --- Created attachment 150679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150679&action=edit Bug 19249: Fix date inputs on patron quick add form This patch create a "apply_flatpickr" JS function to make the code reusable from the template, where we loop over the date inputs to reinstantiate flatpickr. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Does not apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org