[Bug 8730] New: browse overlaying powered by
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Priority: P5 - low Change sponsored?: --- Bug ID: 8730 Assignee: oleonard@myacpl.org Summary: browse overlaying powered by Severity: minor Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Templates Product: Koha Created attachment 11989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11989&action=edit powered by floats on top When you use the browse results option on the detail page in conjunction with the powered by Koha message it overlays funny - the powered by comes on top of the browse but should probably fall behind. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12023&action=edit Bug 8730 - browse overlaying powered by This patch adds a "z-index" property to the CSS for the browse results menu so that it will appear on top of the "Powered by Koha" link. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- The result of the patch is: a.koha_url { display: none; background-color:#F3F3F3; padding-bottom:10px; z-index: 100; } koha_url is related to the "Powered by..." Link (not to the browse results): <a class="koha_url" rel="nofollow" href="http://koha-community.org">Koha</a> ...and a positive z-index will bring it on the top of the other contents, not behind, see: https://developer.mozilla.org/en-US/docs/CSS/Understanding_z-index/Adding_z-... Or did I miss something? :-) Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- The result of applying the patch should be this (starting at line 2219): a.koha_url { text-decoration:none; } /* pagination */ .pagination { position: absolute; top:32px; left: -1px; width: 100%; height:auto; border: 1px solid #D0D0D0; display: none; background-color:#F3F3F3; padding-bottom:10px; + z-index: 100; } Are you sure you're applying the patch on master? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12023|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12044&action=edit Bug 8730 - browse overlaying powered by This patch adds a "z-index" property to the CSS for the browse results menu so that it will appear on top of the "Powered by Koha" link. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 --- Comment #5 from Marc Véron <veron@veron.ch> --- Owen, Sorry for the confusion. Maybe it was a cache problem. Just tested again and it worked fine. While I was testing Kyle signed off :-) Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- works as expected, simple patch, nothing to say. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- No string changes, pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org