[Bug 41078] New: Improve handling of multiple covers on shelves/lists results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Bug ID: 41078 Summary: Improve handling of multiple covers on shelves/lists results in the OPAC Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org The lightbox gallery is used in the OPAC on the detail page and the search results page, but not the shelves/lists results page. In the list results, it still has the old clunky display for multiple covers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28180 Depends on| |26933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I'm actually going to change this to a bug from enhancement, because of the inconsistency between the detail page, search results, and list results. It looks like the list results are broken really. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- By essentially copying the method from bug 26933 and refactoring a bit of Javascript from there, I think that I have it working in Lists now too There is a little bit of duplication which could probably be optimised, but I think it's good enough for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 189142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189142&action=edit Bug 41078: Add lightbox to OPAC Lists for cover images This change adds the lightbox from OPAC search results to OPAC lists for cover images. Test plan: 0. Enable the following system preferences: - OPACAmazonCoverImages - GoogleJackets - OpenLibraryCovers 1. Using KTD, go to /cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Note that the lightbox for cover images which displays one cover at a time 3. Create a public list based off those search results 4. Go to that list and note that the 3 cover images just display all at the same time, which does not look good 5. Apply the patch 6. Refresh the page for the public list results 7. Note that the lightbox is now used like in OPAC search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I'm seeing cover images on opac-detail.pl but not in search results or lists. The search results and list contents pages show this js error: Uncaught ReferenceError: verify_cover_images is not defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #4)
I'm seeing cover images on opac-detail.pl but not in search results or lists. The search results and list contents pages show this js error:
Uncaught ReferenceError: verify_cover_images is not defined
Thanks for that. Looks like I have the fail locally but forgot to "git add" it. Oops! I'll get that fixed up pronto. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #5)
Thanks for that. Looks like I have the fail locally but forgot to "git add" it. Oops! I'll get that fixed up pronto.
"file" not "fail". I moved "function verify_cover_images" into a JS file so it could be shared between the two templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189142|0 |1 is obsolete| | --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Created attachment 189246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189246&action=edit Bug 41078: Add lightbox to OPAC Lists for cover images This change adds the lightbox from OPAC search results to OPAC lists for cover images. Test plan: 0. Enable the following system preferences: - OPACAmazonCoverImages - GoogleJackets - OpenLibraryCovers 1. Using KTD, go to /cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Note that the lightbox for cover images which displays one cover at a time 3. Create a public list based off those search results 4. Go to that list and note that the 3 cover images just display all at the same time, which does not look good 5. Apply the patch 6. Refresh the page for the public list results 7. Note that the lightbox is now used like in OPAC search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189246|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189319&action=edit Bug 41078: Add lightbox to OPAC Lists for cover images This change adds the lightbox from OPAC search results to OPAC lists for cover images. Test plan: 0. Enable the following system preferences: - OPACAmazonCoverImages - GoogleJackets - OpenLibraryCovers 1. Using KTD, go to /cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Note that the lightbox for cover images which displays one cover at a time 3. Create a public list based off those search results 4. Go to that list and note that the 3 cover images just display all at the same time, which does not look good 5. Apply the patch 6. Refresh the page for the public list results 7. Note that the lightbox is now used like in OPAC search results Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189320&action=edit Bug 41078: (follow-up) Use __() instead of _() Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Thanks, Owen. You're a legend. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189319|0 |1 is obsolete| | --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 189474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189474&action=edit Bug 41078: Add lightbox to OPAC Lists for cover images This change adds the lightbox from OPAC search results to OPAC lists for cover images. Test plan: 0. Enable the following system preferences: - OPACAmazonCoverImages - GoogleJackets - OpenLibraryCovers 1. Using KTD, go to /cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Note that the lightbox for cover images which displays one cover at a time 3. Create a public list based off those search results 4. Go to that list and note that the 3 cover images just display all at the same time, which does not look good 5. Apply the patch 6. Refresh the page for the public list results 7. Note that the lightbox is now used like in OPAC search results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189320|0 |1 is obsolete| | --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 189475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189475&action=edit Bug 41078: (follow-up) Use __() instead of _() Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- please add release notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not applied to 24.11.x for UI stability in LTS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #16)
Not applied to 24.11.x for UI stability in LTS
Any way I can convince you to change your mind? UI stability in LTS makes sense, but by not including this change would it make it harder to include future changes to opac-results.tt and opac-shelves.tt? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The lightbox gallery is release notes| |used in the OPAC on the | |detail page and the search | |results page to beautifully | |show multiple covers for an | |item. With this change, the | |lightbox is added to the | |OPAC shelves/lists results | |page as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- It is a balance to find. Thinks about OPAC that have CSS/JS customizations, this change may break them. I think people willing to follow changes will upgrade to 25.05/11. Also Bug 26933 created some side-effects so I would like to prioritize on stability. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41655 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41655 [Bug 41655] Local OPAC covers are not displayed in OPAC lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41078 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org