[Bug 36204] New: Add othernames to the PatronAutoComplete display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 Bug ID: 36204 Summary: Add othernames to the PatronAutoComplete display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some librarians would like to able to see the othernames field in the PatronAutoComplete dropdown to help differentiate between patrons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162610&action=edit Bug 36204: Add othernames field to PatronAutoComplete display To test: 1. APPLY PATCH 2. Make sure PatronAutoComplete is on. 3. Find or add othernames to a patron record. 4. Search for that patron and make sure othernames properly displays in the dropdown. 5. Add a middle name to that patron and search again, make sure the display looks good. 6. Remove the othernames field and search again, make sure the display looks good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162610|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163028&action=edit Bug 36204: Add othernames field to PatronAutoComplete display To test: 1. APPLY PATCH 2. Make sure PatronAutoComplete is on. 3. Find or add othernames to a patron record. 4. Search for that patron and make sure othernames properly displays in the dropdown. 5. Add a middle name to that patron and search again, make sure the display looks good. 6. Remove the othernames field and search again, make sure the display looks good. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163028|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163029&action=edit Bug 36204: Add othernames field to PatronAutoComplete display To test: 1. APPLY PATCH 2. Make sure PatronAutoComplete is on. 3. Find or add othernames to a patron record. 4. Search for that patron and make sure othernames properly displays in the dropdown. 5. Add a middle name to that patron and search again, make sure the display looks good. 6. Remove the othernames field and search again, make sure the display looks good. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This is a trivial change that works as expected, is correctly implemented and no QA complaints. Straight QA. Not offended if someone else wants to give it another round of testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please rebase? 163029 - Bug 36204: Add othernames field to PatronAutoComplete display Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36204: Add othernames field to PatronAutoComplete display Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/staff-global.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/staff-global.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/staff-global.js error: Failed to merge in the changes. Patch failed at 0001 Bug 36204: Add othernames field to PatronAutoComplete display hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-36204-Add-othernames-field-to-PatronAutoComple-9i58z0qw.patch kohadev-koha@kohadevbox:koha(main|AM 1/1)$ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163029|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165223&action=edit Bug 36204: Add othernames field to PatronAutoComplete display To test: 1. APPLY PATCH 2. Make sure PatronAutoComplete is on. 3. Find or add othernames to a patron record. 4. Search for that patron and make sure othernames properly displays in the dropdown. 5. Add a middle name to that patron and search again, make sure the display looks good. 6. Remove the othernames field and search again, make sure the display looks good. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- rebased for current main, back to PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #7)
rebased for current main, back to PQA
Will be back for this one on Monday! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- On the other patron pages we display the othername in parenthesis after the first name. The patron auto-complete is a little differently formatted, but I feel like this would be more consistent: Suggested display: Schneider, Nicole (othername) Current display: Schneide, Nicole othername ---- Patron account (for comparison) Nicole (othername) Schneider Patron search results (for comparison) Schneider, Nicole (othername) Updated in a follow-up (hope you agree). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 23.11.x Not backported -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org