[Bug 16812] New: Remove multiple onclick event from z3950_auth_search.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Bug ID: 16812 Summary: Remove multiple onclick event from z3950_auth_search.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx@gmail.com Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 16600 z3950_auth_search.tt has various onclick events used in links. This patch propose to triger event via JQuery .on() Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 [Bug 16600] Remove some obsolete references to Greybox in some templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52868&action=edit Bug 16812: Remove multiple onclick event from z3950_auth_search.tt z3950_auth_search.tt has various onclick events used in links. This patch propose to triger event via JQuery .on() Also add Font Awesome Icons to "Select/Clear all" links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove multiple onclick |Remove multiple onclick |event from |events from |z3950_auth_search.tt |z3950_auth_search.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52868|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52871&action=edit Bug 16812: Remove multiple onclick events for all z3950_search.tt z3950_auth_search.tt has various onclick events used in links. Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt This patch propose to triger event via JQuery .on() Also add Font Awesome Icons to "Select/Clear all" and "Clear search form" links To test: 1-Apply patch 2-Go to Authorities > click New from Z39.50 3-Fill some fields and click in "Clear search form" link 4-Search under "Dalton" or another author that launch too many headings 5-Clic in some heading and notice the dialog open, test to "Import" and close the dialog "X". Use the "Import" from table too. Go to Cataloging > New from Z39.50/SRU Repeat steps 1 to 5. But this time with bib records. Go to Adquisition > Open or Create a basket and choose to "Add to basket" button. A modal appear, chose the option "Order from external source" Repeat steps 1 to 5. But this thime with bib records. NOTE: The icon trash for "Clear search form" has been selected according with module "Advanced search" there is an icon trash with link "Clear fields" that has the same fuctionality. Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove multiple onclick |Remove multiple onclick |events from |events for all |z3950_auth_search.tt |z3950_search.tt CC| |oleonard@myacpl.org, | |veron@veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52871|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52872&action=edit Bug 16812: Remove multiple onclick events for all z3950_search.tt z3950_auth_search.tt has various onclick events used in links. Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt This patch propose to triger event via JQuery .on() Also add Font Awesome Icons to "Select/Clear all" and "Clear search form" links To test: 1-Apply bug 1660 on top 2-Apply patch 3-Go to Authorities > click New from Z39.50 4-Fill some fields and click in "Clear search form" link 5-Search under "Dalton" or another author that launch too many headings 6-Clic in some heading and notice the dialog open, test to "Import" and close the dialog "X". Use the "Import" from table too. Go to Cataloging > New from Z39.50/SRU Repeat steps 3 to 6. But this time with bib records. Go to Adquisition > Open or Create a basket and choose to "Add to basket" button. A modal appear, chose the option "Order from external source" Repeat steps 3 to 6. But this thime with bib records. NOTE: The icon trash for "Clear search form" has been selected according with module "Advanced search" there is an icon trash with link "Clear fields" that has the same fuctionality. Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52872|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52873&action=edit Bug 16812: Remove multiple onclick events for all z3950_search.tt z3950_auth_search.tt has various onclick events used in links. Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt This patch propose to triger event via JQuery .on() Also add Font Awesome Icons to "Select/Clear all" and "Clear search form" links To test: 1-Apply bug 16600 on top 2-Apply patch 3-Go to Authorities > click New from Z39.50 4-Fill some fields and click in "Clear search form" link 5-Search under "Dalton" or another author that launch too many headings 6-Clic in some heading and notice the dialog open, test to "Import" and close the dialog "X". Use the "Import" from table too. Go to Cataloging > New from Z39.50/SRU Repeat steps 3 to 6. But this time with bib records. Go to Adquisition > Open or Create a basket and choose to "Add to basket" button. A modal appear, chose the option "Order from external source" Repeat steps 3 to 6. But this thime with bib records. NOTE: The icon trash for "Clear search form" has been selected according with module "Advanced search" there is an icon trash with link "Clear fields" that has the same fuctionality. Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52873|0 |1 is obsolete| | --- Comment #5 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52885&action=edit Bug 16812: Remove multiple onclick events for all z3950_search.tt z3950_auth_search.tt has various onclick events used in links. Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt This patch propose: -Trigger event via JQuery .on() -Make a separate .js and .inc file -Reduce the number of line and redundant code -Also add Font Awesome Icons to "Select/Clear all" and "Clear search form" links To test: 1-Apply bug 16600 on top 2-Apply patch 3-Go to Authorities > click New from Z39.50 4-Fill some fields and click in "Clear search form" link 5-Search under "Dalton" or another author that launch too many headings 6-Clic in some heading and notice the dialog open, test to "Import" and close the dialog "X". Use the "Import" from table too. Go to Cataloging > New from Z39.50/SRU Repeat steps 3 to 6. But this time with bib records. Go to Adquisition > Open or Create a basket and choose to "Add to basket" button. A modal appear, chose the option "Order from external source" Repeat steps 3 to 6. But this thime with bib records. NOTE: The icon trash for "Clear search form" has been selected according with module "Advanced search" there is an icon trash with link "Clear fields" that has the same fuctionality. For some reason the image loading-small.gif does not charge all times when the code is get out of the template. DataTable it is specific for each template Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove multiple onclick |Revise JS script for |events for all |z3950_search.tts and remove |z3950_search.tt |onclick events -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52885|0 |1 is obsolete| | --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52886&action=edit Bug 16812: Revise JS script for z3950_search.tts and remove onclick events Modify JS script to all templates for z3950_search.tt and reduce the redundant code This patch propose: -z3950_auth_search.tt has various onclick events used in links. Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt -Trigger onclick events via JQuery .on() -Make a separate .js and .inc file -Reduce the number of line and redundant code -Also add Font Awesome Icons to "Select/Clear all" and "Clear search form" links To test: 1-Apply bug 16600 on top 2-Apply patch 3-Go to Authorities > click New from Z39.50 4-Fill some fields and click in "Clear search form" link 5-Search under "Dalton" or another author that launch too many headings 6-Clic in some heading and notice the dialog open, test: "Preview MARC", ISBD (when showed), "Import" and close the dialog "X". Use the "Import" from table too. 7-Use the "next/previous page" button, change "Go to page" to number in and out of the range presented, also test whit a letter, etc. Go to Cataloging > New from Z39.50/SRU Repeat steps 3 to 6. But this time with bib records. Go to Adquisition > Open or Create a basket and choose to "Add to basket" button. A modal appear, chose the option "Order from external source" Repeat steps 3 to 6. But this thime with bib records. NOTE: The icon trash for "Clear search form" has been selected according with module "Advanced search" there is an icon trash with link "Clear fields" that has the same fuctionality. For some reason the image loading-small.gif does not charge all times when the code is get out of the template. DataTable it is specific for each template Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 --- Comment #7 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- *** Bug 16811 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52886|0 |1 is obsolete| | --- Comment #8 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53005&action=edit Bug 16812: Revise JS script for z3950_search.tts and remove onclick events Modify JS script to all templates for z3950_search.tt and reduce the redundant code This patch propose: -z3950_auth_search.tt has various onclick events used in links. Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt -Trigger onclick events via JQuery .on() -Make a separate .js and .inc file -Reduce the number of line and redundant code -Also add Font Awesome Icons to "Select/Clear all" and "Clear search form" links To test: 1-Apply bug 16600 on top 2-Apply patch 3-Go to Authorities > click New from Z39.50 4-Fill some fields and click in "Clear search form" link 5-Search under "Dalton" or another author that launch too many headings 6-Clic in some heading and notice the dialog open, test: "Preview MARC", ISBD (when showed), "Import" and close the dialog "X". Use the "Import" from table too. 7-Use the "next/previous page" button, change "Go to page" to number in and out of the range presented, also test whit a letter, etc. Go to Cataloging > New from Z39.50/SRU Repeat steps 3 to 6. But this time with bib records. Go to Adquisition > Open or Create a basket and choose to "Add to basket" button. A modal appear, chose the option "Order from external source" Repeat steps 3 to 6. But this thime with bib records. NOTE: The icon trash for "Clear search form" has been selected according with module "Advanced search" there is an icon trash with link "Clear fields" that has the same fuctionality. For some reason the image loading-small.gif does not charge all times when the code is get out of the template. (Fixed with this new patch) DataTable it is specific for each template Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53005|0 |1 is obsolete| | --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53006&action=edit Bug 16812: Revise JS script for z3950_search.tts and remove onclick events Modify JS script to all templates for z3950_search.tt and reduce the redundant code This patch propose: -z3950_auth_search.tt has various onclick events used in links. Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt -Trigger onclick events via JQuery .on() -Make a separate .js and .inc file -Reduce the number of line and redundant code -Also add Font Awesome Icons to "Select/Clear all" and "Clear search form" links To test: 1-Apply bug 16600 on top 2-Apply patch 3-Go to Authorities > click New from Z39.50 4-Fill some fields and click in "Clear search form" link 5-Search under "Dalton" or another author that launch too many headings 6-Clic in some heading and notice the dialog open, test: "Preview MARC", ISBD (when showed), "Import" and close the dialog "X". Use the "Import" from table too. 7-Use the "next/previous page" button, change "Go to page" to number in and out of the range presented, also test whit a letter, etc. Go to Cataloging > New from Z39.50/SRU Repeat steps 3 to 6. But this time with bib records. Go to Adquisition > Open or Create a basket and choose to "Add to basket" button. A modal appear, chose the option "Order from external source" Repeat steps 3 to 6. But this thime with bib records. NOTE: The icon trash for "Clear search form" has been selected according with module "Advanced search" there is an icon trash with link "Clear fields" that has the same fuctionality. For some reason the image loading-small.gif does not charge all times when the code is get out of the template. (Fixed with this new patch) DataTable it is specific for each template Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53006|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53308&action=edit [SIGNED-OFF] Bug 16812: Revise JS script for z3950_search.tts and remove onclick events Modify JS script to all templates for z3950_search.tt and reduce the redundant code This patch propose: -z3950_auth_search.tt has various onclick events used in links. Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt -Trigger onclick events via JQuery .on() -Make a separate .js and .inc file -Reduce the number of line and redundant code -Also add Font Awesome Icons to "Select/Clear all" and "Clear search form" links To test: 1-Apply bug 16600 on top 2-Apply patch 3-Go to Authorities > click New from Z39.50 4-Fill some fields and click in "Clear search form" link 5-Search under "Dalton" or another author that launch too many headings 6-Clic in some heading and notice the dialog open, test: "Preview MARC", ISBD (when showed), "Import" and close the dialog "X". Use the "Import" from table too. 7-Use the "next/previous page" button, change "Go to page" to number in and out of the range presented, also test whit a letter, etc. Go to Cataloging > New from Z39.50/SRU Repeat steps 3 to 6. But this time with bib records. Go to Adquisition > Open or Create a basket and choose to "Add to basket" button. A modal appear, chose the option "Order from external source" Repeat steps 3 to 6. But this thime with bib records. NOTE: The icon trash for "Clear search form" has been selected according with module "Advanced search" there is an icon trash with link "Clear fields" that has the same fuctionality. For some reason the image loading-small.gif does not charge all times when the code is get out of the template. (Fixed with this new patch) DataTable it is specific for each template Sponsored-by: Universidad de El Salvador Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53308|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53348&action=edit [PASSED QA] Bug 16812: Revise JS script for z3950_search.tts and remove onclick events Modify JS script to all templates for z3950_search.tt and reduce the redundant code This patch propose: -z3950_auth_search.tt has various onclick events used in links. Also fix: acqui/z3950_search.tt and cataloguing/z3950_search.tt -Trigger onclick events via JQuery .on() -Make a separate .js and .inc file -Reduce the number of line and redundant code -Also add Font Awesome Icons to "Select/Clear all" and "Clear search form" links To test: 1-Apply bug 16600 on top 2-Apply patch 3-Go to Authorities > click New from Z39.50 4-Fill some fields and click in "Clear search form" link 5-Search under "Dalton" or another author that launch too many headings 6-Clic in some heading and notice the dialog open, test: "Preview MARC", ISBD (when showed), "Import" and close the dialog "X". Use the "Import" from table too. 7-Use the "next/previous page" button, change "Go to page" to number in and out of the range presented, also test whit a letter, etc. Go to Cataloging > New from Z39.50/SRU Repeat steps 3 to 6. But this time with bib records. Go to Adquisition > Open or Create a basket and choose to "Add to basket" button. A modal appear, chose the option "Order from external source" Repeat steps 3 to 6. But this thime with bib records. NOTE: The icon trash for "Clear search form" has been selected according with module "Advanced search" there is an icon trash with link "Clear fields" that has the same fuctionality. For some reason the image loading-small.gif does not charge all times when the code is get out of the template. (Fixed with this new patch) DataTable it is specific for each template Sponsored-by: Universidad de El Salvador Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Hector! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #13 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org