[Bug 15777] New: Refactor loop in which Record::Processor does not initialize parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Bug ID: 15777 Summary: Refactor loop in which Record::Processor does not initialize parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org foreach my $filter (@{ $req_filters }) { next unless $filter; my $filter_module = $filter =~ m/:/ ? $filter : "Koha::Filter::${schema}::${filter}"; if (can_load( modules => { $filter_module => undef } )) { my $object = $filter_module->new(); $filter_module->initialize($param); push @filters, $object; } } "$filter_module->initialize($param);" should be "$object->initialize($param); Additionally, object isn't really descriptive, and it isn't clear that $filter is the string name of the filter. So, this loop will have some variable renaming done on it. And the first commit will include a test that fails to initialize. And the second commit will include this revision which should then pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |mtompset@hotmail.com Status|NEW |ASSIGNED Blocks| |10589 Severity|enhancement |minor Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 [Bug 10589] Override OpacHiddenItems based on Patron Category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 47941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47941&action=edit Bug 15777 - Test to prove initialization isn't working correctly. TEST PLAN --------- 1) Apply this testing patch 2) prove -v t/RecordProcessor.t -- tests will fail. 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 47942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47942&action=edit Bug 15777 - Fix base class to prove refactor and fix required TEST PLAN --------- 1) Apply the testing patch and this patch 2) prove -v t/RecordProcess.t -- will complain about string use with "use strict". This is because it is using the module name, instead of the object instantiated with new(). 3) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 47943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47943&action=edit Bug 15777 - Refactor and fix the RecordProcessor class TEST PLAN --------- 1) Apply all three patches 2) prove -v t/RecordProcessor.t -- all should be successful 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47941|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 47978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47978&action=edit Bug 15777 - Test to prove initialization isn't working correctly. TEST PLAN --------- 1) Apply this testing patch 2) prove -v t/RecordProcessor.t -- tests will fail. 3) run koha qa test tools Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47942|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 47979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47979&action=edit Bug 15777 - Fix base class to prove refactor and fix required TEST PLAN --------- 1) Apply the testing patch and this patch 2) prove -v t/RecordProcess.t -- will complain about string use with "use strict". This is because it is using the module name, instead of the object instantiated with new(). 3) run koha qa test tools. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47943|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 47980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47980&action=edit Bug 15777 - Refactor and fix the RecordProcessor class TEST PLAN --------- 1) Apply all three patches 2) prove -v t/RecordProcessor.t -- all should be successful 3) run koha qa test tools Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47978|0 |1 is obsolete| | Attachment #47979|0 |1 is obsolete| | Attachment #47980|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47988&action=edit Bug 15777 - Test to prove initialization isn't working correctly. TEST PLAN --------- 1) Apply this testing patch 2) prove -v t/RecordProcessor.t -- tests will fail. 3) run koha qa test tools Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47990&action=edit Bug 15777 - Fix base class to prove refactor and fix required TEST PLAN --------- 1) Apply the testing patch and this patch 2) prove -v t/RecordProcess.t -- will complain about string use with "use strict". This is because it is using the module name, instead of the object instantiated with new(). 3) run koha qa test tools. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47991&action=edit Bug 15777 - Refactor and fix the RecordProcessor class TEST PLAN --------- 1) Apply all three patches 2) prove -v t/RecordProcessor.t -- all should be successful 3) run koha qa test tools Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 [Bug 11592] opac detail scripts do not respect MARC tag visibility -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47991|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 48000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48000&action=edit Bug 15777 - Refactor and fix the RecordProcessor class TEST PLAN --------- 1) Apply all three patches 2) prove -v t/RecordProcessor.t -- all should be successful 3) run koha qa test tools Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Sorry... git bz attach gone awry. Nothing changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 [Bug 15870] Add Filter for MARC to respect visibility settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 [Bug 15871] Improve perl critic of t/RecordProcessor.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #12 from Brendan Gallagher <brendan@bywatersolutions.com> --- pushed to Master - Should be in the May 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org