[Bug 38170] New: xt/verify-yarnlock.t doesn't detect removal of packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38170 Bug ID: 38170 Summary: xt/verify-yarnlock.t doesn't detect removal of packages Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: victor@tuxayo.net QA Contact: testopia@bugs.koha-community.org Found while reviewing Bug 38164 Test plan (not dependent on Bug 38164 being merged or not) 1. From package.json, remove the 3 @fortawesome* packages 2. Run prove xt/verify-yarnlock.t 3. It works! :o The test is working if I upgrade (edit package.json) webpack-cli from "^4.9.2" to "^5.1.4" And it's working if I add in package.json this "esperanto.js": "^1.1.0", I just searched a package that has no dependency (maybe testing with random stuff is a bit dangerous ^^") Are there other cases to handle? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38170 --- Comment #1 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Maybe we are lucky and `yarn check` will handle this without us having to do anything on an up to date yarn. That will depend on what happens with bug 36682 (upgrade yarn vs switch to pnpm) If there is an equivalent concern with pnpm then hopefully there is something that can nicely replace `yarn check`. At least we have the test cases here :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org